Update to new browser-ui-test version #123338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
notriddle
reviewed
Apr 2, 2024
There was a problem hiding this comment.
For anyone else who's reading this code, I've tried to reduce the amount of code I need to review using this AWK script:
cat 123338.diff | awk '
/^(---|\+\+\+)/ {print; next}
/^-/ { print stored; stored = $0 }
/^\+/ {
xstored = stored;
gsub(/^-/, "+", xstored);
gsub(/\(/, "[", xstored);
gsub(/\)/, "]", xstored);
x0 = $0;
gsub(/\(/, "[", x0);
gsub(/\)/, "]", x0);
if (xstored != x0) { print stored; print }
stored = ""
}' > 123338.2.diffIt skips over the zillions of changes that only swapped round braces for square brackets.
|
Removed unneeded comments. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2024
…llaumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#122614 (rustdoc-search: shard the search result descriptions) - rust-lang#123338 (Update to new browser-ui-test version) - rust-lang#123366 (Minor by_move_body impl cleanups) - rust-lang#123371 (Remove dangling `.mir.stderr` and `.thir.stderr` test files) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 2, 2024
Rollup merge of rust-lang#123338 - GuillaumeGomez:update-browser-ui-test, r=notriddle Update to new browser-ui-test version This new version brings a lot of new internal improvements (mostly around validating the commands input). It also improved some command names and arguments. r? `@notriddle`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new version brings a lot of new internal improvements (mostly around validating the commands input).
It also improved some command names and arguments.
r? @notriddle