Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #126590

Closed
wants to merge 8 commits into from
Closed

Rollup of 3 pull requests #126590

wants to merge 8 commits into from

Commits on Jun 17, 2024

  1. Do not ICE in privacy when type inference fails.

    @cjgillot
    cjgillot committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    9074427 View commit details
    Browse the repository at this point in the history

  2. Add regression test

    @oli-obk
    oli-obk committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    97372c8 View commit details
    Browse the repository at this point in the history

  3. Remove an unused validation error variant

    @oli-obk
    oli-obk committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    4e5dfb6 View commit details
    Browse the repository at this point in the history

  4. Use subtyping instead of equality, since method resolution also uses … 

    …subtyping
    @oli-obk
    oli-obk committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    94f5495 View commit details
    Browse the repository at this point in the history

  5. Remove windows-specific copy of test

    @oli-obk
    oli-obk committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    3e6e6b1 View commit details
    Browse the repository at this point in the history

  6. Rollup merge of rust-lang#126128 - oli-obk:method_ice, r=lcnr 

    Consistently use subtyping in method resolution

fixes rust-lang#126062

An earlier version of this PR modified how we compute variance, but the root cause was an inconsistency between the usage of `eq` and `sub`, where we assumed that the latter passing implies the former will pass.

r? `@compiler-errors`
    @GuillaumeGomez
    GuillaumeGomez committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    ca70f3e View commit details
    Browse the repository at this point in the history

  7. Rollup merge of rust-lang#126577 - oli-obk:static_valtrees, r=RalfJung 

    const_refs_to_static test and cleanup

r? `@RalfJung`

test the existing behaviour of adt_const_params combined with const_refs_to_static.

also remove a dead error variant about consts referring to statics
    @GuillaumeGomez
    GuillaumeGomez committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    879c151 View commit details
    Browse the repository at this point in the history

  8. Rollup merge of rust-lang#126584 - cjgillot:issue-122736, r=michaelwo… 

    …erister

Do not ICE in privacy when type inference fails.

Fixes rust-lang#122736
    @GuillaumeGomez
    GuillaumeGomez committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    3b3ee43 View commit details
    Browse the repository at this point in the history