Tweak -1 as usize suggestion
#127349
Merged
Tweak -1 as usize suggestion
#127349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing a negative unsigned integer literal, use a verbose suggestion and account for `as` casting.
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
S-waiting-on-review
faptc
reviewed
Jul 5, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 5, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#124290 (DependencyList: removed outdated comment) - rust-lang#126709 (Migrate `include_bytes_deps`, `optimization-remarks-dir-pgo`, `optimization-remarks-dir`, `issue-40535` and `rmeta-preferred` `run-make` tests to rmake) - rust-lang#127214 (Use the native unwind function in miri where possible) - rust-lang#127320 (Update windows-bindgen to 0.58.0) - rust-lang#127349 (Tweak `-1 as usize` suggestion) - rust-lang#127352 (coverage: Rename `mir::coverage::BranchInfo` to `CoverageInfoHi`) - rust-lang#127359 (Improve run make llvm ident code) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 5, 2024
Rollup merge of rust-lang#127349 - estebank:negative-unsigned-literal, r=petrochenkov Tweak `-1 as usize` suggestion When writing a negative unsigned integer literal, use a verbose suggestion and account for `as` casting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a negative unsigned integer literal, use a verbose suggestion and account for
ascasting.