Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest using map_or when Option<&T>::unwrap_or where T: Deref fails #127629

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Suggest using map_or when Option<&T>::unwrap_or where T: Deref fails #127629

merged 5 commits into from
Jul 16, 2024

Commits on Jul 12, 2024

  1. Add regression test for issue 127545

    @tesuji
    tesuji committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    abeb720 View commit details
    Browse the repository at this point in the history

  2. Add suggestion to use Option::map_or over erroneous Option::unwrap_or

    @tesuji
    tesuji committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    5e1cabe View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. add test for Result<&T, _> where T; Deref

    @tesuji
    tesuji committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    9c1a9e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Add support for `Result<&T, _>'

    @tesuji
    tesuji committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    9c3c278 View commit details
    Browse the repository at this point in the history

  2. Use multipart_suggestion to avoid place holder in span_to_snippet 

    CO-AUTHORED-BY: Esteban Küber <esteban@kuber.com.ar>
    @tesuji @estebank
    tesuji and estebank committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    bdc9df2 View commit details
    Browse the repository at this point in the history