Add internal lint for detecting non-glob imports of `rustc_type_ir::inherent` #127854

fmease · 2024-07-17T10:38:59Z

r? compiler-errors

fmease · 2024-07-17T10:49:02Z

compiler/rustc_lint/src/internal.rs

+                    match cx.tcx.sess.source_map().span_to_snippet(path.span).as_deref() {
+                        Ok("self") => (path.span, "*"),


Super gross but I couldn't think of anything better w/o tweaking AST lowering (e.g., to use mark_with_reason in this case). This is for dealing with use path::to::{self}; properly.

In HIR, there's no way to tell whether use path::to; comes from use path::{to}; or use path::to::{self}; but it matters for diagnostics (need to suggest ::* vs. * + differing spans partly cuz use path::to::{self::*}; isn't allowed). Span etc. doesn't help.

fmease · 2024-07-17T10:50:10Z

compiler/rustc_lint/src/internal.rs

+    report_in_external_macro: true
+}
+
+declare_lint_pass!(TypeIr => [NON_GLOB_IMPORT_OF_TYPE_IR_INHERENT]);


I'm inclined to consolidate the lint passes TypeIr and TyTyKind to reduce bloat. I'd just need to think of a good name 🤔

"opinionated imports"?

fmease · 2024-07-17T10:52:39Z

compiler/rustc_type_ir/src/effects.rs

@@ -1,4 +1,4 @@
-use crate::inherent::{AdtDef, IntoKind, Ty};
+use crate::inherent::*;


compiler-errors

This is great, thanks

compiler-errors · 2024-07-17T14:31:56Z

@bors r+ rollup

bors · 2024-07-17T14:31:59Z

📌 Commit adc48b0 has been approved by compiler-errors

It is now in the queue for this repository.

…t-lint, r=compiler-errors Add internal lint for detecting non-glob imports of `rustc_type_ir::inherent` rust-lang#127627 (comment) r? compiler-errors

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127542 ([`macro_metavar_expr_concat`] Add support for literals) - rust-lang#127652 (Unignore cg_gcc fmt) - rust-lang#127664 (Fix precise capturing suggestion for hidden regions when we have APITs) - rust-lang#127806 (Some parser improvements) - rust-lang#127828 (Commonize `uname -m` results for `aarch64` in docker runner) - rust-lang#127845 (unix: break `stack_overflow::install_main_guard` into smaller fn) - rust-lang#127854 (Add internal lint for detecting non-glob imports of `rustc_type_ir::inherent`) - rust-lang#127861 (Document the column numbers for the dbg! macro) - rust-lang#127875 (style-guide: Clarify version-sorting) r? `@ghost` `@rustbot` modify labels: rollup

tgross35 · 2024-07-18T00:50:40Z

@bors r- failed the rollup in #127876 (comment). Lint didn't get registered?

fmease · 2024-07-18T02:49:28Z

Lint didn't get registered?

It's registered … in a stage2 compiler but apparently we also run tests/ui-fulldeps/ with a stage1 compiler during a full build (apart from stageN, N>1).

@bors try

bors · 2024-07-18T02:50:40Z

⌛ Trying commit bd6a408 with merge 647fdf7...

…lint, r=<try> Add internal lint for detecting non-glob imports of `rustc_type_ir::inherent` rust-lang#127627 (comment) r? compiler-errors

bors · 2024-07-18T04:42:21Z

☀️ Try build successful - checks-actions
Build commit: 647fdf7 (647fdf7192d0da819a91af60a41fab722116bc10)

…nherent`

fmease · 2024-07-18T11:04:24Z

@bors r=compiler-errors

bors · 2024-07-18T11:04:27Z

📌 Commit 2507301 has been approved by compiler-errors

It is now in the queue for this repository.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#124881 (Use ThreadId instead of TLS-address in `ReentrantLock`) - rust-lang#127656 (make pub_use_of_private_extern_crate show up in cargo's future breakage reports) - rust-lang#127748 (Use Option's discriminant as its size hint) - rust-lang#127854 (Add internal lint for detecting non-glob imports of `rustc_type_ir::inherent`) - rust-lang#127908 (Update extern linking documentation) - rust-lang#127919 (Allow a git command for getting the current branch in bootstrap to fail) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#127854 - fmease:glob-import-type_ir_inherent-lint, r=compiler-errors Add internal lint for detecting non-glob imports of `rustc_type_ir::inherent` rust-lang#127627 (comment) r? compiler-errors

rustbot assigned compiler-errors Jul 17, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 17, 2024

fmease commented Jul 17, 2024

View reviewed changes

compiler-errors approved these changes Jul 17, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2024

matthiaskrgr mentioned this pull request Jul 17, 2024

Rollup of 9 pull requests #127876

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2024

fmease force-pushed the glob-import-type_ir_inherent-lint branch from adc48b0 to bd6a408 Compare July 18, 2024 02:44

This comment was marked as outdated.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2024

fmease force-pushed the glob-import-type_ir_inherent-lint branch from bd6a408 to ee27b4c Compare July 18, 2024 10:48

This comment was marked as outdated.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 18, 2024

Add internal lint for detecting non-glob imports of `rustc_type_ir::i…

2507301

…nherent`

fmease force-pushed the glob-import-type_ir_inherent-lint branch from ee27b4c to 2507301 Compare July 18, 2024 11:04

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 18, 2024

matthiaskrgr mentioned this pull request Jul 18, 2024

Rollup of 6 pull requests #127924

Merged

bors merged commit 4ad2c99 into rust-lang:master Jul 18, 2024
6 checks passed

rustbot added this to the 1.81.0 milestone Jul 18, 2024

fmease deleted the glob-import-type_ir_inherent-lint branch July 18, 2024 20:49

fmease mentioned this pull request Aug 31, 2024

Deny imports of rustc_type_ir::inherent outside of type ir + new trait solver #129678

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add internal lint for detecting non-glob imports of `rustc_type_ir::inherent` #127854

Add internal lint for detecting non-glob imports of `rustc_type_ir::inherent` #127854

fmease commented Jul 17, 2024

fmease Jul 17, 2024 •

edited

Loading

fmease Jul 17, 2024 •

edited

Loading

compiler-errors Jul 17, 2024

fmease Jul 17, 2024

compiler-errors Jul 17, 2024

compiler-errors left a comment

compiler-errors commented Jul 17, 2024

bors commented Jul 17, 2024

tgross35 commented Jul 18, 2024

fmease commented Jul 18, 2024 •

edited

Loading

bors commented Jul 18, 2024

bors commented Jul 18, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

fmease commented Jul 18, 2024

bors commented Jul 18, 2024

		match cx.tcx.sess.source_map().span_to_snippet(path.span).as_deref() {
		Ok("self") => (path.span, "*"),

		@@ -1,4 +1,4 @@
		use crate::inherent::{AdtDef, IntoKind, Ty};
		use crate::inherent::*;

Add internal lint for detecting non-glob imports of rustc_type_ir::inherent #127854

Add internal lint for detecting non-glob imports of rustc_type_ir::inherent #127854

Conversation

fmease commented Jul 17, 2024

fmease Jul 17, 2024 • edited Loading

Choose a reason for hiding this comment

fmease Jul 17, 2024 • edited Loading

Choose a reason for hiding this comment

compiler-errors Jul 17, 2024

Choose a reason for hiding this comment

fmease Jul 17, 2024

Choose a reason for hiding this comment

compiler-errors Jul 17, 2024

Choose a reason for hiding this comment

compiler-errors left a comment

Choose a reason for hiding this comment

compiler-errors commented Jul 17, 2024

bors commented Jul 17, 2024

tgross35 commented Jul 18, 2024

fmease commented Jul 18, 2024 • edited Loading

bors commented Jul 18, 2024

bors commented Jul 18, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

fmease commented Jul 18, 2024

bors commented Jul 18, 2024

Add internal lint for detecting non-glob imports of `rustc_type_ir::inherent` #127854

Add internal lint for detecting non-glob imports of `rustc_type_ir::inherent` #127854

fmease Jul 17, 2024 •

edited

Loading

fmease Jul 17, 2024 •

edited

Loading

fmease commented Jul 18, 2024 •

edited

Loading