Rollup of 8 pull requests #128155

matthiaskrgr · 2024-07-24T20:22:19Z

Successful merges:

Do not try to reveal hidden types when trying to prove auto-traits in the defining scope #122192 (Do not try to reveal hidden types when trying to prove auto-traits in the defining scope)
Implement unsigned_signed_diff #126042 (Implement unsigned_signed_diff)
Improved clarity of documentation for std::fs::create_dir_all #126548 (Improved clarity of documentation for std::fs::create_dir_all)
Fix malformed suggestion for repeated maybe unsized bounds #127717 (Fix malformed suggestion for repeated maybe unsized bounds)
Fix some #[cfg_attr(not(doc), repr(..))] #128046 (Fix some #[cfg_attr(not(doc), repr(..))])
Mark missing_fragment_specifier as FutureReleaseErrorReportInDeps #128122 (Mark missing_fragment_specifier as FutureReleaseErrorReportInDeps)
std: use duplicate thread local state in tests #128135 (std: use duplicate thread local state in tests)
Remove Unnecessary .as_str() Conversions #128140 (Remove Unnecessary .as_str() Conversions)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Now that rust-lang#90435 seems to have been resolved.

With rust-lang/miri#3739 merged, the deduplication hack is no longer necessary.

…defining scope

…efining scope

We are moving toward forbidding `missing_fragment_specifier` either in edition 2024 or unconditionally. Make a first step toward this by ensuring crates that rely on the old behavior are reported when used as dependencies. Tracking issue: <rust-lang#128143>

…hecks, r=lcnr Do not try to reveal hidden types when trying to prove auto-traits in the defining scope fixes rust-lang#99793 this avoids the cycle error by just causing a selection error, which is not fatal. We pessimistically assume that freeze does not hold, which is always a safe assumption.

Implement `unsigned_signed_diff`  Implements rust-lang#126041

Improved clarity of documentation for std::fs::create_dir_all Closes rust-lang#88264

…mpiler-errors Fix malformed suggestion for repeated maybe unsized bounds Fixes rust-lang#127441 Now when we encounter something like `foo(a : impl ?Sized + ?Sized)`, instead of suggesting removal of both bounds and leaving `foo(a: impl )` behind, we suggest changing the first bound to `Sized` and removing the second bound, resulting in `foo(a: impl Sized)`. Although the issue was reported for impl trait types, it also occurred with regular param bounds. So if we encounter `foo<T: ?Sized + ?Sized>(a: T)` we now detect that all the bounds are `?Sized` and therefore emit the suggestion to remove the entire predicate `: ?Sized + ?Sized` resulting in `foo<T>(a: T)`. Lastly, if we encounter a situation where some of the bounds are something other than `?Sized`, then we emit separate removal suggestions for each `?Sized` bound. E.g. if we see `foo(a: impl ?Sized + Bar + ?Sized)` or `foo<T: ?Sized + Bar + ?Sized>(a: T)` we emit suggestions such that the user will be left with `foo(a : impl Bar)` or `foo<T: Bar>(a: T)` respectively.

Fix some `#[cfg_attr(not(doc), repr(..))]` Now that rust-lang#90435 seems to have been resolved.

…r-unconditional, r=petrochenkov Mark `missing_fragment_specifier` as `FutureReleaseErrorReportInDeps` We are moving toward forbidding `missing_fragment_specifier` either in edition 2024 or unconditionally. Make a first step toward this by ensuring crates that rely on the old behavior are reported when used as dependencies. Tracking issue: <rust-lang#128143>

std: use duplicate thread local state in tests With rust-lang/miri#3739 merged, the deduplication hack is no longer necessary.

…r-conversions, r=compiler-errors Remove Unnecessary `.as_str()` Conversions Because comparing interned values is much more efficient than converting a `rustc_span::symbol::Ident` to `&str` and then doing the comparison. docs: https://doc.rust-lang.org/stable/nightly-rustc/rustc_span/symbol/struct.Ident.html#method.as_str

matthiaskrgr · 2024-07-24T20:22:33Z

@bors r+ rollup=never p=8

bors · 2024-07-24T20:22:36Z

📌 Commit 104a421 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-07-24T22:37:08Z

⌛ Testing commit 104a421 with merge e7d66ea...

bors · 2024-07-25T00:59:50Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e7d66ea to master...

rust-timer · 2024-07-25T01:02:05Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#122192	Do not try to reveal hidden types when trying to prove auto…	`63cb41f67915684f487c6214ed15355f64ce0a29` (link)
#126042	Implement `unsigned_signed_diff`	`c2f76cf559de17dce59120827313827c4319da62` (link)
#126548	Improved clarity of documentation for std::fs::create_dir_a…	`18fca75f7e65a4991ffb6626481cf4de8324057a` (link)
#127717	Fix malformed suggestion for repeated maybe unsized bounds	`60d6aa57c1278b4deae5658b43ea85db7ab8f57f` (link)
#128046	Fix some `#[cfg_attr(not(doc), repr(..))]`	`f360f0547fb8863224672c6e83527bdf68cb93e9` (link)
#128122	Mark `missing_fragment_specifier` as `FutureReleaseErrorRep…	`5498fd164cd611826ce6d19c84c2fe2fed4cfc0f` (link)
#128135	std: use duplicate thread local state in tests	`850fa5115338dce9dd494d307f4ebf8f08029c30` (link)
#128140	Remove Unnecessary `.as_str()` Conversions	`fa276c45bc2b06cb23f84ab9a2aee1dfe291a5a5` (link)

previous master: c1a6199e9d

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-07-25T02:17:13Z

Finished benchmarking commit (e7d66ea): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 0.8%]	6
Regressions ❌ (secondary)	0.9%	[0.7%, 1.0%]	7
Improvements ✅ (primary)	-0.5%	[-0.6%, -0.4%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.6%, 0.8%]	10

Max RSS (memory usage)

Results (primary -3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.0%	[-3.0%, -3.0%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.173s -> 771.74s (-0.06%)
Artifact size: 328.95 MiB -> 328.91 MiB (-0.01%)

pnkfelix · 2024-07-31T18:53:38Z

Visiting for weekly rustc-perf triage

regressions are to hyper and exa. Mostly in hyper check-full, check-incr-full, and debug-incr-full.
bulk of time might be from spike in time spent in mir_const_qualif query ? (Is that possibly related to PR Do not try to reveal hidden types when trying to prove auto-traits in the defining scope #122192 ?)
not marking as triaged, (though it is, to be clear, a relatively minor regression).

pnkfelix · 2024-07-31T18:53:59Z

@rust-timer build 63cb41f

rust-timer · 2024-08-01T09:00:49Z

Finished benchmarking commit (63cb41f): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 0.8%]	6
Regressions ❌ (secondary)	0.8%	[0.5%, 1.0%]	8
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-0.4%, 0.8%]	8

Max RSS (memory usage)

Results (primary -2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.9%	[-2.9%, -2.9%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.173s -> 771.253s (-0.12%)
Artifact size: 328.95 MiB -> 328.92 MiB (-0.01%)

davidzeng0 and others added 19 commits June 23, 2024 13:43

Implement unsigned_signed_diff

46b8495

Fix malformed suggestion for repeated maybe unsized bounds

e13eb37

Fix some #[cfg_attr(not(doc), repr(..))]

b74f426

Now that rust-lang#90435 seems to have been resolved.

std: use duplicate thread local state in tests

a4dd0d6

With rust-lang/miri#3739 merged, the deduplication hack is no longer necessary.

Improved clarity of documentation for std::fs::create_dir_all

dfb3fb3

Remove Unnecessary .as_str() Conversions

4d5ac84

Add regression test

fdff100

Do not try to reveal hidden types when trying to prove Freeze in the …

acba644

…defining scope

Add regression tests

548c447

Do not assemble candidates for auto traits of opaque types in their d…

8ea461d

…efining scope

Rollup merge of rust-lang#126548 - rik86189:issue-88264-fix, r=tgross35

ed5dfed

Improved clarity of documentation for std::fs::create_dir_all Closes rust-lang#88264

Rollup merge of rust-lang#128046 - GrigorenkoPV:90435, r=tgross35

07947f3

Fix some `#[cfg_attr(not(doc), repr(..))]` Now that rust-lang#90435 seems to have been resolved.

Rollup merge of rust-lang#128135 - joboet:reduplicate_tls, r=tgross35

d146ecd

std: use duplicate thread local state in tests With rust-lang/miri#3739 merged, the deduplication hack is no longer necessary.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 25, 2024

bors merged commit e7d66ea into rust-lang:master Jul 25, 2024
7 checks passed

rustbot added this to the 1.82.0 milestone Jul 25, 2024

rustbot added the perf-regression Performance regression. label Jul 25, 2024

This comment has been minimized.

Sign in to view

matthiaskrgr deleted the rollup-lxtal9f branch September 1, 2024 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #128155

Rollup of 8 pull requests #128155

matthiaskrgr commented Jul 24, 2024

matthiaskrgr commented Jul 24, 2024

bors commented Jul 24, 2024

bors commented Jul 24, 2024

bors commented Jul 25, 2024

rust-timer commented Jul 25, 2024

rust-timer commented Jul 25, 2024

pnkfelix commented Jul 31, 2024

pnkfelix commented Jul 31, 2024

This comment has been minimized.

rust-timer commented Aug 1, 2024

Rollup of 8 pull requests #128155

Rollup of 8 pull requests #128155

Conversation

matthiaskrgr commented Jul 24, 2024

matthiaskrgr commented Jul 24, 2024

bors commented Jul 24, 2024

bors commented Jul 24, 2024

bors commented Jul 25, 2024

rust-timer commented Jul 25, 2024

rust-timer commented Jul 25, 2024

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

pnkfelix commented Jul 31, 2024

pnkfelix commented Jul 31, 2024

This comment has been minimized.

rust-timer commented Aug 1, 2024

Overall result: ❌✅ regressions and improvements - ACTION NEEDED