Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linker: Remove the "--whole-archive in test mode" backcompat hack #128400

Merged
merged 1 commit into from
Aug 10, 2024
Merged

linker: Remove the "--whole-archive in test mode" backcompat hack #128400

merged 1 commit into from
Aug 10, 2024

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Jul 30, 2024 •
edited
Loading

Fixes #116910.

@rustbot
Copy link
Collaborator

rustbot commented Jul 30, 2024

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 30, 2024
@petrochenkov petrochenkov mentioned this pull request Jul 30, 2024
Closed
@petrochenkov
Copy link
Contributor Author

@bors try

@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2024
@bors
Auto merge of rust-lang#128400 - petrochenkov:nowhole3, r=<try>
33f1d8b 
linker: Remove the "`--whole-archive` in test mode" backcompat hack

Fixes rust-lang#116910.
@bors
Copy link
Contributor

bors commented Jul 30, 2024

⌛ Trying commit 3d2d7cf with merge 33f1d8b...

@Nadrieril
Copy link
Member

r? compiler

@rustbot rustbot assigned fmease and unassigned Nadrieril Jul 30, 2024
@bors
Copy link
Contributor

bors commented Jul 30, 2024

☀️ Try build successful - checks-actions
Build commit: 33f1d8b (33f1d8bb92813a1bfc23c093c9f443ab09290307)

@petrochenkov
Copy link
Contributor Author

@craterbot run mode=build-and-test +cargoflags=--no-run

@craterbot
Copy link
Collaborator

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@petrochenkov
Copy link
Contributor Author

@craterbot run mode=build-and-test

@craterbot
Copy link
Collaborator

👌 Experiment pr-128400 created and queued.
🤖 Automatically detected try build 33f1d8b
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-128400 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-128400 is completed!
📊 279 regressed and 201 fixed (487456 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 7, 2024
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2024
@petrochenkov
Copy link
Contributor Author

Too many spurious regressions, I'll just do a second iteration.
@craterbot run mode=build-and-test p=1 crates=https://crater-reports.s3.amazonaws.com/pr-128400/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment pr-128400-1 created and queued.
🤖 Automatically detected try build 33f1d8b
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 7, 2024
@craterbot
Copy link
Collaborator

🚧 Experiment pr-128400-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-128400-1 is completed!
📊 20 regressed and 14 fixed (279 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 9, 2024
@petrochenkov
Copy link
Contributor Author

Much better.
Most of the remaining failures also look spurious, but I'll test them locally today or tomorrow.

We need to land this in any case, because the change only affects test mode, doesn't affect dependent crates, and the removed hack could potentially hide issues in non-test mode.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2024
@petrochenkov
Copy link
Contributor Author

I couldn't reproduce any of the regressions locally, they either pass or fail on both this PR and nightly.
r? @bjorn3
@rustbot ready

@rustbot rustbot assigned bjorn3 and unassigned fmease Aug 9, 2024
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 9, 2024
@bjorn3
Copy link
Member

bjorn3 commented Aug 10, 2024

Keeping this out of a rollup may be beneficial for bisectability.

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Aug 10, 2024

📌 Commit 3d2d7cf has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 10, 2024
@bors
Auto merge of rust-lang#128400 - petrochenkov:nowhole3, r=bjorn3
a733c5b 
linker: Remove the "`--whole-archive` in test mode" backcompat hack

Fixes rust-lang#116910.
@bors
Copy link
Contributor

bors commented Aug 10, 2024

⌛ Testing commit 3d2d7cf with merge a733c5b...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bjorn3
Copy link
Member

bjorn3 commented Aug 10, 2024

@bors retry failed to remove executable with "Access is denied"

@bors
Copy link
Contributor

bors commented Aug 10, 2024

⌛ Testing commit 3d2d7cf with merge 04dff01...

@bors
Copy link
Contributor

bors commented Aug 10, 2024

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 04dff01 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 10, 2024
@bors bors merged commit 04dff01 into rust-lang:master Aug 10, 2024
7 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 10, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (04dff01): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.2%, secondary 2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.2% [3.2%, 3.2%] 1
Regressions ❌
(secondary)		 2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.2% [3.2%, 3.2%] 1

Cycles

Results (secondary -4.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.4% [-4.4%, -4.3%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 758.54s -> 756.781s (-0.23%)
Artifact size: 339.24 MiB -> 339.30 MiB (0.02%)

@saethlin saethlin mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bjorn3 bjorn3

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.

rustc --test -l static=somelib.a links with --whole-archive
9 participants
@petrochenkov @rustbot @bors @Nadrieril @craterbot @bjorn3 @rust-log-analyzer @rust-timer @fmease