Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #128418

Closed
wants to merge 18 commits into from
Closed

Commits on Jul 16, 2024

  1. When an archive fails to build, print the path

    Currently the output on failure is as follows:
    
           Compiling block-buffer v0.10.4
           Compiling crypto-common v0.1.6
           Compiling digest v0.10.7
           Compiling sha2 v0.10.8
           Compiling xz2 v0.1.7
        error: failed to build archive: No such file or directory
    
        error: could not compile `bootstrap` (lib) due to 1 previous error
    
    Print which file is being constructed to give some hint about what is
    going on.
    tgross35 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e0af3c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Configuration menu
    Copy the full SHA
    eb3c932 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Configuration menu
    Copy the full SHA
    918cdcc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7e90fe View commit details
    Browse the repository at this point in the history
  3. migrate fmt-write-bloat to rmake

    binarycat committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4feb949 View commit details
    Browse the repository at this point in the history
  4. tidy

    this commit cannot easily be squashed, since there is already a
    PR based on the previous commit.
    binarycat committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    ebd6718 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e7f89a7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fe6478c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e657773 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    449deaf View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Rollup merge of rust-lang#125048 - dingxiangfei2009:stable-deref, r=A…

    …manieu
    
    PinCoerceUnsized trait into core
    
    cc `@Darksonn` `@wedsonaf` `@ojeda`
    
    This is a PR to introduce a `PinCoerceUnsized` trait in order to make trait impls generated by the proc-macro `#[derive(SmartPointer)]`, proposed by [RFC](https://github.com/rust-lang/rfcs/blob/e17e19ac7ad1c8ccad55d4babfaee1aa107d1da5/text/3621-derive-smart-pointer.md#pincoerceunsized-1), sound. There you may find explanation, justification and discussion about the alternatives.
    
    Note that we do not seek stabilization of this `PinCoerceUnsized` trait in the near future. The stabilisation of this trait does not block the eventual stabilization process of the `#[derive(SmartPointer)]` macro. Ideally, use of `DerefPure` is more preferrable except this will actually constitute a breaking change. `PinCoerceUnsized` emerges as a solution to the said soundness hole while avoiding the breaking change. More details on the `DerefPure` option have been described in this [section](https://github.com/rust-lang/rfcs/blob/e17e19ac7ad1c8ccad55d4babfaee1aa107d1da5/text/3621-derive-smart-pointer.md#derefpure) of the RFC linked above.
    
    Earlier discussion can be found in this [Zulip stream](https://rust-lang.zulipchat.com/#narrow/stream/136281-t-opsem/topic/Pin.20and.20soundness.20of.20unsizing.20coercions) and [rust-for-linux thread](https://rust-lang.zulipchat.com/#narrow/stream/425075-rust-for-linux/topic/.23.5Bderive.28SmartPointer.29.5D.20and.20pin.20unsoundness.20rfc.233621).
    tgross35 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    7afffa8 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#127681 - dingxiangfei2009:smart-ptr-bounds,…

    … r=compiler-errors
    
    derive(SmartPointer): rewrite bounds in where and generic bounds
    
    Fix rust-lang#127647
    
    Due to the `Unsize` bounds, we need to commute the bounds on the pointee type to the new self type.
    
    cc `@Darksonn`
    tgross35 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    a952d28 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#127830 - tgross35:archive-failure-message, …

    …r=BoxyUwU
    
    When an archive fails to build, print the path
    
    Currently the output on failure is as follows:
    
           Compiling block-buffer v0.10.4
           Compiling crypto-common v0.1.6
           Compiling digest v0.10.7
           Compiling sha2 v0.10.8
           Compiling xz2 v0.1.7
        error: failed to build archive: No such file or directory
    
        error: could not compile `bootstrap` (lib) due to 1 previous error
    
    Change this to print which file is being constructed, to give some hint about what is going on.
    
        error: failed to build archive at `path/to/output`: No such file or directory
    tgross35 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c7e7028 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#128147 - lolbinarycat:fmt-write-bloat-rmake…

    …, r=jieyouxu
    
    migrate fmt-write-bloat to rmake
    
    try-job: aarch64-apple
    try-job: x86_64-gnu-llvm-18
    try-job: dist-x86_64-linux
    tgross35 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    7e8b44e View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#128356 - Oneirical:real-estate-reaLTOr, r=j…

    …ieyouxu
    
    Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake
    
    Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
    
    This has the same problem outlined by rust-lang#126180, where the tests do not actually run as no test-running CI enviroment has `RUSTBUILD_FORCE_CLANG_BASED_TESTS` set.
    
    However, I still find it interesting to turn the Makefiles into the rmake format until the Clang issue is fixed.
    
    This should technically be tested on MSVC... if MSVC actually ran Clang tests.
    tgross35 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    aadaa32 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#128387 - liigo:patch-14, r=tgross35

    More detailed note to deprecate ONCE_INIT
    tgross35 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b91b069 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#128388 - beetrees:f16-f128-slightly-improve…

    …-windows-abi, r=tgross35
    
    Match LLVM ABI in `extern "C"` functions for `f128` on Windows
    
    As MSVC doesn't support `_Float128`, x86-64 Windows doesn't have a defined ABI for `f128`. Currently, Rust will pass and return `f128` indirectly for `extern "C"` functions. This is inconsistent with LLVM, which passes and returns `f128` in XMM registers, meaning that e.g. the ABI of `extern "C"` compiler builtins won't match. This PR fixes this discrepancy by making the x86-64 Windows `extern "C"` ABI pass `f128` directly through to LLVM, so that Rust will follow whatever LLVM does. This still leaves the difference between LLVM and GCC (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115054) but this PR is still an improvement as at least Rust is now consistent with it's primary codegen backend and compiler builtins from `compiler-builtins` will now work.
    
    I've also fixed the x86-64 Windows `has_reliable_f16` match arm in `std` `build.rs` to refer to the correct target, and added an equivalent match arm to `has_reliable_f128` as the LLVM-GCC ABI difference affects both `f16` and `f128`.
    
    Tracking issue: rust-lang#116909
    
    try-job: x86_64-msvc
    try-job: x86_64-mingw
    tgross35 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    84cc3ab View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#128412 - compiler-errors:crate-level-only, …

    …r=cjgillot
    
    Remove `crate_level_only` from `ELIDED_LIFETIMES_IN_PATHS`
    
    As far as I can tell, we provide the right node id to the `ELIDED_LIFETIMES_IN_PATHS` lint:
    
    https://github.com/rust-lang/rust/blob/f8060d282d42770fadd73905e3eefb85660d3278/compiler/rustc_resolve/src/late.rs#L2015-L2027
    
    So I've gone ahead and removed the restriction from this lint.
    tgross35 committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c7481d7 View commit details
    Browse the repository at this point in the history