Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in rmake tests on x86_64-unknown-linux-gnu #128937

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Fix warnings in rmake tests on x86_64-unknown-linux-gnu #128937

merged 3 commits into from
Aug 12, 2024

Conversation

lqd
Copy link
Member

@lqd lqd commented Aug 10, 2024

r? @jieyouxu

This PR fixes some warnings I saw in rmake tests. I didn't deny more warnings in this PR until @jieyouxu gives their opinion, but maybe we should actually deny all warnings in rmake.rs files?

I've also only looked at non-ignored tests on x86_64-unknown-linux-gnu, and denying warnings would require a try build for all targets 😓.

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 10, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

jieyouxu
jieyouxu approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

but maybe we should actually deny all warnings in rmake.rs files?

I think that might be the right thing to do, but there are some DX caveats. We'll want to tie if -D warnings is applied to compiling rmake.rs to config.toml's deny-warnings option, otherwise I can see trying to iterate on local tests to become very annoying.

Another thing is that if rmake.rs is ignored for whatever reason on the local dev environment (e.g. test is only-msvc but we're on apple), then the test won't be compiled and thus won't fail locally if there are warnings, but will only fail in CI (try-job if someone actually runs the apple try jobs, otherwise it will only fail in full CI). So I'm a bit hesistant to just -D warnings by default.

tests/run-make/rustdoc-io-error/rmake.rs Outdated Show resolved Hide resolved
@jieyouxu
Copy link
Member

jieyouxu commented Aug 11, 2024 •
edited
Loading

The changes in this PR is a great cleanup! Feel free to r=me after using rfs::create_dir in the one diff.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2024
@lqd
Copy link
Member Author

lqd commented Aug 11, 2024

So I'm a bit hesistant to just -D warnings by default.

Same for me.

Maybe CI should deny warnings altogether though, as it does for the rest of the code.

@bors r=jieyouxu

@bors
Copy link
Contributor

bors commented Aug 11, 2024

📌 Commit dcd6170 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 11, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Aug 11, 2024
@jieyouxu
Rollup merge of rust-lang#128937 - lqd:clean-rmake-tests, r=jieyouxu
ec6618b 
Fix warnings in rmake tests on `x86_64-unknown-linux-gnu`

r? `@jieyouxu`

This PR fixes some warnings I saw in rmake tests. I didn't deny more warnings in this PR until `@jieyouxu` gives their opinion, but maybe we should actually deny all warnings in `rmake.rs` files?

I've also only looked at non-ignored tests on `x86_64-unknown-linux-gnu`, and denying warnings would require a try build for all targets 😓.
@jieyouxu jieyouxu mentioned this pull request Aug 11, 2024
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Aug 11, 2024
@jieyouxu
Rollup merge of rust-lang#128937 - lqd:clean-rmake-tests, r=jieyouxu
d1b29fc 
Fix warnings in rmake tests on `x86_64-unknown-linux-gnu`

r? ``@jieyouxu``

This PR fixes some warnings I saw in rmake tests. I didn't deny more warnings in this PR until ``@jieyouxu`` gives their opinion, but maybe we should actually deny all warnings in `rmake.rs` files?

I've also only looked at non-ignored tests on `x86_64-unknown-linux-gnu`, and denying warnings would require a try build for all targets 😓.
@jieyouxu jieyouxu mentioned this pull request Aug 11, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 11, 2024
@bors
Auto merge of rust-lang#128968 - jieyouxu:rollup-l23j21x, r=jieyouxu
8707132 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#128643 (Refactor `powerpc64` call ABI handling)
 - rust-lang#128873 (Add windows-targets crate to std's sysroot)
 - rust-lang#128916 (Tidy up `dump-ice-to-disk` and make assertion failures dump ICE messages)
 - rust-lang#128929 (Fix codegen-units tests that were disabled 8 years ago)
 - rust-lang#128937 (Fix warnings in rmake tests on `x86_64-unknown-linux-gnu`)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 12, 2024
@matthiaskrgr
Rollup merge of rust-lang#128937 - lqd:clean-rmake-tests, r=jieyouxu
03c2854 
Fix warnings in rmake tests on `x86_64-unknown-linux-gnu`

r? ```@jieyouxu```

This PR fixes some warnings I saw in rmake tests. I didn't deny more warnings in this PR until ```@jieyouxu``` gives their opinion, but maybe we should actually deny all warnings in `rmake.rs` files?

I've also only looked at non-ignored tests on `x86_64-unknown-linux-gnu`, and denying warnings would require a try build for all targets 😓.
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 12, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 12, 2024
@matthiaskrgr
Rollup merge of rust-lang#128937 - lqd:clean-rmake-tests, r=jieyouxu
4211fa8 
Fix warnings in rmake tests on `x86_64-unknown-linux-gnu`

r? ````@jieyouxu````

This PR fixes some warnings I saw in rmake tests. I didn't deny more warnings in this PR until ````@jieyouxu```` gives their opinion, but maybe we should actually deny all warnings in `rmake.rs` files?

I've also only looked at non-ignored tests on `x86_64-unknown-linux-gnu`, and denying warnings would require a try build for all targets 😓.
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 12, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 12, 2024
@bors
Auto merge of rust-lang#128997 - matthiaskrgr:rollup-gvrzctq, r=matth…
79a6f57 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#128886 (Get rid of some `#[allow(rustc::untranslatable_diagnostic)]`)
 - rust-lang#128936 (Support reading thin archives in ArArchiveBuilder)
 - rust-lang#128937 (Fix warnings in rmake tests on `x86_64-unknown-linux-gnu`)
 - rust-lang#128977 (Only try to modify file times of a writable file)
 - rust-lang#128978 (Use `assert_matches` around the compiler more)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 12, 2024
@matthiaskrgr
Rollup merge of rust-lang#128937 - lqd:clean-rmake-tests, r=jieyouxu
fb00ffa 
Fix warnings in rmake tests on `x86_64-unknown-linux-gnu`

r? `````@jieyouxu`````

This PR fixes some warnings I saw in rmake tests. I didn't deny more warnings in this PR until `````@jieyouxu````` gives their opinion, but maybe we should actually deny all warnings in `rmake.rs` files?

I've also only looked at non-ignored tests on `x86_64-unknown-linux-gnu`, and denying warnings would require a try build for all targets 😓.
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 12, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 12, 2024
@bors
Auto merge of rust-lang#128999 - matthiaskrgr:rollup-pb6141p, r=matth…
94b7ab4 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#128712 (Normalize struct tail properly for `dyn` ptr-to-ptr casting in new solver)
 - rust-lang#128878 (Slightly refactor `Flags` in bootstrap)
 - rust-lang#128886 (Get rid of some `#[allow(rustc::untranslatable_diagnostic)]`)
 - rust-lang#128912 (Store `do_not_recommend`-ness in impl header)
 - rust-lang#128936 (Support reading thin archives in ArArchiveBuilder)
 - rust-lang#128937 (Fix warnings in rmake tests on `x86_64-unknown-linux-gnu`)
 - rust-lang#128978 (Use `assert_matches` around the compiler more)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 12, 2024
@bors
Auto merge of rust-lang#128999 - matthiaskrgr:rollup-pb6141p, r=matth…
6d55def 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#128712 (Normalize struct tail properly for `dyn` ptr-to-ptr casting in new solver)
 - rust-lang#128878 (Slightly refactor `Flags` in bootstrap)
 - rust-lang#128886 (Get rid of some `#[allow(rustc::untranslatable_diagnostic)]`)
 - rust-lang#128912 (Store `do_not_recommend`-ness in impl header)
 - rust-lang#128936 (Support reading thin archives in ArArchiveBuilder)
 - rust-lang#128937 (Fix warnings in rmake tests on `x86_64-unknown-linux-gnu`)
 - rust-lang#128978 (Use `assert_matches` around the compiler more)

r? `@ghost`
`@rustbot` modify labels: rollup
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 12, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 12, 2024
@bors
Auto merge of rust-lang#129008 - GuillaumeGomez:rollup-6citttb, r=Gui…
91376f4 
…llaumeGomez

Rollup of 10 pull requests

Successful merges:

 - rust-lang#128149 (nontemporal_store: make sure that the intrinsic is truly just a hint)
 - rust-lang#128394 (Unify run button display with "copy code" button and with mdbook buttons)
 - rust-lang#128537 (const vector passed through to codegen)
 - rust-lang#128632 (std: do not overwrite style in `get_backtrace_style`)
 - rust-lang#128878 (Slightly refactor `Flags` in bootstrap)
 - rust-lang#128886 (Get rid of some `#[allow(rustc::untranslatable_diagnostic)]`)
 - rust-lang#128929 (Fix codegen-units tests that were disabled 8 years ago)
 - rust-lang#128937 (Fix warnings in rmake tests on `x86_64-unknown-linux-gnu`)
 - rust-lang#128978 (Use `assert_matches` around the compiler more)
 - rust-lang#128994 (Fix bug in `Parser::look_ahead`.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bb35b88 into rust-lang:master Aug 12, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 12, 2024
@rust-timer
Unrolled build for rust-lang#128937
38ec04e 
Rollup merge of rust-lang#128937 - lqd:clean-rmake-tests, r=jieyouxu

Fix warnings in rmake tests on `x86_64-unknown-linux-gnu`

r? `@jieyouxu`

This PR fixes some warnings I saw in rmake tests. I didn't deny more warnings in this PR until `@jieyouxu` gives their opinion, but maybe we should actually deny all warnings in `rmake.rs` files?

I've also only looked at non-ignored tests on `x86_64-unknown-linux-gnu`, and denying warnings would require a try build for all targets 😓.
@lqd lqd deleted the clean-rmake-tests branch August 12, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
Oxidizing run-make tests
Status: Done
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lqd @rustbot @jieyouxu @bors