Make ArgAbi::make_indirect_force more specific
#129339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Thanks, LGTM! @bors r+ rollup |
bors
added
S-waiting-on-bors
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Aug 21, 2024
…, r=RalfJung Make `ArgAbi::make_indirect_force` more specific As the method is only needed for making ignored ZSTs indirect on some ABIs, rename and add a doc-comment and `self.mode` check to make it harder to accidentally misuse. Addresses review feedback from rust-lang#125854 (comment). r? `@RalfJung`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 21, 2024
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#128627 (Special case DUMMY_SP to emit line 0/column 0 locations on DWARF platforms.) - rust-lang#128843 (Minor Refactor: Remove a Redundant Conditional Check) - rust-lang#129179 (CFI: Erase regions when projecting ADT to its transparent non-1zst field) - rust-lang#129281 (Tweak unreachable lint wording) - rust-lang#129312 (Fix stability attribute of `impl !Error for &str`) - rust-lang#129332 (Avoid extra `cast()`s after `CStr::as_ptr()`) - rust-lang#129339 (Make `ArgAbi::make_indirect_force` more specific) - rust-lang#129344 (Use `bool` in favor of `Option<()>` for diagnostics) - rust-lang#129345 (Use shorthand field initialization syntax more aggressively in the compiler) - rust-lang#129355 (fix comment on PlaceMention semantics) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 21, 2024
Rollup merge of rust-lang#129339 - beetrees:make-indirect-from-ignore, r=RalfJung Make `ArgAbi::make_indirect_force` more specific As the method is only needed for making ignored ZSTs indirect on some ABIs, rename and add a doc-comment and `self.mode` check to make it harder to accidentally misuse. Addresses review feedback from rust-lang#125854 (comment). r? ``@RalfJung``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the method is only needed for making ignored ZSTs indirect on some ABIs, rename and add a doc-comment and
self.modecheck to make it harder to accidentally misuse. Addresses review feedback from #125854 (comment).r? @RalfJung