Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ParenthesizedGenericArgs to GenericArgsMode #129625

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

compiler-errors
Copy link
Member

A bit easier to digest name. Broken out of a PR implementing return type notation.

@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2024

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 26, 2024
@fmease
Copy link
Member

fmease commented Aug 26, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 26, 2024

📌 Commit 2db1d2e has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 26, 2024
… r=fmease

Rename `ParenthesizedGenericArgs` to `GenericArgsMode`

A bit easier to digest name. Broken out of a PR implementing return type notation.
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 26, 2024
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#126013 (Add `#[warn(unreachable_pub)]` to a bunch of compiler crates)
 - rust-lang#128157 (deduplicate and clarify rules for converting pointers to references)
 - rust-lang#129032 (Document & implement the transmutation modeled by `BikeshedIntrinsicFrom`)
 - rust-lang#129250 (Do not ICE on non-ADT rcvr type when looking for crate version collision)
 - rust-lang#129340 (Remove Duplicate E0381 Label)
 - rust-lang#129560 ([rustdoc] Generate source link on impl associated types)
 - rust-lang#129622 (Remove a couple of unused feature enables)
 - rust-lang#129625 (Rename `ParenthesizedGenericArgs` to `GenericArgsMode`)
 - rust-lang#129626 (Remove `ParamMode::ExplicitNamed`)

Failed merges:

 - rust-lang#128166 (Improved `checked_isqrt` and `isqrt` methods)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3d8d9da into rust-lang:master Aug 27, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 27, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2024
Rollup merge of rust-lang#129625 - compiler-errors:generic-args-mode, r=fmease

Rename `ParenthesizedGenericArgs` to `GenericArgsMode`

A bit easier to digest name. Broken out of a PR implementing return type notation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants