Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check params for unsafety in THIR #130531

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Check params for unsafety in THIR #130531

merged 1 commit into from
Sep 19, 2024
+52 −0

Conversation

compiler-errors
Copy link
Member

Self-explanatory. I'm not surprised this was overlooked, given the way that THIR visitors work. Perhaps we should provide a better entrypoint.

Fixes #130528

@compiler-errors compiler-errors added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 18, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 18, 2024

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 18, 2024
@compiler-errors
Copy link
Member Author

r? compiler

@rustbot rustbot assigned BoxyUwU and unassigned TaKO8Ki Sep 18, 2024
@Urgau
Copy link
Member

Urgau commented Sep 18, 2024

r=me when CI is green

@compiler-errors
Copy link
Member Author

@bors r=Urgau

@bors
Copy link
Contributor

bors commented Sep 18, 2024

📌 Commit 12f2bcd has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2024
@BoxyUwU BoxyUwU assigned Urgau and unassigned BoxyUwU Sep 18, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 19, 2024
@workingjubilee
Rollup merge of rust-lang#130531 - compiler-errors:thir-unsafeck-para…
05f8f46 
…m, r=Urgau

Check params for unsafety in THIR

Self-explanatory. I'm not surprised this was overlooked, given the way that THIR visitors work. Perhaps we should provide a better entrypoint.

Fixes rust-lang#130528
@workingjubilee workingjubilee mentioned this pull request Sep 19, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2024
@bors
Auto merge of rust-lang#130541 - workingjubilee:rollup-26jmumi, r=wor…
a6d2ada 
…kingjubilee

Rollup of 3 pull requests

Successful merges:

 - rust-lang#129755 (test: cross-edition metavar fragment specifiers)
 - rust-lang#130511 (Support `char::encode_utf8` in const scenarios.)
 - rust-lang#130531 (Check params for unsafety in THIR)

r? `@ghost`
`@rustbot` modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 19, 2024
@workingjubilee
Rollup merge of rust-lang#130531 - compiler-errors:thir-unsafeck-para…
f48178b 
…m, r=Urgau

Check params for unsafety in THIR

Self-explanatory. I'm not surprised this was overlooked, given the way that THIR visitors work. Perhaps we should provide a better entrypoint.

Fixes rust-lang#130528
This was referenced Sep 19, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2024
@bors
Auto merge of rust-lang#130547 - workingjubilee:rollup-tw30khz, r=wor…
b7b9453 
…kingjubilee

Rollup of 3 pull requests

Successful merges:

 - rust-lang#130531 (Check params for unsafety in THIR)
 - rust-lang#130533 (Never patterns constitute a read for unsafety)
 - rust-lang#130542 (Stabilize const `MaybeUninit::as_mut_ptr`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 944df8e into rust-lang:master Sep 19, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 19, 2024
@rust-timer
Unrolled build for rust-lang#130531
0d69e2d 
Rollup merge of rust-lang#130531 - compiler-errors:thir-unsafeck-param, r=Urgau

Check params for unsafety in THIR

Self-explanatory. I'm not surprised this was overlooked, given the way that THIR visitors work. Perhaps we should provide a better entrypoint.

Fixes rust-lang#130528
@compiler-errors

This comment was marked as off-topic.

Sign in to view
@craterbot

This comment was marked as outdated.

Sign in to view
@wesleywiser wesleywiser added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 19, 2024
@compiler-errors
Copy link
Member Author

@craterbot run mode=check-only start=master#f8192ba0d00bbbc58a10c45823ba010e98ea4474 end=try#0d69e2d38d443a5f5bcd601fecce9431b3835c30

@rustbot rustbot mentioned this pull request Sep 19, 2024
Open
3 tasks
@craterbot
Copy link
Collaborator

👌 Experiment pr-130531 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2024
@compiler-errors compiler-errors deleted the thir-unsafeck-param branch September 19, 2024 14:19
@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 19, 2024
@cuviper cuviper mentioned this pull request Sep 19, 2024
Open
@cuviper cuviper modified the milestones: 1.83.0, 1.82.0 Sep 19, 2024
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 19, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2024
@bors
Auto merge of rust-lang#130569 - cuviper:beta-next, r=cuviper
86853ee 
[beta] backports

- Don't warn empty branches unreachable for now rust-lang#129103
- Win: Add dbghelp to the list of import libraries rust-lang#130047
- `RepeatN`: use MaybeUninit rust-lang#130145
- Update LLVM to 19 327ca6c rust-lang#130212
- Revert rust-lang#129749 to fix segfault in LLVM rust-lang#130477
- Check params for unsafety in THIR rust-lang#130531

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2024
@bors
Auto merge of rust-lang#130569 - cuviper:beta-next, r=<try>
bfba43d 
[beta] backports

- Don't warn empty branches unreachable for now rust-lang#129103
- Win: Add dbghelp to the list of import libraries rust-lang#130047
- `RepeatN`: use MaybeUninit rust-lang#130145
- Update LLVM to 19 327ca6c rust-lang#130212
- Revert rust-lang#129749 to fix segfault in LLVM rust-lang#130477
- Check params for unsafety in THIR rust-lang#130531

r? cuviper
try-job: dist-various-1
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 21, 2024
@bors
Auto merge of rust-lang#130569 - cuviper:beta-next, r=cuviper
764d1ce 
[beta] backports

- Don't warn empty branches unreachable for now rust-lang#129103
- Win: Add dbghelp to the list of import libraries rust-lang#130047
- `RepeatN`: use MaybeUninit rust-lang#130145
- Update LLVM to 19 327ca6c rust-lang#130212
- Revert rust-lang#129749 to fix segfault in LLVM rust-lang#130477
- Check params for unsafety in THIR rust-lang#130531

r? cuviper
try-job: dist-various-1
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 21, 2024
@bors
Auto merge of rust-lang#130569 - cuviper:beta-next, r=cuviper
b66e83a 
[beta] backports

- Don't warn empty branches unreachable for now rust-lang#129103
- Win: Add dbghelp to the list of import libraries rust-lang#130047
- `RepeatN`: use MaybeUninit rust-lang#130145
- Update LLVM to 19 327ca6c rust-lang#130212
- Revert rust-lang#129749 to fix segfault in LLVM rust-lang#130477
- Check params for unsafety in THIR rust-lang#130531

r? cuviper
try-job: dist-various-1
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 21, 2024
@bors
Auto merge of rust-lang#130569 - cuviper:beta-next, r=cuviper
2cd6f8b 
[beta] backports

- Don't warn empty branches unreachable for now rust-lang#129103
- Win: Add dbghelp to the list of import libraries rust-lang#130047
- `RepeatN`: use MaybeUninit rust-lang#130145
- Update LLVM to 19 327ca6c rust-lang#130212
- Revert rust-lang#129749 to fix segfault in LLVM rust-lang#130477
- Check params for unsafety in THIR rust-lang#130531

r? cuviper
try-job: dist-various-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-crater Status: Waiting on a crater run to be completed. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.

Unsoundness: Patterns in function parameters are not checked for union access
10 participants
@compiler-errors @rustbot @Urgau @bors @craterbot @apiraino @cuviper @wesleywiser @BoxyUwU @TaKO8Ki