std: Ignore a flaky test on freebsd #14046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test runs successfully manually, but the bots are having trouble getting this test to pass. Ignore it on freebsd for now.
bors
added a commit
that referenced
this pull request
May 9, 2014
…kballard This test runs successfully manually, but the bots are having trouble getting this test to pass. Ignore it on freebsd for now.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Mar 13, 2023
…, r=Veykril Fix associated item visibility in block-local impls Fixes rust-lang#14046 When we're resolving visibility of block-local items... > `self` normally refers to the containing non-block module, and `super` to its parent (etc.). However, visibilities must only refer to a module in the DefMap they're written in, so we restrict them when that happens. ([link]) ...unless we're resolving visibility of associated items in block-local impls, because that impl is semantically "hoisted" to the nearest (non-block) module. With this PR, we skip the adjustment for such items. Since visibility representation of those items is modified, this PR also adjusts visibility rendering in `HirDisplay`. [link]: https://github.com/rust-lang/rust-analyzer/blob/a6603fc21d50b3386a488c96225b2d1fd492e533/crates/hir-def/src/nameres/path_resolution.rs#L101-L103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test runs successfully manually, but the bots are having trouble getting
this test to pass. Ignore it on freebsd for now.