Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

green: remove Lovecraft quotes, for its no practical value #14290

Closed
wants to merge 1 commit into from

Conversation

liigo
Copy link
Contributor

@liigo liigo commented May 19, 2014

(Perhaps we need to add another (small) Easter egg later.)
@alexcrichton (you committed in the quotes) @pcwalton (you created issue #13871)
Closes #13871

comments on reddit:
http://www.reddit.com/r/rust/comments/24fo8j/hello_world_contains_lovecraft_quotes_issue_13871/

@lilyball
Copy link
Contributor

I like lovecraft quotes.

@alexcrichton
Copy link
Member

There are no significant wins from removing these quotes, and for now I would like to retain our sense of humor. If these ever do have a significant impact, we can rethink removing them.

@lilyball
Copy link
Contributor

The only reason I can think of to remove them is if you're trying to do a bare-metal Rust on a limited-memory embedded system where a few kilobytes is precious. And if that's really a concern, we could wrap this up in a #[cfg(not(nolovecraft))].

@thestinger
Copy link
Contributor

I don't think anyone doing bare-metal Rust will use libgreen/libnative/libstd so it doesn't really matter. The underlying features like native I/O will end up being exposed without the "runtime".

@liigo
Copy link
Contributor Author

liigo commented May 20, 2014

@kballard You like Lovecraft quotes, he like Shakespeare quotes, I like Hemingway quotes... But this is not a reason to include these quotes (and which one?) in Rust source tree.

@alexcrichton These quotes is too loooong, too wordy. It's not humor, it's funny, it's mawkish. It add nothing practical value to the source tree (and Rust programs).

If someone just need something "sense of humor" here, I suggest to replace these quotes with a very simple Emoticon or Emoji text, such as :-((sad) or T_T(crying) or (?_?)(confused) or (O.O)(surprised), or even Orz and (U+56E7) and (U+69D1).
http://en.wikipedia.org/wiki/Emoticon

@omasanori
Copy link
Contributor

+1 to @liigo; I like something fun(ny), but it seems to be a bit of overkill to make 10 lines of code x5. I think it's not a problem of free-standing Rust but of readability.
(Do you feel that I'm lame? I know. 😃)

lnicola pushed a commit to lnicola/rust that referenced this pull request Mar 13, 2023
fix multiple definition binding in match to let-else

fix rust-lang#14290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"hello world" contains Lovecraft quotes
5 participants