Fix the order in which struct fields drop #16493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @pnkfelix |
When a struct implements Drop, its fields should still drop in declaration order (just as they do when the struct does not implement Drop). Fixes rust-lang#16492.
bors
added a commit
that referenced
this pull request
Aug 15, 2014
When a struct implements Drop, its fields should still drop in declaration order (just as they do when the struct does not implement Drop). Fixes #16492.
|
I just realized that while this did made things internally consistent, it may be better for us to go in the other direction, and make drop of a struct (in all contexts) drop the fields in reverse declaration order. |
|
@pnkfelix That's a good point. |
|
Filed as #16661 |
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 11, 2024
…kril fix: emit parser error for missing argument list close rust-lang/rust-analyzer#16362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a struct implements Drop, its fields should still drop in
declaration order (just as they do when the struct does not implement
Drop).
Fixes #16492.