libcore: make iterator adaptors Cloneable
#19827
Conversation
| @@ -1444,7 +1445,8 @@ impl<A, B, I, F> RandomAccessIterator<B> for Map<A, B, I, F> where | |||
| /// An iterator which filters the elements of `iter` with `predicate` | |||
| #[must_use = "iterator adaptors are lazy and do nothing unless consumed"] | |||
| #[stable] | |||
| pub struct Filter<A, I, P> where I: Iterator<A>, P: FnMut(&A) -> bool { | |||
| #[deriving(Copy, Clone)] | |||
| pub struct Filter<A, I: Iterator<A>, P: FnMut(&A) -> bool> { | |||
There was a problem hiding this comment.
Is there any reason to "de-where" these?
There was a problem hiding this comment.
From my PR message:
"(Because of #19358 I had to move the struct bounds from the where clause into the parameter list)"
|
Due to #18045, maybe we should avoid |
japaric
changed the title
Clone/CopyableCloneable
|
@alexcrichton Removed the |
|
Doesn't deriving insert bogus bounds (A: Clone) ? |
Yes :/. |
|
You can copy my code. I wrote up a PR to do this too (didn't see yours). |
|
@alexcrichton @gankro switched to manual |
|
Great to get this finally :-) thank you. |
libcore: make iterator adaptors `Clone`able Reviewed-by: alexcrichton
Using a type alias for iterator implementations is fragile since this exposes the implementation to users of the iterator, and any changes could break existing code. This commit changes the iterators of `VecMap` to use proper new types, rather than type aliases. However, since it is fair-game to treat a type-alias as the aliased type, this is a: [breaking-change].
libcore: make iterator adaptors `Clone`able Reviewed-by: alexcrichton
libcore: make iterator adaptors `Clone`able Reviewed-by: alexcrichton
closes rust-lang#12677 (cc @Valloric) cc rust-lang#15294 r? @aturon / @alexcrichton (Because of rust-lang#19358 I had to move the struct bounds from the `where` clause into the parameter list)
closes #12677 (cc @Valloric)
cc #15294
r? @aturon / @alexcrichton
(Because of #19358 I had to move the struct bounds from the
whereclause into the parameter list)