Thread native name setting #21678

vojtechkral · 2015-01-27T02:53:39Z

I really am not sure I'm doing this right, so here goes nothing...

Also testing this isn't easy. I don't have any other *nix boxes besides a Linux one.

Test code:

use std::thread;
use std::io::timer::sleep;
use std::time::duration::Duration;

fn make_thread<'a>(i: i64) -> thread::JoinGuard<'a, ()>
{
    thread::Builder::new().name(format!("MyThread{}", i).to_string()).scoped(move ||
    {
        println!("Start: {}", i);
        sleep(Duration::seconds(i));
        println!("End: {}", i);
    })
}

fn main()
{
    let mut guards = vec![make_thread(3)];

    for i in 4i64..16
    {
        guards.push(make_thread(i));
    }
}

GDB output on my machine:

(gdb) info threads
  Id   Target Id         Frame 
  15   Thread 0x7fdfbb35f700 (LWP 23575) "MyThread3" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0
  14   Thread 0x7fdfba7ff700 (LWP 23576) "MyThread4" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0
  13   Thread 0x7fdfba5fe700 (LWP 23577) "MyThread5" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0
  12   Thread 0x7fdfba3fd700 (LWP 23578) "MyThread6" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0
  11   Thread 0x7fdfb8dfe700 (LWP 23580) "MyThread4" 0x00007fdfbb746193 in select () from /usr/lib/libc.so.6
  10   Thread 0x7fdfb8fff700 (LWP 23579) "MyThread7" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0
  9    Thread 0x7fdfb8bfd700 (LWP 23581) "MyThread8" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0
  8    Thread 0x7fdfb3fff700 (LWP 23582) "MyThread9" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0
  7    Thread 0x7fdfb3dfe700 (LWP 23583) "MyThread10" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0
  6    Thread 0x7fdfb3bfd700 (LWP 23584) "MyThread11" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0
  5    Thread 0x7fdfb2bff700 (LWP 23585) "MyThread12" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0
  4    Thread 0x7fdfb29fe700 (LWP 23586) "MyThread13" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0
  3    Thread 0x7fdfb27fd700 (LWP 23587) "MyThread14" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0
  2    Thread 0x7fdfb1bff700 (LWP 23588) "MyThread15" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0
* 1    Thread 0x7fdfbc411800 (LWP 23574) "threads" 0x00007fdfbbe2e505 in pthread_join () from /usr/lib/libpthread.so.0

(I'm not sure why one of the threads is duplicated, but it does that without my patch too...)

rust-highfive · 2015-01-27T02:53:52Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

huonw · 2015-01-27T02:55:34Z

src/libstd/sys/unix/thread.rs

+    pthread_set_name_np(pthread_self(), cname.as_ptr());
+}
+
+#[cfg(target_os = "macos")]


I think iOS is (somewhat) supported too; does it use pthread_setname_np too?

@huonw It would make sense since the two OSes share the same posix base, but I can't find a direct confirmation... There is a target_os for iOS?

I think it's just "ios".

Maybe @vhbit could confirm/provide advice about the right function here. (IIRC, @vhbit has done most of the iOS work.)

Found it: over here it says pthread_setname_np() is available since OS X 10.6 and iOS 3.2

@vojtechkral @huonw yep, iOS is similar to OS X here, please change it to #[cfg(any(target_os = "macos", target_os = "ios"))]

huonw · 2015-01-27T07:35:10Z

r? @alexcrichton

alexcrichton · 2015-01-27T19:08:46Z

src/libstd/sys/unix/thread.rs

+    // because pthread_setname_np() wasn't added until glibc 2.12
+    // PR_SET_NAME since Linux 2.6.9
+    let cname = CString::from_slice(name.as_bytes());
+    prctl(15i32 /* = PR_SET_NAME */, cname.as_ptr() as u64, 0u64, 0u64, 0u64);


Can this use the linkage = "extern_weak" trick instead?

@alexcrichton Sure, which function though? prctl() or pthread_setname_np()?

For pthread_setname_np, but largely only because it looks like it's only defined on newer glibc implementations. This is a bit of a nicety, however, so we probably won't lose too much if it's not available.

vojtechkral · 2015-01-28T12:53:35Z

@alexcrichton Updated as requested. I'll try to find someone to test this on BSD / OS X ...

vojtechkral · 2015-01-28T13:03:57Z

@vhbit I just noticed that too :) Note that the "ios" target should probably accompany most of the other target_os = "macos" occurences as well, but I suppose that's beyond the scope of this PR.

vhbit · 2015-01-28T13:04:51Z

Have no BSD but will test it on OS X

vhbit · 2015-01-28T13:05:47Z

@vojtechkral usually it is although I'm not fast enough to track all the changes :-)

vhbit · 2015-01-28T14:08:38Z

Works fine on OS X

vojtechkral · 2015-01-28T14:17:25Z

@vhbit thanks!

Gankra · 2015-01-28T15:00:37Z

@bors try 7e67

Fixes #10302 I really am not sure I'm doing this right, so here goes nothing... Also testing this isn't easy. I don't have any other *nix boxes besides a Linux one. Test code: ```rust use std::thread; use std::io::timer::sleep; use std::time::duration::Duration; fn make_thread<'a>(i: i64) -> thread::JoinGuard<'a, ()> { thread::Builder::new().name(format!("MyThread{}", i).to_string()).scoped(move || { println!("Start: {}", i); sleep(Duration::seconds(i)); println!("End: {}", i); }) } fn main() { let mut guards = vec![make_thread(3)]; for i in 4i64..16 { guards.push(make_thread(i)); } } ``` GDB output on my machine: ``` (gdb) info threads Id Target Id Frame 15 Thread 0x7fdfbb35f700 (LWP 23575) "MyThread3" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 14 Thread 0x7fdfba7ff700 (LWP 23576) "MyThread4" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 13 Thread 0x7fdfba5fe700 (LWP 23577) "MyThread5" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 12 Thread 0x7fdfba3fd700 (LWP 23578) "MyThread6" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 11 Thread 0x7fdfb8dfe700 (LWP 23580) "MyThread4" 0x00007fdfbb746193 in select () from /usr/lib/libc.so.6 10 Thread 0x7fdfb8fff700 (LWP 23579) "MyThread7" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 9 Thread 0x7fdfb8bfd700 (LWP 23581) "MyThread8" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 8 Thread 0x7fdfb3fff700 (LWP 23582) "MyThread9" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 7 Thread 0x7fdfb3dfe700 (LWP 23583) "MyThread10" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 6 Thread 0x7fdfb3bfd700 (LWP 23584) "MyThread11" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 5 Thread 0x7fdfb2bff700 (LWP 23585) "MyThread12" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 4 Thread 0x7fdfb29fe700 (LWP 23586) "MyThread13" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 3 Thread 0x7fdfb27fd700 (LWP 23587) "MyThread14" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 2 Thread 0x7fdfb1bff700 (LWP 23588) "MyThread15" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 * 1 Thread 0x7fdfbc411800 (LWP 23574) "threads" 0x00007fdfbbe2e505 in pthread_join () from /usr/lib/libpthread.so.0 ``` (I'm not sure why one of the threads is duplicated, but it does that without my patch too...)

bors · 2015-01-28T15:00:41Z

⌛ Testing commit 7e67eba with merge 90ed244...

bors · 2015-01-28T15:39:09Z

💔 Test failed - auto-linux-64-x-android-t

Gankra · 2015-01-28T15:44:37Z

Seems to break 64-bit android

vojtechkral · 2015-01-28T16:07:56Z

There was a missing "android" target on the extern, which is weird... I don't understand how it compiled on Android before... edit: It's because the other android cfg test are basically redundant since guard is not enabled for android. It seems the "android" and "ios" target_os tests are kind of a mess :)

Gankra · 2015-01-28T16:30:38Z

@bors try 9ee9

bors · 2015-01-28T16:30:45Z

⌛ Testing commit 9ee972c with merge f01bc73...

bors · 2015-01-28T19:42:16Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

alexcrichton · 2015-01-28T20:33:59Z

@bors: r+ 9ee972c rollup

Thanks!

bors · 2015-01-28T20:34:02Z

⌛ Testing commit 9ee972c with merge badca40...

bors · 2015-01-28T21:49:37Z

💔 Test failed - auto-linux-64-x-android-t

alexcrichton · 2015-01-28T21:49:41Z

@bors: retry

Fixes rust-lang#10302 I really am not sure I'm doing this right, so here goes nothing... Also testing this isn't easy. I don't have any other *nix boxes besides a Linux one. Test code: ```rust use std::thread; use std::io::timer::sleep; use std::time::duration::Duration; fn make_thread<'a>(i: i64) -> thread::JoinGuard<'a, ()> { thread::Builder::new().name(format!("MyThread{}", i).to_string()).scoped(move || { println!("Start: {}", i); sleep(Duration::seconds(i)); println!("End: {}", i); }) } fn main() { let mut guards = vec![make_thread(3)]; for i in 4i64..16 { guards.push(make_thread(i)); } } ``` GDB output on my machine: ``` (gdb) info threads Id Target Id Frame 15 Thread 0x7fdfbb35f700 (LWP 23575) "MyThread3" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 14 Thread 0x7fdfba7ff700 (LWP 23576) "MyThread4" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 13 Thread 0x7fdfba5fe700 (LWP 23577) "MyThread5" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 12 Thread 0x7fdfba3fd700 (LWP 23578) "MyThread6" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 11 Thread 0x7fdfb8dfe700 (LWP 23580) "MyThread4" 0x00007fdfbb746193 in select () from /usr/lib/libc.so.6 10 Thread 0x7fdfb8fff700 (LWP 23579) "MyThread7" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 9 Thread 0x7fdfb8bfd700 (LWP 23581) "MyThread8" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 8 Thread 0x7fdfb3fff700 (LWP 23582) "MyThread9" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 7 Thread 0x7fdfb3dfe700 (LWP 23583) "MyThread10" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 6 Thread 0x7fdfb3bfd700 (LWP 23584) "MyThread11" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 5 Thread 0x7fdfb2bff700 (LWP 23585) "MyThread12" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 4 Thread 0x7fdfb29fe700 (LWP 23586) "MyThread13" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 3 Thread 0x7fdfb27fd700 (LWP 23587) "MyThread14" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 2 Thread 0x7fdfb1bff700 (LWP 23588) "MyThread15" 0x00007fdfbbe35a8d in nanosleep () from /usr/lib/libpthread.so.0 * 1 Thread 0x7fdfbc411800 (LWP 23574) "threads" 0x00007fdfbbe2e505 in pthread_join () from /usr/lib/libpthread.so.0 ``` (I'm not sure why one of the threads is duplicated, but it does that without my patch too...)

- incoporate changes introduced by rust-lang#21678

Thread native name setting, fix rust-lang#10302

ec4981e

rust-highfive assigned pcwalton Jan 27, 2015

huonw reviewed Jan 27, 2015
View reviewed changes

rust-highfive assigned alexcrichton and unassigned pcwalton Jan 27, 2015

Thread native name setting, fix rust-lang#10302

c155208

alexcrichton reviewed Jan 27, 2015
View reviewed changes

Thread native name setting, fix rust-lang#10302

33a3d6d

Thread native name setting, fix rust-lang#10302

7e67eba

Thread native name setting, fix rust-lang#10302

9ee972c

alexcrichton merged commit 9ee972c into rust-lang:master Jan 31, 2015

vojtechkral deleted the threads-native-names branch January 31, 2015 13:57

semarie mentioned this pull request Feb 1, 2015

Adding OpenBSD support to rust #21754

Merged

semarie added a commit to semarie/rust that referenced this pull request Feb 1, 2015

openbsd: rebase to master

f6414b0

- incoporate changes introduced by rust-lang#21678

alexcrichton mentioned this pull request Feb 3, 2015

All rust process in top are called <main> #21911

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Thread native name setting #21678

Thread native name setting #21678

vojtechkral commented Jan 27, 2015

rust-highfive commented Jan 27, 2015

huonw Jan 27, 2015

vojtechkral Jan 27, 2015

huonw Jan 27, 2015

vojtechkral Jan 27, 2015

vhbit Jan 27, 2015

huonw commented Jan 27, 2015

alexcrichton Jan 27, 2015

vojtechkral Jan 28, 2015

alexcrichton Jan 28, 2015

vojtechkral commented Jan 28, 2015

vojtechkral commented Jan 28, 2015

vhbit commented Jan 28, 2015

vhbit commented Jan 28, 2015

vhbit commented Jan 28, 2015

vojtechkral commented Jan 28, 2015

Gankra commented Jan 28, 2015

bors commented Jan 28, 2015

bors commented Jan 28, 2015

Gankra commented Jan 28, 2015

vojtechkral commented Jan 28, 2015

Gankra commented Jan 28, 2015

bors commented Jan 28, 2015

bors commented Jan 28, 2015

alexcrichton commented Jan 28, 2015

bors commented Jan 28, 2015

bors commented Jan 28, 2015

alexcrichton commented Jan 28, 2015

Thread native name setting #21678

Thread native name setting #21678

Conversation

vojtechkral commented Jan 27, 2015

rust-highfive commented Jan 27, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huonw commented Jan 27, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vojtechkral commented Jan 28, 2015

vojtechkral commented Jan 28, 2015

vhbit commented Jan 28, 2015

vhbit commented Jan 28, 2015

vhbit commented Jan 28, 2015

vojtechkral commented Jan 28, 2015

Gankra commented Jan 28, 2015

bors commented Jan 28, 2015

bors commented Jan 28, 2015

Gankra commented Jan 28, 2015

vojtechkral commented Jan 28, 2015

Gankra commented Jan 28, 2015

bors commented Jan 28, 2015

bors commented Jan 28, 2015

alexcrichton commented Jan 28, 2015

bors commented Jan 28, 2015

bors commented Jan 28, 2015

alexcrichton commented Jan 28, 2015