Tutorial: Added note about type parameters in ifaces. #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specficially, the type parameters should be left off of the function signatures in both the iface and the impl if they are already in the iface declaration.
|
The newer commit should be: use of the |
|
I more or less rewrote the entire patch, but thanks for calling attention to these areas :-) |
|
Given the amount of time that passed between the pull request and the merge, and the change to use traits and my lack of full understanding of what is going on, that is fully understandable. |
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Jun 29, 2023
Revert error in doc comment Also punctuation
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
Bumps [ncipollo/release-action](https://github.com/ncipollo/release-action) from 1.12.0 to 1.13.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specficially, the type parameters should be left off of the function
signatures in both the iface and the impl if they are already in the
iface declaration.