Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid user-defined macros named "macro_rules" #36730

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Forbid user-defined macros named "macro_rules" #36730

merged 1 commit into from
Sep 26, 2016

Conversation

jseyfried
Copy link
Contributor

@jseyfried jseyfried commented Sep 26, 2016 •
edited
Loading

This is a [breaking-change].
r? @nrc

@jseyfried
Copy link
Contributor Author

jseyfried commented Sep 26, 2016 •
edited
Loading

If users can define their own macro_rules, we have to treat all macro_rules!-defined macros as macro-expanded macros (w.r.t. the shadowing rules in rust-lang/rfcs#1560), so we wouldn't be able to backport the shadowing restrictions.

This would mean, for example, that a 1.0 macro wouldn't be able to use macros from other crates in its expansion (cc #35896).

@nrc
Copy link
Member

nrc commented Sep 26, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 26, 2016

📌 Commit 77958d5 has been approved by nrc

@bluss bluss added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 26, 2016
@bors
Copy link
Contributor

bors commented Sep 26, 2016

⌛ Testing commit 77958d5 with merge b786976...

bors added a commit that referenced this pull request Sep 26, 2016
@bors
Auto merge of #36730 - jseyfried:make_macro_rules_invocations_magic, …
b786976 
…r=nrc

Forbid user-defined macros named "macro_rules"

This is a [breaking-change].
r? @nrc
@bors
Copy link
Contributor

bors commented Sep 26, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: nrc
Pushing b786976 to master...

@bors bors merged commit 77958d5 into rust-lang:master Sep 26, 2016
@jseyfried jseyfried deleted the make_macro_rules_invocations_magic branch September 27, 2016 18:25
@jseyfried jseyfried mentioned this pull request Feb 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jseyfried @nrc @bors @bluss