Support useing externally defined macros behind #![feature(use_extern_macros)]
#37732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseyfried
force-pushed
the
use_extern_macros
branch
from
65da379
to
a75cc5b
Compare
jseyfried
force-pushed
the
use_extern_macros
branch
4 times, most recently
from
8e1dcf6
to
cc550af
Compare
nrc
approved these changes
Nov 15, 2016
| self.used_crates.insert(def.def_id().krate); | ||
| fn legacy_import_macro( | ||
| &mut self, name: Name, binding: &'b NameBinding<'b>, span: Span, allow_shadowing: bool, | ||
| ) { |
There was a problem hiding this comment.
formatting nit: prefer one arg per line
| parent: Module<'b>, | ||
| vis: ty::Visibility) { | ||
| fn build_reduced_graph_for_variant( | ||
| &mut self, variant: &Variant, parent: Module<'b>, vis: ty::Visibility, expansion: Mark, |
|
☔ The latest upstream changes (presumably #37545) made this pull request unmergeable. Please resolve the merge conflicts. |
jseyfried
force-pushed
the
use_extern_macros
branch
from
cc550af
to
6cb33a0
Compare
|
@bors r=nrc |
|
📌 Commit 6cb33a0 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 17, 2016
Support `use`ing externally defined macros behind `#![feature(use_extern_macros)]` With `#![feature(use_extern_macros)]`, - A name collision between macros from different upstream crates is much less of an issue since we can `use` the macros in different submodules or rename with `as`. - We can reexport macros with `pub use`, so `#![feature(macro_reexport)]` is no longer needed. - These reexports are allowed in any module, so crates can expose a macro-modular interface. If a macro invocation can resolve to both a `use` import and a `macro_rules!` or `#[macro_use]`, it is an ambiguity error. r? @nrc
This was referenced Nov 17, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
#![feature(use_extern_macros)],usethe macros in different submodules or rename withas.pub use, so#![feature(macro_reexport)]is no longer needed.If a macro invocation can resolve to both a
useimport and amacro_rules!or#[macro_use], it is currently an ambiguity error.r? @nrc