Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit "align 1" metadata on loads/stores of packed structs #39586

Merged
merged 5 commits into from
Feb 9, 2017

Commits on Feb 8, 2017

  1. emit "align 1" metadata on loads/stores of packed structs

    According to the LLVM reference:
    > A value of 0 or an omitted align argument means that the operation has
    the ABI alignment for the target.
    
    So loads/stores of fields of packed structs need to have their align set
    to 1. Implement that by tracking the alignment of `LvalueRef`s.
    
    Fixes rust-lang#39376.
    arielb1 committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    09825de View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7ce1f51 View commit details
    Browse the repository at this point in the history
  3. Inline the function with_lvalue_ref into trans_transmute

    The function was a footgun because it created `undef` references to
    ZSTs, which could cause trouble were they to leak to user code.
    arielb1 committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    ffcfdcf View commit details
    Browse the repository at this point in the history
  4. address review comments

    arielb1 committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    3652c09 View commit details
    Browse the repository at this point in the history
  5. pacify tidy

    arielb1 committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    d71988a View commit details
    Browse the repository at this point in the history