Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #40294 obligation cause.body_id is not always a NodeExpr #40404

Merged
merged 2 commits into from
Mar 12, 2017
Merged

fix #40294 obligation cause.body_id is not always a NodeExpr #40404

merged 2 commits into from
Mar 12, 2017

Conversation

cengiz-io
Copy link
Contributor

Hello!

This fixes #40294 and moves tests related to #38812 to a much more sensible directory.

Thanks to @nikomatsakis and @eddyb

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@cengiz-io
Copy link
Contributor Author

r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 10, 2017

📌 Commit 7f19f1f has been approved by nikomatsakis

@petrochenkov
Copy link
Contributor

@cengizio

and moves tests related to #38812 to a much more sensible directory

Those tests are about type checking, not name resolution.
Could you move then to some (possibly new) subdirectory dedicated to type checking instead?

@bors r-
(Sorry.)

@cengiz-io
Copy link
Contributor Author

@petrochenkov thanks for warning.

Maybe we can add directory mappings to src/test/ui/README.md

@petrochenkov
Copy link
Contributor

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented Mar 10, 2017

📌 Commit 889337d has been approved by nikomatsakis

@Zoxc
Copy link
Contributor

Zoxc commented Mar 10, 2017

The test for #40294 is a edited copy of the #21974 test. It should go alongside it in compile-fail.

@cengiz-io
Copy link
Contributor Author

@bors r-

@nikomatsakis
Copy link
Contributor

@Zoxc

The test for #40294 is a edited copy of the #21974 test. It should go alongside it in compile-fail.

So, I agree with @petrochenkov that resolve wasn't the right directory (good spot!), but I don't see any particular reason that #40294 has to live alongside the test for #21974, though. (And I'd like to remove compile-fail anyhow.) It's a separate regression test, regardless of how it was derived.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 10, 2017

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Mar 10, 2017

📌 Commit 889337d has been approved by nikomatsakis

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr

Hello!

This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory.

Thanks to @nikomatsakis and @eddyb
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr

Hello!

This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory.

Thanks to @nikomatsakis and @eddyb
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr

Hello!

This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory.

Thanks to @nikomatsakis and @eddyb
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr

Hello!

This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory.

Thanks to @nikomatsakis and @eddyb
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr

Hello!

This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory.

Thanks to @nikomatsakis and @eddyb
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 11, 2017
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr

Hello!

This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory.

Thanks to @nikomatsakis and @eddyb
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 11, 2017
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr

Hello!

This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory.

Thanks to @nikomatsakis and @eddyb
bors added a commit that referenced this pull request Mar 11, 2017
Rollup of 13 pull requests

- Successful merges: #40146, #40299, #40315, #40319, #40344, #40345, #40367, #40372, #40373, #40385, #40400, #40404, #40431
- Failed merges:
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 11, 2017
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr

Hello!

This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory.

Thanks to @nikomatsakis and @eddyb
bors added a commit that referenced this pull request Mar 12, 2017
Rollup of 12 pull requests

- Successful merges: #40146, #40299, #40315, #40319, #40344, #40345, #40372, #40373, #40400, #40404, #40419, #40431
- Failed merges:
@bors bors merged commit 889337d into rust-lang:master Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler unnecessary panicked due to a mistake in where clause
7 participants