Updated releases notes for 1.19 #42503

XAMPPRocky · 2017-06-07T10:57:39Z

This is waiting on any beta backports in the coming weeks, and the lib stabilisations pr.

rust-highfive · 2017-06-07T10:57:46Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

XAMPPRocky · 2017-06-07T11:02:42Z

In this release there has been a lot of error codes added by @GuillaumeGomez I was wondering should they each get a line item, or is the current fine?

jtdowney · 2017-06-07T11:03:08Z

RELEASES.md

+--------
+
+- [Numeric fields can now be used for creating tuple structs.][36868]
+  For example `struct Point(u32, u32); let x = Foo { 0: 7, 1: 0 };`.


Wouldn't this be let x = Point { 0: 7, 1: 0 };

Nemo157 · 2017-06-07T11:47:00Z

RELEASES.md

+  the members in a given workspace.][cargo/3988]
+- [Updated `libssh2-sys` to 0.2.6][cargo/4008]
+- [Target directory path is now in the cargo metadata][cargo/4022]
+- [Cargo no longer checks the crates.io index locally][cargo/4026] This should


I would word this something like "Cargo no longer checks out a local working directory for the crates.io index"

ollie27

Looks like a few things are missing:

From<Box<str>> for Box<[u8]> More methods for str boxes. (reduce Box<[u8]> ↔ Box<str> transmutes) #41258
eprint! and eprintln! Add eprint! and eprintln! macros to the prelude. #41192
closure_to_fn_coercion Stabilize non capturing closure to fn coercion #42162

ollie27 · 2017-06-07T12:32:16Z

RELEASES.md

+- [Ending a float literal with `._` is now a hard error.
+  Example: `42._` .][41946]
+- [Ending a str literal with an underscore is now a hard error
+  Example: `"foo"_`][41990]


This didn't make it into 1.19.

This is also a warning, not error.

ollie27 · 2017-06-07T12:40:30Z

RELEASES.md

+- [Added `rust-windbg.cmd`][39983] for loading rust `.natvis` files in the
+  Windows Debugger.
+- [Rust Language Server is now packaged as a non default component with the
+  `.exe`, `.msi`, and `.pkg` installers][42306]


I think this has been reverted: #42472

petrochenkov · 2017-06-07T13:35:57Z

RELEASES.md

+Language
+--------
+
+- [Numeric fields can now be used for creating tuple structs.][36868]


The correct PR is #41145

petrochenkov · 2017-06-07T13:39:34Z

RELEASES.md

+- [Ending a str literal with an underscore is now a hard error
+  Example: `"foo"_`][41990]
+- [Publicly exposing a private type is now a hard error][34537] This was
+  previously a warning.


Nah, this is wrong. Most of #34537 isn't going to be an error, only some tiny piece of it (public reexports of private enum variants) has become an error.

petrochenkov · 2017-06-07T13:41:13Z

RELEASES.md

+- [Publicly exposing a private type is now a hard error][34537] This was
+  previously a warning.
+- [Type parameter defaults in trait impls and functions is now a
+  hard error][36887] This was previously a warning.


This is still a warning, there was too much breakage (as you can see, the issue is still open).

petrochenkov · 2017-06-07T13:42:32Z

RELEASES.md

+- [Type parameter defaults in trait impls and functions is now a
+  hard error][36887] This was previously a warning.
+- [`use` imports on a private `extern crate` in a module is now a hard
+  error.][36886] This was previously a warning.


#36886 is about any use of private extern crates outside of their module, not about imports or reexports.

mbrubeck

These look great! Here are a few additions that I think would clarify some of them.

mbrubeck · 2017-06-07T15:47:05Z

RELEASES.md

+  For example: `let x = loop { break 7; };`
+- [C compatible `union`s are now available.][42068] They can only contain `Copy`
+  types and cannot have a `Drop` implementation.
+  Example: `union Foo { bar: u8 }`


A union with two fields of different types might be a clearer example.

mbrubeck · 2017-06-07T15:56:24Z

RELEASES.md

+Compiler
+--------
+
+- [Added bootstrap support for Android.][41370]


I suggest expanding this to "Add support for bootstrapping the Rust compiler toolchain on Android."

mbrubeck · 2017-06-07T15:56:26Z

RELEASES.md

+
+- [Added bootstrap support for Android.][41370]
+- [Change `arm-linux-androideabi` to correspond to the `armeabi`
+  official ABI.][41656]


It might be useful to note that developers must now use --target armv7-linux-androideabi if they want to continue targeting the armeabi-v7a ABI.

cuviper · 2017-06-07T16:50:21Z

Should this now mention LLVM4 support? (i.e. rust-llvm is upgraded, and external LLVM4 works too.)

TimNN · 2017-06-07T18:33:40Z

RELEASES.md

+  Example: `union Foo { bar: u8 }`
+
+Compiler
+--------


This section should probably mention the LLVM upgrade #40123.

Edit: Nevermind this comment, I didn't notice @cuviper's comment when looking at the diff.

XAMPPRocky · 2017-06-07T21:01:59Z

@cuviper @TimNN Is there anything to be said about using LLVM 4.0, or is Now uses LLVM 4.0 enough?

ranma42 · 2017-06-08T16:44:25Z

@brson on the rust side, XZ compression of the tarballs should ready. Should it be mentioned in the release notes or is it better to wait for the next rustup release?

cuviper · 2017-06-08T16:58:05Z

@Aaronepower There are two sides to it, both the version of LLVM that Rust is shipped with and the external versions it supports in custom builds. For the LLVM 3.9 update it simply said, "The compiler can now be built against LLVM 3.9".

brson · 2017-06-08T17:52:35Z

Thanks a bunch @Aaronepower.

Added a link to the rendered notes to the OP.

@Aaronepower do any of these have RFC's that can be referenced for further info? I bet numeric fields, break return, unions, maybe closure coercions.

I see that 'compatibility notes' is not last this time. Any particular reason? I've put them last in the past to deemphasize them.

I don't see custom CRT linkage, xz compression.

I've added a milestone issue to make sure rustup with xz gets released: #42542

brson · 2017-06-08T17:53:03Z

@ranma42 Yes, I think it should be mentioned. rustup will be out in time.

brson · 2017-06-08T17:54:37Z

@Aaronepower I think one line for the error codes is fine.

alexcrichton · 2017-06-15T14:37:31Z

ping @Aaronepower, just wanted to keep this on your radar!

kennytm · 2017-06-18T20:18:34Z

I think rust-lang/cargo#3954 (Add support for custom target-specific runners — target.$triple.runner in .cargo/config) is worth mentioning.

brson · 2017-07-08T01:00:39Z

It is possible the RangeArgument type will change names before release: #43033

brson · 2017-07-13T00:18:55Z

RangeArgument is not in the release.

brson · 2017-07-13T00:55:14Z

Updated for all comments. #42635 is slated to be fixed and doesn't need a compat note. We might wait to see that reverted and then this is probably good to go.

mbrubeck · 2017-07-13T01:09:58Z

RELEASES.md

+  a warning.
+- [From the pound escape, lines consisting of multiple `#`s are
+  now visible][41785]
+- [`for` loop desugaring has changed such that `break` does nat


Typo: s/nat/not/

mbrubeck · 2017-07-13T01:11:45Z

RELEASES.md

+- [Rust will now release XZ compressed packages][rust-installer/57]
+- [rustup will now prefer to download rust packages with
+  XZ compression][rustup/1100] over GZip packages.
+- [Added the ability to escape `#` in rust documentation][41785] By adding


This change is mentioned twice (once here, then again in "Compatibility Notes" below).

Yeah, I noticed that and decided that it's ok - it's a feature addition with compatibility concerns. shrug

brson · 2017-07-13T01:22:24Z

@steveklabnik since we're reverting this change that affects nmake, at least temporarily, to give more time for the ecosystem to adapt, it might be worth mentioning in the release announcement so users are aware.

Zoxc · 2017-07-13T01:40:22Z

RELEASES.md

+- [From the pound escape, lines consisting of multiple `#`s are
+  now visible][41785]
+- [`for` loop desugaring has changed such that `break` does not
+  affect type inference][42634]


This pull request is a fix for #42265 which has never been stable.

This should say: for loop desugaring has changed such that the iterator is not borrowed during the loop body.
#42265 should also be referenced.

It probably doesn't belong in compatibility notes since it should have no effect on Rust code.

Thanks @Zoxc. Since it has no effect, I just removed it completely.

brson · 2017-07-13T02:37:02Z

Oh, if the jobserver patch is reverted, it will need to be removed from the relnotes.

XAMPPRocky · 2017-07-13T10:04:17Z

@brson I'm not seeing any revert PR, was this mentioned somewhere?

jimmycuadra · 2017-07-14T01:18:03Z

RELEASES.md

+  `aborting due to N previous errors`][42150] This was previously inaccurate and
+  would only count certain kinds of errors.
+- [The compiler now supports Visual Studio 2017][42225]
+- [The compiler is now be built against LLVM 4.0.1 by default][42948]


Typo: "is now be built"

jimmycuadra · 2017-07-14T01:24:53Z

In the compatibility notes, #34537 and #42460 are both linked with nearly identical descriptions. Do these represent the same underlying subject, and if so, should one of those links be removed?

brson · 2017-07-14T20:38:08Z

@Aaronepower jobserver was reverted here, which was actually merged here.

brson · 2017-07-14T20:40:37Z

@jimmycuadra yeah, they are both pretty much the same, probably we should only keep the link to the private_in_public PR.

sfackler · 2017-07-19T17:33:40Z

RELEASES.md

+  command, which has been available since 1.16.
+- [Ending a float literal with `._` is now a hard error.
+  Example: `42._` .][41946]
+- [Any use of a private `extern crate` outside of it's module is now a


its not it's I think?

brson · 2017-07-19T17:57:59Z

@bors p=100 needs to land before the release!

steveklabnik · 2017-07-19T18:31:51Z

RELEASES.md

+[RFC 1558]: https://github.com/rust-lang/rfcs/pull/1558
+[RFC 1624]: https://github.com/rust-lang/rfcs/pull/1624
+[RFC 1721]: https://github.com/rust-lang/rfcs/pull/1721
+[`Command::envs`]: https://doc.rust-lang.org/nightly/std/process/struct.Command.html#method.envs


it'd be nice if this didn't link to nightly but it's not a blocker

alexcrichton · 2017-07-20T15:15:21Z

@bors: r+

bors · 2017-07-20T15:15:22Z

📌 Commit a911c0c has been approved by alexcrichton

bors · 2017-07-20T16:47:43Z

🔒 Merge conflict

steveklabnik · 2017-07-20T17:48:14Z

Github shows no conflict. Dunno whats up.

@bors: retry

maybe?

Mark-Simulacrum · 2017-07-20T17:58:45Z

This needs to be rebased, the conflict is presumably in a submodule.

XAMPPRocky · 2017-07-20T18:45:07Z

Closing in favour of a new PR without submodule problems. #43368

Update release notes for 1.19.0 This is just #42503 there is some problems with submodules I can't seem to fix so I just created a new PR.

Updated releases notes for 1.19

88bacc4

rust-highfive assigned aturon Jun 7, 2017

jtdowney reviewed Jun 7, 2017

View reviewed changes

Update RELEASES.md

2e19040

Nemo157 reviewed Jun 7, 2017

View reviewed changes

Update RELEASES.md

c74b4c3

ollie27 suggested changes Jun 7, 2017

View reviewed changes

petrochenkov reviewed Jun 7, 2017

View reviewed changes

mbrubeck reviewed Jun 7, 2017

View reviewed changes

TimNN reviewed Jun 7, 2017

View reviewed changes

aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2017

Create RELEASES.md

a8daa00

carols10cents added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2017

Update RELEASES.md

1b73fd6

mbrubeck reviewed Jul 13, 2017

View reviewed changes

Zoxc reviewed Jul 13, 2017

View reviewed changes

Update 1.19 relnotes

525bc2e

jimmycuadra reviewed Jul 14, 2017

View reviewed changes

Aaronepower added 2 commits July 15, 2017 10:11

Update RELEASES.md

ff23f2d

Removed jobserver note.

c0dbb12

sfackler reviewed Jul 19, 2017

View reviewed changes

Update typo

7d70604

steveklabnik reviewed Jul 19, 2017

View reviewed changes

Update RELEASES.md

a911c0c

XAMPPRocky mentioned this pull request Jul 20, 2017

Update release notes for 1.19.0 #43368

Merged

XAMPPRocky closed this Jul 20, 2017

bors added a commit that referenced this pull request Jul 20, 2017

Auto merge of #43368 - Aaronepower:patch-3, r=alexcrichton

cc80053

Update release notes for 1.19.0 This is just #42503 there is some problems with submodules I can't seem to fix so I just created a new PR.

Updated releases notes for 1.19 #42503

Updated releases notes for 1.19 #42503

Conversation

XAMPPRocky commented Jun 7, 2017 • edited by brson Loading

rust-highfive commented Jun 7, 2017

XAMPPRocky commented Jun 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ollie27 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbrubeck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbrubeck Jun 7, 2017 • edited Loading

Choose a reason for hiding this comment

cuviper commented Jun 7, 2017

TimNN Jun 7, 2017 • edited Loading

Choose a reason for hiding this comment

XAMPPRocky commented Jun 7, 2017

ranma42 commented Jun 8, 2017

cuviper commented Jun 8, 2017

brson commented Jun 8, 2017

brson commented Jun 8, 2017

brson commented Jun 8, 2017

alexcrichton commented Jun 15, 2017

kennytm commented Jun 18, 2017

brson commented Jul 8, 2017

brson commented Jul 13, 2017

brson commented Jul 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brson commented Jul 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brson commented Jul 13, 2017

XAMPPRocky commented Jul 13, 2017

Choose a reason for hiding this comment

jimmycuadra commented Jul 14, 2017

brson commented Jul 14, 2017

brson commented Jul 14, 2017

Choose a reason for hiding this comment

brson commented Jul 19, 2017

Choose a reason for hiding this comment

alexcrichton commented Jul 20, 2017

bors commented Jul 20, 2017

bors commented Jul 20, 2017

steveklabnik commented Jul 20, 2017

Mark-Simulacrum commented Jul 20, 2017

XAMPPRocky commented Jul 20, 2017

XAMPPRocky commented Jun 7, 2017 •

edited by brson

Loading

mbrubeck Jun 7, 2017 •

edited

Loading

TimNN Jun 7, 2017 •

edited

Loading

brson commented Jul 13, 2017 •

edited

Loading