Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor type memory layouts and ABIs, to be more general and easier to optimize. #45225

Merged
merged 69 commits into from
Nov 20, 2017
Merged

Refactor type memory layouts and ABIs, to be more general and easier to optimize. #45225

merged 69 commits into from
Nov 20, 2017

Commits on Nov 17, 2017

  1. rustc_trans: move const & lvalue access helpers from adt.

    @eddyb
    eddyb committed Nov 17, 2017
    Configuration menu
    Copy the full SHA
    fab2532 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2017

  1. rustc_mir: always downcast enums, even if univariant.

    @eddyb
    eddyb committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    9deea47 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2017

  1. rustc_trans: avoid working with sizes/offsets and alignments as integ… 

    …ers.
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    f44b099 View commit details
    Browse the repository at this point in the history

  2. rustc_trans: use a predictable layout for constant ADTs.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    386d59d View commit details
    Browse the repository at this point in the history

  3. rustc_trans: remove obsolete Type methods.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    b8671be View commit details
    Browse the repository at this point in the history

  4. rustc_trans: do not introspect LLVM aggregate field types.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    260c41b View commit details
    Browse the repository at this point in the history

  5. rustc_trans: use more of the trans::mir and ty::layout APIs throughout.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    5b1fdae View commit details
    Browse the repository at this point in the history

  6. rustc_trans: remove the in_memory_type_of distinction.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    84b5a3d View commit details
    Browse the repository at this point in the history

  7. rustc_trans: use *[T; 0] for slice data pointers instead of *T.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    0a1fcc3 View commit details
    Browse the repository at this point in the history

  8. rustc_trans: always insert alignment padding, even before the first f… 

    …ield.
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    8afa3a0 View commit details
    Browse the repository at this point in the history

  9. rustc: do not inject discriminant fields into Layout::General's varia… 

    …nts.
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    44eef7c View commit details
    Browse the repository at this point in the history

  10. rustc: remove useless 0 prefix from Layout::StructWrappedNullablePoin… 

    …ter's discrfield.
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    50a3fd0 View commit details
    Browse the repository at this point in the history

  11. rustc: use an offset instead of a field path in Layout::StructWrapped… 

    …NullablePointer.
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    bc8e1f7 View commit details
    Browse the repository at this point in the history

  12. rustc: remove source field path from Layout::StructWrappedNullablePoi… 

    …nter.
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    aa811d7 View commit details
    Browse the repository at this point in the history

  13. rustc: re-complicate the TyLayout API and use better names.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    8864668 View commit details
    Browse the repository at this point in the history

  14. rustc: remove Ty::layout and move everything to layout_of.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    8c4d5af View commit details
    Browse the repository at this point in the history

  15. rustc: pre-compute field placements out of Layout.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    9a0efea View commit details
    Browse the repository at this point in the history

  16. rustc_trans: treat General enums like unions.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    3071060 View commit details
    Browse the repository at this point in the history

  17. rustc: represent the discriminant as a field for Layout::{Raw,StructW… 

    …rapped}NullablePointer.
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    1dc572b View commit details
    Browse the repository at this point in the history

  18. rustc: introduce layout::Abi for reduced general ABI "passing style".

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    caef91d View commit details
    Browse the repository at this point in the history

  19. rustc: collapse Layout::{Raw,StructWrapped}NullablePointer into one v… 

    …ariant.
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    02276e9 View commit details
    Browse the repository at this point in the history

  20. rustc: do not track non_zero in Layout.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    335bd8e View commit details
    Browse the repository at this point in the history

  21. rustc: use Primitive instead of Integer for CEnum and General discrim… 

    …inants.
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    61c2bd9 View commit details
    Browse the repository at this point in the history

  22. rustc: move CEnum's signedness into Primitive::Int.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    d318b9c View commit details
    Browse the repository at this point in the history

  23. rustc: give Layout::CEnum a discriminant field like Layout::General.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    658ebfc View commit details
    Browse the repository at this point in the history

  24. rustc: collapse Layout::CEnum into Layout::General.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    33a205b View commit details
    Browse the repository at this point in the history

  25. rustc: make Layout::NullablePointer a lot more like Layout::General.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    bd86f37 View commit details
    Browse the repository at this point in the history

  26. rustc: move size/alignment from Layout into layout::Abi.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    bd51a2b View commit details
    Browse the repository at this point in the history

  27. rustc: store CachedLayout for each variant of enum Layout's instead o… 

    …f Struct.
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    ed788a6 View commit details
    Browse the repository at this point in the history

  28. rustc: hide details in Layout in favor of Abi or FieldPlacement.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    08f9f13 View commit details
    Browse the repository at this point in the history

  29. rustc: move layout::Struct into FieldPlacement/Abi.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    18d54aa View commit details
    Browse the repository at this point in the history

  30. rustc: split layout::FieldPlacement::Linear back into Union and Array.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    fad9954 View commit details
    Browse the repository at this point in the history

  31. rustc_trans: compute LLVM types from type layouts, not Rust types.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    d0ab6e8 View commit details
    Browse the repository at this point in the history

  32. rustc: do not pub use Layout::* in layout.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    b2d52d2 View commit details
    Browse the repository at this point in the history

  33. rustc_trans: pass OperandRef arguments to trans_intrinsic_call.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    f2e7e17 View commit details
    Browse the repository at this point in the history

  34. rustc_trans: nest abi::ArgType's for fat pointers instead of eagerly … 

    …flattening.
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    88f7032 View commit details
    Browse the repository at this point in the history

  35. rustc_trans: keep a layout instead of a type in {Lvalue,Operand}Ref.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    1477119 View commit details
    Browse the repository at this point in the history

  36. rustc_trans: query LLVM types from a layout instead of a Ty.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    3fd6b00 View commit details
    Browse the repository at this point in the history

  37. rustc: collapse Layout::FatPointer into Layout::Univariant.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    026214c View commit details
    Browse the repository at this point in the history

  38. rustc_trans: go through layouts uniformly for fat pointers and variants.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    b723af2 View commit details
    Browse the repository at this point in the history

  39. rustc: move size, align & primitive_align from Abi::Aggregate to layout.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    b28f668 View commit details
    Browse the repository at this point in the history

  40. rustc: collapse the remains of Layout into Variants (enums vs everyth… 

    …ing else).
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    018323f View commit details
    Browse the repository at this point in the history

  41. rustc: support u128 discriminant ranges.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    de3e581 View commit details
    Browse the repository at this point in the history

  42. rustc: make TyLayout::field(NonZero<*T>, 0) return &T.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    abbc1dd View commit details
    Browse the repository at this point in the history

  43. rustc_trans: check for layout::I1 instead of TyBool.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    0190f27 View commit details
    Browse the repository at this point in the history

  44. rustc: generalize layout::Variants::NicheFilling to niches other than 0.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    b203a26 View commit details
    Browse the repository at this point in the history

  45. rustc: remove redundant/unused fields from layout::Abi::Vector.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    5df25c4 View commit details
    Browse the repository at this point in the history

  46. rustc: track validity ranges for layout::Abi::Scalar values.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    f62e43d View commit details
    Browse the repository at this point in the history

  47. rustc: optimize out uninhabited types and variants.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    ced5e04 View commit details
    Browse the repository at this point in the history

  48. rustc_trans: compute better align/dereferenceable attributes from poi… 

    …ntees.
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    f8d5d0c View commit details
    Browse the repository at this point in the history

  49. rustc_trans: generate LLVM pointee types based on alignment.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    ac60872 View commit details
    Browse the repository at this point in the history

  50. rustc_trans: restrict "immediate pairs" to pairs of scalars.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    f1b7cd9 View commit details
    Browse the repository at this point in the history

  51. rustc: encode scalar pairs in layout ABI.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    cdeb4b0 View commit details
    Browse the repository at this point in the history

  52. rustc: place ZSTs first during struct field reordering.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    c4d9ada View commit details
    Browse the repository at this point in the history

  53. rustc_trans: be more relaxed with non-lvalue consumes, especially ZSTs.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    0b86972 View commit details
    Browse the repository at this point in the history

  54. rustc: unpack scalar newtype layout ABIs.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    37a7521 View commit details
    Browse the repository at this point in the history

  55. rustc: unpack scalar pair newtype layout ABIs.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    7a36141 View commit details
    Browse the repository at this point in the history

  56. rustc_trans: support scalar pairs directly in the Rust ABI.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    18ecc56 View commit details
    Browse the repository at this point in the history

  57. rustc: don't special-case Box<T> as having a pointer layout.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    fa67abd View commit details
    Browse the repository at this point in the history

  58. rustc_trans: remove type_is_fat_ptr and its uses.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    801a1a0 View commit details
    Browse the repository at this point in the history

  59. rustc: use layout::Abi::ScalarPair for structs in more cases.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    d893285 View commit details
    Browse the repository at this point in the history

  60. rustc: extend the niche-filling enum optimization past 2 variants.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    8437d7c View commit details
    Browse the repository at this point in the history

  61. rustc: rename CachedLayout to LayoutDetails.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    753d582 View commit details
    Browse the repository at this point in the history

  62. rustc_trans: (hack) use preferred alignment for atomic loads/stores.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    95687bf View commit details
    Browse the repository at this point in the history

  63. Don't glob-import overlapping variant names in test/codegen/match-opt… 

    …imizes-away.rs.
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    fb83283 View commit details
    Browse the repository at this point in the history

  64. cargotest: temporarily use eddyb/servo to include servo/servo#19285.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    b0812de View commit details
    Browse the repository at this point in the history

  65. rustc_trans: work around i686-pc-windows-msvc byval align LLVM bug.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    88e4d2c View commit details
    Browse the repository at this point in the history

  66. rustc_trans: remove primitive_align optimization.

    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    89e4373 View commit details
    Browse the repository at this point in the history

  67. Revert "tests: Update run-make/issue-25581 to reflect how fat pointer… 

    …s are passed."

This reverts commit b12dcde.
    @eddyb
    eddyb committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    f9f5ab9 View commit details
    Browse the repository at this point in the history