Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the line and column fields from the proc_macro::LineColumn struct #46690

Merged
merged 1 commit into from
Dec 15, 2017
Merged

Expose the line and column fields from the proc_macro::LineColumn struct #46690

merged 1 commit into from
Dec 15, 2017

Conversation

mystor
Copy link
Contributor

@mystor mystor commented Dec 12, 2017

Right now the LineColumn struct is pretty useless because the fields are private.

This patch just marks the fields as public, which seems like the easiest solution.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@mystor
Copy link
Contributor Author

mystor commented Dec 12, 2017

r? @jseyfried

@rust-highfive rust-highfive assigned jseyfried and unassigned aturon Dec 12, 2017
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2017
@jseyfried
Copy link
Contributor

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented Dec 12, 2017

📌 Commit 0ccf1af has been approved by jseyfried

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2017
@bors
Copy link
Contributor

bors commented Dec 13, 2017

⌛ Testing commit 0ccf1af with merge 0462c855c9d4df145fe944b5d23b77450a8be4ee...

@kennytm
Copy link
Member

kennytm commented Dec 13, 2017

@bors treeclosed=2

Some crosstool link is dead, closing the tree for a moment for investigation.

@bors
Copy link
Contributor

bors commented Dec 13, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Dec 13, 2017

@bors retry — http://crosstool-ng.org was down.

@kennytm
Copy link
Member

kennytm commented Dec 14, 2017

@bors rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Dec 15, 2017
@steveklabnik
Rollup merge of rust-lang#46690 - mystor:pub_line_column, r=jseyfried
1375be8 
Expose the line and column fields from the proc_macro::LineColumn struct

Right now the `LineColumn` struct is pretty useless because the fields are private.

This patch just marks the fields as public, which seems like the easiest solution.
@steveklabnik steveklabnik mentioned this pull request Dec 15, 2017
Merged
bors added a commit that referenced this pull request Dec 15, 2017
@bors
Auto merge of #46745 - steveklabnik:rollup, r=steveklabnik
50f6c3e 
Rollup of 7 pull requests

- Successful merges: #46601, #46652, #46690, #46705, #46710, #46728, #46737
- Failed merges:
@bors bors merged commit 0ccf1af into rust-lang:master Dec 15, 2017
@mystor mystor mentioned this pull request Dec 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jseyfried jseyfried

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mystor @rust-highfive @jseyfried @bors @kennytm @aturon