Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLL test for mutating &mut references #47609

Merged
merged 2 commits into from
Jan 25, 2018

Conversation

ritiek
Copy link
Member

@ritiek ritiek commented Jan 20, 2018

As mentioned in #46361.

cc @nikomatsakis?

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

r? @nikomatsakis

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 20, 2018
@matthewjasper
Copy link
Contributor

Should this be replacing this test?

@nikomatsakis
Copy link
Contributor

Hmm, yes, a good point! Maybe we already had the test? I like how this test actually runs the result, though.

@ritiek care to merge the two tests?

@ritiek
Copy link
Member Author

ritiek commented Jan 23, 2018

Sure! Where should we keep the merged test though? src/test/run-pass/nll/mutating_references.rs or src/test/run-pass/borrowck/borrowck-nll-iterating-and-updating.rs?

@nikomatsakis
Copy link
Contributor

@ritiek I prefer the nll directory for now, I think

@ritiek
Copy link
Member Author

ritiek commented Jan 23, 2018

OK. So now we have the merged test in src/test/run-pass/nll/mutating_references.rs.

@nikomatsakis
Copy link
Contributor

@bors r+

@ritiek great!

@bors
Copy link
Contributor

bors commented Jan 23, 2018

📌 Commit 06d123d has been approved by nikomatsakis

@nikomatsakis
Copy link
Contributor

@bors rollup

@nikomatsakis nikomatsakis added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2018
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 25, 2018
…nikomatsakis

NLL test for mutating &mut references

As mentioned in rust-lang#46361.

cc @nikomatsakis?
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 25, 2018
…nikomatsakis

NLL test for mutating &mut references

As mentioned in rust-lang#46361.

cc @nikomatsakis?
bors added a commit that referenced this pull request Jan 25, 2018
Rollup of 10 pull requests

- Successful merges: #47534, #47609, #47679, #47691, #47700, #47702, #47717, #47721, #47726, #47729
- Failed merges:
@bors bors merged commit 06d123d into rust-lang:master Jan 25, 2018
@ritiek ritiek deleted the test-mutating-references branch February 13, 2018 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants