Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage of use_nested_groups #47853

Merged
merged 1 commit into from
Jan 30, 2018

Conversation

pietroalbini
Copy link
Member

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@pietroalbini
Copy link
Member Author

cc #44494

@nikomatsakis
Copy link
Contributor

Awesome! Thanks.

@bors r+

@bors
Copy link
Contributor

bors commented Jan 29, 2018

📌 Commit 8389b66 has been approved by nikomatsakis

@kennytm
Copy link
Member

kennytm commented Jan 29, 2018

@bors rollup

@nikomatsakis nikomatsakis added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 29, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Jan 29, 2018
…st-coverage, r=nikomatsakis

Increase test coverage of use_nested_groups

r? @nikomatsakis
kennytm added a commit to kennytm/rust that referenced this pull request Jan 30, 2018
…st-coverage, r=nikomatsakis

Increase test coverage of use_nested_groups

r? @nikomatsakis
bors added a commit that referenced this pull request Jan 30, 2018
Rollup of 12 pull requests

- Successful merges: #47515, #47603, #47718, #47732, #47760, #47780, #47822, #47826, #47836, #47839, #47853, #47855
- Failed merges:
@bors bors merged commit 8389b66 into master Jan 30, 2018
@pietroalbini pietroalbini deleted the increase-nested-groups-test-coverage branch January 30, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants