Rollup of 8 pull requests #48294
Merged
Rollup of 8 pull requests #48294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GuillaumeGomez
commented
Feb 17, 2018
GuillaumeGomez
commented
- Successful merges: add unit tests for rustdoc's processing of doctests #48095, Primitive docs relevant #48152, Remove "empty buffer" doc in read_until #48234, Fix condvar example #48239, spelling fix in comment #48243, [doc] Add link to yield_now #48260, Remove unneeded string allocations #48284, Clarify contiguity of Vec's elements. #48286
- Failed merges:
This appears copied from fill_buf, but the above paragraph already indicates that a lack of delimiter at the end is EOF.
…=GuillaumeGomez add unit tests for rustdoc's processing of doctests cc rust-lang#42018 There's a lot of things that rustdoc will do to massage doctests into something that can be compiled, and a lot of options that can be toggled to affect this. Hopefully this list of tests can show off that functionality. The first commit is slightly unrelated but doesn't touch public functionality, because i found that if you have a manual `fn main`, it adds an extra line break at the end, whereas it would trim this extra line break if it were putting a `fn main` in automatically. That first commit makes it trim out that whitespace ahead of time.
…uietMisdreavus Primitive docs relevant This fixes the documentation to show the right types in the examples for many integer methods. I need to check if the result is correct before we merge.
Remove "empty buffer" doc in read_until This appears copied from fill_buf, but the above paragraph already indicates that a lack of delimiter at the end is EOF.
… r=QuietMisdreavus Fix condvar example Fixes rust-lang#48230. r? @QuietMisdreavus
…ennytm spelling fix in comment r? @Manishearth
[doc] Add link to yield_now A convenient link.
Remove unneeded string allocations
Clarify contiguity of Vec's elements. Small doc changes for clarity.
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ p=8 |
|
📌 Commit 47db61a has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Feb 17, 2018
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.