Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AArch64 features to whitelist #48570

Merged
merged 2 commits into from
Mar 2, 2018
Merged

Add AArch64 features to whitelist #48570

merged 2 commits into from
Mar 2, 2018

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Feb 27, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2018
@alexcrichton
Copy link
Member

r=me, thanks!

Looks like there's a travis failure though?

@Amanieu Amanieu force-pushed the aarch64_features branch 2 times, most recently from 7fdc596 to 3e2c81c Compare February 27, 2018 04:35
@Amanieu
Copy link
Member Author

Amanieu commented Feb 27, 2018

It should be fixed now.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 27, 2018

📌 Commit 3e2c81c has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2018
@gnzlbg
Copy link
Contributor

gnzlbg commented Feb 27, 2018

LGTM. We spoke about this on IRC and doing the same thing that clang and gcc do is the only reasonable thing that can be done here for the time being. If we ever get a backend with finer-grained control we can always add finer-grained features.

Run-time feature detection would need to some of these as a bundle in stdsimd but that can be done.

@kennytm kennytm mentioned this pull request Feb 27, 2018
Closed
@alexcrichton
Copy link
Member

@bors: rollup

@kennytm kennytm mentioned this pull request Feb 28, 2018
Merged
@bors
Copy link
Contributor

bors commented Feb 28, 2018

☔ The latest upstream changes (presumably #48608) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 28, 2018
@Amanieu
Remove the v7 feature from AArch64
90b2813 
It isn't a valid LLVM feature for this architecture.
@Amanieu
Add AArch64 features
f756ad3
@Amanieu
Copy link
Member Author

Amanieu commented Feb 28, 2018

Fixed merge conflict.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 28, 2018

📌 Commit f756ad3 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 28, 2018
@Manishearth Manishearth mentioned this pull request Feb 28, 2018
Merged
bors added a commit that referenced this pull request Feb 28, 2018
@bors
Auto merge of #48615 - Manishearth:rollup, r=Manishearth
0e3c9bb 
Rollup of 10 pull requests

- Successful merges: #48355, #48359, #48380, #48419, #48420, #48461, #48522, #48570, #48572, #48603
- Failed merges:
@Manishearth Manishearth mentioned this pull request Mar 1, 2018
Closed
Manishearth pushed a commit to Manishearth/rust that referenced this pull request Mar 1, 2018
@kennytm @Manishearth
Rollup merge of rust-lang#48570 - Amanieu:aarch64_features, r=alexcri…
2b3c815 
…chton

Add AArch64 features to whitelist
@Manishearth Manishearth mentioned this pull request Mar 2, 2018
Merged
@bors bors merged commit f756ad3 into rust-lang:master Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Amanieu @alexcrichton @bors @gnzlbg @rust-highfive