Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for #48551 #48610

Merged
merged 2 commits into from
Mar 2, 2018
Merged

Add regression test for #48551 #48610

merged 2 commits into from
Mar 2, 2018

Conversation

ishitatsuyuki
Copy link
Contributor

@ishitatsuyuki ishitatsuyuki commented Feb 28, 2018 •
edited
Loading

@ishitatsuyuki
Copy link
Contributor Author

r? @nikomatsakis

@ishitatsuyuki ishitatsuyuki added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 28, 2018
varkor
varkor reviewed Feb 28, 2018
View reviewed changes
src/test/run-pass/issue-48551.rs Outdated
@@ -0,0 +1,40 @@
// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It's 2018.

@nikomatsakis
Copy link
Contributor

@bors r+

@ishitatsuyuki -- I added a comment to explain the purpose of the test, which is often useful later on =)

@bors
Copy link
Contributor

bors commented Feb 28, 2018

📌 Commit 11eb83a has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2018
@Manishearth Manishearth mentioned this pull request Mar 1, 2018
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 1, 2018
@Manishearth
Rollup merge of rust-lang#48610 - ishitatsuyuki:ishitatsuyuki-patch-1…
cf0638c 
…, r=nikomatsakis

Add regression test for rust-lang#48551

[Issue link](rust-lang#48551)
@Manishearth Manishearth mentioned this pull request Mar 2, 2018
Merged
@bors bors merged commit 11eb83a into rust-lang:master Mar 2, 2018
@ishitatsuyuki ishitatsuyuki deleted the ishitatsuyuki-patch-1 branch July 15, 2018 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varkor varkor varkor left review comments

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ishitatsuyuki @nikomatsakis @bors @varkor