-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 14 pull requests #49939
Rollup of 14 pull requests #49939
Commits on Mar 28, 2018
-
Add docs for the test crate with the std docs
If the compiler docs aren't going to include the test crate then it may as well be included with std.
Configuration menu - View commit details
-
Copy full SHA for e719bb0 - Browse repository at this point
Copy the full SHA e719bb0View commit details
Commits on Apr 10, 2018
-
proc_macro: Avoid cached TokenStream more often
This commit adds even more pessimization to use the cached `TokenStream` inside of an AST node. As a reminder the `proc_macro` API requires taking an arbitrary AST node and transforming it back into a `TokenStream` to hand off to a procedural macro. Such functionality isn't actually implemented in rustc today, so the way `proc_macro` works today is that it stringifies an AST node and then reparses for a list of tokens. This strategy unfortunately loses all span information, so we try to avoid it whenever possible. Implemented in rust-lang#43230 some AST nodes have a `TokenStream` cache representing the tokens they were originally parsed from. This `TokenStream` cache, however, has turned out to not always reflect the current state of the item when it's being tokenized. For example `#[cfg]` processing or macro expansion could modify the state of an item. Consequently we've seen a number of bugs (rust-lang#48644 and rust-lang#49846) related to using this stale cache. This commit tweaks the usage of the cached `TokenStream` to compare it to our lossy stringification of the token stream. If the tokens that make up the cache and the stringified token stream are the same then we return the cached version (which has correct span information). If they differ, however, then we will return the stringified version as the cache has been invalidated and we just haven't figured that out. Closes rust-lang#48644 Closes rust-lang#49846
Configuration menu - View commit details
-
Copy full SHA for 6d7cfd4 - Browse repository at this point
Copy the full SHA 6d7cfd4View commit details
Commits on Apr 11, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 43301e5 - Browse repository at this point
Copy the full SHA 43301e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34956c8 - Browse repository at this point
Copy the full SHA 34956c8View commit details -
Ignore copyright year when generating deriving span tests
Previously, generate-deriving-span-tests.py would regenerate all the tests anew, even if they hadn't changed. This creates unnecessary diffs that only change the copyright year. Now we check to see if any of the content of the test has changed before generating the new one.
Configuration menu - View commit details
-
Copy full SHA for 0b393e0 - Browse repository at this point
Copy the full SHA 0b393e0View commit details
Commits on Apr 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 6f10146 - Browse repository at this point
Copy the full SHA 6f10146View commit details -
Configuration menu - View commit details
-
Copy full SHA for de34533 - Browse repository at this point
Copy the full SHA de34533View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f60341 - Browse repository at this point
Copy the full SHA 2f60341View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3366032 - Browse repository at this point
Copy the full SHA 3366032View commit details
Commits on Apr 13, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 35087fc - Browse repository at this point
Copy the full SHA 35087fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b744e3d - Browse repository at this point
Copy the full SHA b744e3dView commit details -
This includes rust-lang/cargo#5353, which we might want to test via opt-in in the wild
Configuration menu - View commit details
-
Copy full SHA for 6c7d3a1 - Browse repository at this point
Copy the full SHA 6c7d3a1View commit details -
Use InternedString rather than Name for RegionParameterDef
This makes it consistent with TypeParameterDef.
Configuration menu - View commit details
-
Copy full SHA for 6234d41 - Browse repository at this point
Copy the full SHA 6234d41View commit details -
Configuration menu - View commit details
-
Copy full SHA for d015945 - Browse repository at this point
Copy the full SHA d015945View commit details -
Cleanup liballoc use statements
Some modules were still using the deprecated `allocator` module, use the `alloc` module instead. Some modules were using `super` while it's not needed. Some modules were more or less ordering them, and other not, so the latter have been modified to match the others.
Configuration menu - View commit details
-
Copy full SHA for bd9ff84 - Browse repository at this point
Copy the full SHA bd9ff84View commit details
Commits on Apr 14, 2018
-
Rollup merge of rust-lang#49951 - matklad:update-cargo, r=nrc
Update Cargo This includes rust-lang/cargo#5353, which we want to test via opt-in in the wild. This'll break RLS, the fix is rust-lang/rls#822
Configuration menu - View commit details
-
Copy full SHA for fbbc990 - Browse repository at this point
Copy the full SHA fbbc990View commit details -
Rollup merge of rust-lang#49852 - alexcrichton:fix-more-proc-macros, …
…r=nrc proc_macro: Avoid cached TokenStream more often This commit adds even more pessimization to use the cached `TokenStream` inside of an AST node. As a reminder the `proc_macro` API requires taking an arbitrary AST node and transforming it back into a `TokenStream` to hand off to a procedural macro. Such functionality isn't actually implemented in rustc today, so the way `proc_macro` works today is that it stringifies an AST node and then reparses for a list of tokens. This strategy unfortunately loses all span information, so we try to avoid it whenever possible. Implemented in rust-lang#43230 some AST nodes have a `TokenStream` cache representing the tokens they were originally parsed from. This `TokenStream` cache, however, has turned out to not always reflect the current state of the item when it's being tokenized. For example `#[cfg]` processing or macro expansion could modify the state of an item. Consequently we've seen a number of bugs (rust-lang#48644 and rust-lang#49846) related to using this stale cache. This commit tweaks the usage of the cached `TokenStream` to compare it to our lossy stringification of the token stream. If the tokens that make up the cache and the stringified token stream are the same then we return the cached version (which has correct span information). If they differ, however, then we will return the stringified version as the cache has been invalidated and we just haven't figured that out. Closes rust-lang#48644 Closes rust-lang#49846
Configuration menu - View commit details
-
Copy full SHA for 95b7e6f - Browse repository at this point
Copy the full SHA 95b7e6fView commit details -
Rollup merge of rust-lang#49866 - Mark-Simulacrum:pr-travis-windows, …
…r=alexcrichton Cross-compile builder to Windows for PRs on Travis I chose a completely arbitrary windows target here (I have no idea what's best, we could do multiple -- they are relatively fast).
Configuration menu - View commit details
-
Copy full SHA for 642bcc4 - Browse repository at this point
Copy the full SHA 642bcc4View commit details -
Rollup merge of rust-lang#49876 - oli-obk:no_secret_clippy_on_stable_…
…☹, r=nrc Don't inject clippy into rls on stable/beta as discussed at the all-hands
Configuration menu - View commit details
-
Copy full SHA for c22b4db - Browse repository at this point
Copy the full SHA c22b4dbView commit details -
Rollup merge of rust-lang#49465 - ollie27:rustbuild_test_docs, r=stev…
…eklabnik,QuietMisdreavus,frewsxcv,GuillaumeGomez Add docs for the test crate with the std docs If the compiler docs aren't going to include the test crate then it may as well be included with std. Fixes rust-lang#49388
Configuration menu - View commit details
-
Copy full SHA for 15eb465 - Browse repository at this point
Copy the full SHA 15eb465View commit details -
Rollup merge of rust-lang#49886 - varkor:generate-deriving-span-tests…
…-usability, r=nikomatsakis Ignore copyright year when generating deriving span tests Previously, generate-deriving-span-tests.py would regenerate all the tests anew, even if they hadn't changed. This creates unnecessary diffs that only change the copyright year. Now we check to see if any of the content of the test has changed before generating the new one.
Configuration menu - View commit details
-
Copy full SHA for 070a771 - Browse repository at this point
Copy the full SHA 070a771View commit details -
Rollup merge of rust-lang#49908 - chrisccoulson:fix-rustdoc-themes-te…
…st-without-rpath, r=Mark-Simulacrum Fix test failure in src/tools/rustdoc-themes when rust.rpath = false See rust-lang#49907
Configuration menu - View commit details
-
Copy full SHA for 44a71e2 - Browse repository at this point
Copy the full SHA 44a71e2View commit details -
Rollup merge of rust-lang#49913 - varkor:RegionParameterDef-InternedS…
…tring, r=petrochenkov Use InternedString rather than Name for RegionParameterDef This makes it consistent with `TypeParameterDef`.
Configuration menu - View commit details
-
Copy full SHA for 6f629d3 - Browse repository at this point
Copy the full SHA 6f629d3View commit details -
Rollup merge of rust-lang#49915 - llogiq:doc-shift-types, r=joshtriplett
[doc] note the special type inference handling for shift ops This adds a note to the docs about the difference between the shift ops and the corresponding trait methods when it comes to type inference.
Configuration menu - View commit details
-
Copy full SHA for d21433e - Browse repository at this point
Copy the full SHA d21433eView commit details -
Rollup merge of rust-lang#49916 - llogiq:doc-atomic-fetch-update, r=k…
…ennytm improve Atomic*::fetch_update docs This clarifies that fetch_update *always* returns the previous value, either as `Ok(_)` or `Err(_)`, depending on whether the supplied update function returned `Some(_)` or `None`.
Configuration menu - View commit details
-
Copy full SHA for 31906e4 - Browse repository at this point
Copy the full SHA 31906e4View commit details -
Rollup merge of rust-lang#49922 - f-bro:zmiri, r=oli-obk
Remove -Zmiri debugging option
Configuration menu - View commit details
-
Copy full SHA for e681ba2 - Browse repository at this point
Copy the full SHA e681ba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c8e9b9 - Browse repository at this point
Copy the full SHA 4c8e9b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e35499c - Browse repository at this point
Copy the full SHA e35499cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4472991 - Browse repository at this point
Copy the full SHA 4472991View commit details -
Rollup merge of rust-lang#49958 - glandium:cleanup, r=SimonSapin
Cleanup liballoc use statements Some modules were still using the deprecated `allocator` module, use the `alloc` module instead. Some modules were using `super` while it's not needed. Some modules were more or less ordering them, and other not, so the latter have been modified to match the others.
Configuration menu - View commit details
-
Copy full SHA for 9659f05 - Browse repository at this point
Copy the full SHA 9659f05View commit details -
Rollup merge of rust-lang#49871 - SimonSapin:int-bytes, r=sfackler
Add to_bytes and from_bytes to primitive integers Discussion issue turned tracking issue: rust-lang#49792
Configuration menu - View commit details
-
Copy full SHA for 709ec40 - Browse repository at this point
Copy the full SHA 709ec40View commit details -
Rollup merge of rust-lang#49864 - QuietMisdreavus:doctest-target-feat…
…ures, r=GuillaumeGomez add target features when extracting and running doctests When rendering documentation, rustdoc will happily load target features into the cfg environment from the current target, but fails to do this when doing anything with doctests. This would lead to situations where, thanks to rust-lang#48759, functions tagged with `#[target_feature]` couldn't run doctests, thanks to the automatic `#[doc(cfg(target_feature = "..."))]`. Currently, there's no way to pass codegen options to rustdoc that will affect its rustc sessions, but for now this will let you use target features that come default on the platform you're targeting. Fixes rust-lang#49723
Configuration menu - View commit details
-
Copy full SHA for 0e9d6f9 - Browse repository at this point
Copy the full SHA 0e9d6f9View commit details