Update compiler test documentation #52955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
requested changes
Aug 6, 2018
src/test/COMPILER_TESTS.md
Outdated
| @@ -53,6 +53,7 @@ be compiled or run. | |||
| * `ignore-pretty` will not compile the pretty-printed test (this is done to test the pretty-printer, but might not always work) | |||
| * `ignore-test` always ignores the test | |||
| * `ignore-lldb` and `ignore-gdb` will skip a debuginfo test on that debugger. | |||
| * `ignore-gdb-version` can be used to ignore the test when certain gdb versions are used | |||
There was a problem hiding this comment.
hmm I feel like this document ought to be removed and just become a pointer to
https://rust-lang-nursery.github.io/rustc-guide/tests/intro.html
(cc @mark-i-m, thoughts?)
There was a problem hiding this comment.
and this PR would be resubmitted at rustc-guide, natch
There was a problem hiding this comment.
I agree, but first we should add any additional content from here to the guide
There was a problem hiding this comment.
is there anything in here that is not present in the guide? I guess we have to check
There was a problem hiding this comment.
I looked and the guide seems like a superset of what's in this file.
nikomatsakis
added
S-waiting-on-author
|
Merged. @tromey would you object to repurposing this PR to make this a "soft link" over to the guide? |
|
Not at all, I'll do it soon. |
Update the compiler test documentation to point to the relevant rustc-guide page.
tromey
force-pushed
the
compiler-test-docs
branch
from
a97cb02
to
8a76656
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
I don't think that failure is related to this patch. |
|
@bors r+ rollup |
|
📌 Commit 8a76656 has been approved by |
bors
added
S-waiting-on-bors
|
bors relabeled this as waiting on me, but I don't understand what I am supposed to do. |
|
Thanks :) |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Aug 11, 2018
…tsakis Update compiler test documentation Update the compiler test documentation to document ignore-gdb-version and min-system-llvm-version; and expand the min-gdb-version, min-lldb-version, and min-llvm-version documentation a little.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 12, 2018
…tsakis Update compiler test documentation Update the compiler test documentation to document ignore-gdb-version and min-system-llvm-version; and expand the min-gdb-version, min-lldb-version, and min-llvm-version documentation a little.
bors
added a commit
that referenced
this pull request
Aug 12, 2018
Rollup of 15 pull requests Successful merges: - #52955 (Update compiler test documentation) - #53019 (Don't collect() when size_hint is useless) - #53025 (Consider changing assert! to debug_assert! when it calls visit_with) - #53059 (Remove explicit returns where unnecessary) - #53165 ( Add aarch64-unknown-netbsd target) - #53210 (Deny future duplication of rustc-ap-syntax) - #53223 (A few cleanups for rustc_data_structures) - #53230 ([nll] enable feature(nll) on various crates for bootstrap: part 4) - #53231 (Add let keyword doc) - #53240 (Add individual documentation for <integer>`.swap_bytes`/.`reverse_bits`) - #53253 (Remove unwanted console log) - #53264 (Show that Command can be reused and remodified) - #53267 (Fix styles) - #53273 (Add links to std::char::REPLACEMENT_CHARACTER from docs.) - #53283 (wherein we suggest float for integer literals where a float was expected) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the compiler test documentation to document ignore-gdb-version
and min-system-llvm-version; and expand the min-gdb-version,
min-lldb-version, and min-llvm-version documentation a little.