Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy: Stop requiring a license header #53617

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

joshtriplett
Copy link
Member

Previously approved in #43498 ; update tidy to match.

Previously approved in rust-lang#43498 ; update tidy to match.
@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2018
@Mark-Simulacrum
Copy link
Member

Do we want to eventually clean these out from all the files? It'd potentially be a nice win for disk space especially for tests and the like.

@Mark-Simulacrum
Copy link
Member

cc @rust-lang/compiler @rust-lang/core for awareness

@bors r+

@bors
Copy link
Contributor

bors commented Aug 22, 2018

📌 Commit a15b617 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2018
@joshtriplett
Copy link
Member Author

joshtriplett commented Aug 22, 2018

@Mark-Simulacrum Eventually, yes. But that has the same potential pitfalls as systematically running rustfmt. :)

(Disk space isn't a very good reason to do it, but ease of code navigation and reading is.)

@Mark-Simulacrum
Copy link
Member

Agreed that disk space isn't a good reason, but I'm not sure I agree the pitfalls are all that bad. In theory, at least, I would expect this to have essentially 0 conflicts since no one is changing those lines, unlike rustfmt. Maybe I don't understand how git works though :)

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mark-i-m
Copy link
Member

I don't think git should complain much here. I don't mind starting on this if there are no objections.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Aug 22, 2018
…, r=Mark-Simulacrum

tidy: Stop requiring a license header

Previously approved in rust-lang#43498 ; update tidy to match.
@joshtriplett
Copy link
Member Author

@Mark-Simulacrum The main annoyance would be that such a change would touch almost every file, making logs and browsing just that little bit more annoying.

But it wouldn't be that bad, true.

@mark-i-m
Copy link
Member

@joshtriplett I submitted #53654. If that looks like a reasonable way to proceed, then I can do more. Let me know.

@mark-i-m
Copy link
Member

Hmm... @bors doesn't appear to be testing anything ATM...

@memoryruins memoryruins mentioned this pull request Aug 24, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Aug 24, 2018
…, r=Mark-Simulacrum

tidy: Stop requiring a license header

Previously approved in rust-lang#43498 ; update tidy to match.
bors added a commit that referenced this pull request Aug 24, 2018
Rollup of 16 pull requests

Successful merges:

 - #53311 (Window Mutex: Document that we properly initialize the SRWLock)
 - #53503 (Discourage overuse of mem::forget)
 - #53545 (Fix #50865: ICE on impl-trait returning functions reaching private items)
 - #53559 (add macro check for lint)
 - #53562 (Lament the invincibility of the Turbofish)
 - #53563 (use String::new() instead of String::from(""), "".to_string(), "".to_owned() or "".into())
 - #53592 (docs: minor stylistic changes to str/string docs)
 - #53594 (Update RELEASES.md to include clippy-preview)
 - #53600 (Fix a grammatical mistake in "expected generic arguments" errors)
 - #53614 (update nomicon and book)
 - #53617 (tidy: Stop requiring a license header)
 - #53618 (Add missing fmt examples)
 - #53636 (Prefer `.nth(n)` over `.skip(n).next()`.)
 - #53644 (Use SmallVec for SmallCStr)
 - #53664 (Remove unnecessary closure in rustc_mir/build/mod.rs)
 - #53666 (Added rustc_codegen_llvm to compiler documentation.)
@bors bors merged commit a15b617 into rust-lang:master Aug 24, 2018
tmiasko added a commit to tmiasko/rust that referenced this pull request Jan 24, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 24, 2020
Remove unused ignore-license directives

The tidy check was removed in rust-lang#53617
@joshtriplett joshtriplett deleted the tidy-no-license-header branch August 24, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants