Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] const eval perf regression fix #53825

Merged
merged 3 commits into from
Aug 31, 2018
Merged

[beta] const eval perf regression fix #53825

merged 3 commits into from
Aug 31, 2018

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Aug 30, 2018

backports #52925 (for #52849)

and additionally skips hashing on every evaluation step

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2018
@oli-obk oli-obk changed the title [beta] [beta] const eval perf regression fix Aug 30, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Aug 30, 2018

r? @RalfJung

@RalfJung
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 30, 2018

📌 Commit 860b257 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Aug 30, 2018

@bors p=1 beta regression fix

@oli-obk
Copy link
Contributor Author

oli-obk commented Aug 30, 2018

@bors r- we don't have official beta nomination yet

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 30, 2018
@RalfJung
Copy link
Member

oops I clearly do not know the process.

r=me when you got the paperwork done. :P

@nikomatsakis
Copy link
Contributor

@bors r=RalfJung

@bors
Copy link
Contributor

bors commented Aug 30, 2018

📌 Commit 860b257 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 30, 2018
@nikomatsakis nikomatsakis mentioned this pull request Aug 30, 2018
Merged
@pietroalbini
Copy link
Member

@bors p=30 (rollup fairness)

@bors
Copy link
Contributor

bors commented Aug 30, 2018

⌛ Testing commit 860b257 with merge b18e0c20f7c90dd93a83bda7f941a7dd20535494...

@bors
Copy link
Contributor

bors commented Aug 30, 2018

💔 Test failed - status-appveyor

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 30, 2018
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Aug 31, 2018

@bors retry (timout on one job, log says "success")

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2018
@bors
Copy link
Contributor

bors commented Aug 31, 2018

⌛ Testing commit 860b257 with merge 1daa912...

bors added a commit that referenced this pull request Aug 31, 2018
@bors
Auto merge of #53825 - oli-obk:beta_backport, r=RalfJung
1daa912 
[beta] const eval perf regression fix

backports #52925 (for #52849)

and additionally skips hashing on every evaluation step
@bors bors mentioned this pull request Aug 31, 2018
Merged
@bors
Copy link
Contributor

bors commented Aug 31, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: RalfJung
Pushing 1daa912 to beta...

@bors bors merged commit 860b257 into rust-lang:beta Aug 31, 2018
@oli-obk oli-obk deleted the beta_backport branch August 31, 2018 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RalfJung RalfJung

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @rust-highfive @RalfJung @bors @nikomatsakis @pietroalbini