Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renumber proc_macro tracking issues #54728

Merged
merged 5 commits into from
Oct 3, 2018

Conversation

alexcrichton
Copy link
Member

Lots of issue links in the compiler still point to #38356 which is a bit of a monster issue that isn't serving much purpose any more. I've split the issue into a number of more fine-grained tracking issues to track stabilizations.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:51:23] .................................................................................................... 2000/4316
[00:51:26] ..................................................................i................................. 2100/4316
[00:51:29] .................................................................................................... 2200/4316
[00:51:32] .................................................................................................... 2300/4316
[00:51:35] ...............iiiiiiiii............................................................................ 2400/4316
[00:51:40] .................................................................................................... 2600/4316
[00:51:44] ...................................................................................................i 2700/4316
[00:51:47] .................................................................................................... 2800/4316
[00:51:50] ...........................................................i.i..ii.................................. 2900/4316
---
travis_time:start:test_codegen
Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:05:46] 
[01:05:46] running 107 tests
[01:05:50] i..ii...iii....i...i.........i..iii...........i.....i....ii...i.i.ii..............i....ii.ii.i....ii 100/107
[01:05:50] test result: ok. 77 passed; 0 failed; 30 ignored; 0 measured; 0 filtered out
[01:05:50] 
[01:05:50]  finished in 3.444
[01:05:50] travis_fold:end:test_codegen
---
travis_time:start:test_ui-fulldeps
Check compiletest suite=ui-fulldeps mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:06:16] 
[01:06:16] running 42 tests
[01:06:51] ............................F......F......
[01:06:51] 
[01:06:51] ---- [ui] ui-fulldeps/proc-macro/multispan.rs stdout ----
[01:06:51] 
[01:06:51] 
[01:06:51] error: auxiliary build of "/checkout/src/test/ui-fulldeps/proc-macro/auxiliary/multispan.rs" failed to compile: 
[01:06:51] status: exit code: 1
[01:06:51] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/proc-macro/auxiliary/multispan.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/proc-macro/multispan/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/proc-macro/multispan/auxiliary"
[01:06:51] ------------------------------------------
[01:06:51] 
[01:06:51] ------------------------------------------
[01:06:51] stderr:
[01:06:51] stderr:
[01:06:51] ------------------------------------------
[01:06:51] {"message":"use of unstable library feature 'proc_macro_def_site' (see issue #54724)","code":{"code":"E0658","explanation":"\nAn unstable feature was used.\n\nErroneous code example:\n\n```compile_fail,E658\n#[repr(u128)] // error: use of unstable library feature 'repr128'\nenum Foo {\n    Bar(u64),\n}\n```\n\nIf you're using a stable or a beta version of rustc, you won't be able to use\nany unstable features. In order to do so, please switch to a nightly version of\nrustc (by using rustup).\n\nIf you're using a nightly version of rustc, just add the corresponding feature\nto be able to use it:\n\n```\n#![feature(repr128)]\n\n#[repr(u128)] // ok!\nenum Foo {\n    Bar(u64),\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/proc-macro/auxiliary/multispan.rs","byte_start":991,"byte_end":1005,"line_start":31,"line_end":31,"column_start":20,"column_end":34,"is_primary":true,"text":[{"text":"        return Err(Span::def_site()","highlight_start":20,"highlight_end":34}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"add #![feature(proc_macro_def_site)] to the crate attributes to enable","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0658]: use of unstable library feature 'proc_macro_def_site' (see issue #54724)\n  --> /checkout/src/test/ui-fulldeps/proc-macro/auxiliary/multispan.rs:31:20\n   |\nLL |         return Err(Span::def_site()\n   |                    ^^^^^^^^^^^^^^\n   |\n   = help: add #![feature(proc_macro_def_site)] to the crate attributes to enable\n\n"}
[01:06:51] {"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error\n\n"}
[01:06:51] {"message":"For more information about this error, try `rustc --explain E0658`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0658`.\n"}
[01:06:51] ------------------------------------------
[01:06:51] 
[01:06:51] thread '[ui] ui-fulldeps/proc-macro/multispan.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3267:9
[01:06:51] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:06:51] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:06:51] 
[01:06:51] ---- [ui] ui-fulldeps/proc-macro/three-equals.rs stdout ----
[01:06:51] 
[01:06:51] error: auxiliary build of "/checkout/src/test/ui-fulldeps/proc-macro/auxiliary/three-equals.rs" failed to compile: 
[01:06:51] status: exit code: 1
[01:06:51] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/proc-macro/auxiliary/three-equals.rs" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/proc-macro/three-equals/auxiliary" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/proc-macro/three-equals/auxiliary"
[01:06:51] ------------------------------------------
[01:06:51] 
[01:06:51] ------------------------------------------
[01:06:51] stderr:
[01:06:51] stderr:
[01:06:51] ------------------------------------------
[01:06:51] {"message":"use of unstable library feature 'proc_macro_def_site' (see issue #54724)","code":{"code":"E0658","explanation":"\nAn unstable feature was used.\n\nErroneous code example:\n\n```compile_fail,E658\n#[repr(u128)] // error: use of unstable library feature 'repr128'\nenum Foo {\n    Bar(u64),\n}\n```\n\nIf you're using a stable or a beta version of rustc, you won't be able to use\nany unstable features. In order to do so, please switch to a nightly version of\nrustc (by using rustup).\n\nIf you're using a nightly version of rustc, just add the corresponding feature\nto be able to use it:\n\n```\n#![feature(repr128)]\n\n#[repr(u128)] // ok!\nenum Foo {\n    Bar(u64),\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/proc-macro/auxiliary/three-equals.rs","byte_start":763,"byte_end":777,"line_start":22,"line_end":22,"column_start":25,"column_end":39,"is_primary":true,"text":[{"text":"    let mut last_span = Span::def_site();","highlight_start":25,"highlight_end":39}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"add #![feature(proc_macro_def_site)] to the crate attributes to enable","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0658]: use of unstable library feature 'proc_macro_def_site' (see issue #54724)\n  --> /checkout/src/test/ui-fulldeps/proc-macro/auxiliary/three-equals.rs:22:25\n   |\nLL |     let mut last_span = Span::def_site();\n   |                         ^^^^^^^^^^^^^^\n   |\n   = help: add #![feature(proc_macro_def_site)] to the crate attributes to enable\n\n"}
[01:06:51] {"message":"use of unstable library feature 'proc_macro_def_site' (see issue #54724)","code":{"code":"E0658","explanation":"\nAn unstable feature was used.\n\nErroneous code example:\n\n```compile_fail,E658\n#[repr(u128)] // error: use of unstable library feature 'repr128'\nenum Foo {\n    Bar(u64),\n}\n```\n\nIf you're using a stable or a beta version of rustc, you won't be able to use\nany unstable features. In order to do so, please switch to a nightly version of\nrustc (by using rustup).\n\nIf you're using a nightly version of rustc, just add the corresponding feature\nto be able to use it:\n\n```\n#![feature(repr128)]\n\n#[repr(u128)] // ok!\nenum Foo {\n    Bar(u64),\n}\n```\n"},"level":"error","spans":[{"file_name":"/checkout/src/test/ui-fulldeps/proc-macro/auxiliary/three-equals.rs","byte_start":1403,"byte_end":1417,"line_start":42,"line_end":42,"column_start":20,"column_end":34,"is_primary":true,"text":[{"text":"        return Err(Span::def_site()","highlight_start":20,"highlight_end":34}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"add #![feature(proc_macro_def_site)] to the crate attributes to enable","code":null,"level":"help","spans":[],"children":[],"rendered":null}],"rendered":"error[E0658]: use of unstable library feature 'proc_macro_def_site' (see issue #54724)\n  --> /checkout/src/test/ui-fulldeps/proc-macro/auxiliary/three-equals.rs:42:20\n   |\nLL |         return Err(Span::def_site()\n   |                    ^^^^^^^^^^^^^^\n   |\n   = help: add #![feature(proc_macro_def_site)] to the crate attributes to enable\n\n"}
[01:06:51] {"message":"aborting due to 2 previous errors","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 2 previous errors\n\n"}
[01:06:51] {"message":"For more information about this error, try `rustc --explain E0658`.","code":null,"level":"","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0658`.\n"}
[01:06:51] ------------------------------------------
[01:06:51] 
[01:06:51] thread '[ui] ui-fulldeps/proc-macro/three-equals.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3267:9
[01:06:51] 
---
[01:06:51] 
[01:06:51] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:499:22
[01:06:51] 
[01:06:51] 
[01:06:51] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-5.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "5.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:06:51] 
[01:06:51] 
[01:06:51] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:06:51] Build completed unsuccessfully in 0:19:46
[01:06:51] Build completed unsuccessfully in 0:19:46
[01:06:51] Makefile:58: recipe for target 'check' failed
[01:06:51] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:1687cd8b
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 1, 2018

📌 Commit 6152144 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2018
@pietroalbini
Copy link
Member

@bors rollup

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Oct 2, 2018
…omatsakis

Renumber `proc_macro` tracking issues

Lots of issue links in the compiler still point to rust-lang#38356 which is a bit of a monster issue that isn't serving much purpose any more. I've split the issue into a number of more fine-grained tracking issues to track stabilizations.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Oct 2, 2018
…omatsakis

Renumber `proc_macro` tracking issues

Lots of issue links in the compiler still point to rust-lang#38356 which is a bit of a monster issue that isn't serving much purpose any more. I've split the issue into a number of more fine-grained tracking issues to track stabilizations.
bors added a commit that referenced this pull request Oct 2, 2018
Rollup of 10 pull requests

Successful merges:

 - #54269 (#53840: Consolidate pattern check errors)
 - #54458 (Allow both explicit and elided lifetimes in the same impl header)
 - #54603 (Add `crate::` to trait suggestions in Rust 2018.)
 - #54648 (Update Cargo's submodule)
 - #54680 (make run-pass tests with empty main just compile-pass tests)
 - #54687 (Use impl_header_lifetime_elision in libcore)
 - #54699 (Re-export `getopts` so custom drivers can reference it.)
 - #54702 (do not promote comparing function pointers)
 - #54728 (Renumber `proc_macro` tracking issues)
 - #54745 (make `CStr::from_bytes_with_nul_unchecked()` a const fn)

Failed merges:

r? @ghost
@bors bors merged commit 6152144 into rust-lang:master Oct 3, 2018
@alexcrichton alexcrichton deleted the renumber-issues branch October 8, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants