Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support type annot in constants, casts #55152

Merged
merged 21 commits into from
Oct 19, 2018
Merged

support type annot in constants, casts #55152

merged 21 commits into from
Oct 19, 2018

Commits on Oct 19, 2018

  1. remove outdated assertion 

    This dates from the days before we instantiated user types with
inference variables.
    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    bd93741 View commit details
    Browse the repository at this point in the history

  2. convert FnDef to TypeOf, which is more general

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    ebdfda6 View commit details
    Browse the repository at this point in the history

  3. propagate user-type annotation for constants in expressions

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    e94959b View commit details
    Browse the repository at this point in the history

  4. replace UserTypeAnnotation::AdtDef with TypeOf

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    a0a3b4c View commit details
    Browse the repository at this point in the history

  5. type_check/mod.rs: rustfmt

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    e7ab33e View commit details
    Browse the repository at this point in the history

  6. pull relate_type_and_user_type code into type_check module 

    It's really layered atop the core "relate-types" code
    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    f99300f View commit details
    Browse the repository at this point in the history

  7. normalize after substitution

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    121f3c8 View commit details
    Browse the repository at this point in the history

  8. normalize and prove predicates 

    Also include a test that was not working previously.
    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    bfb1d95 View commit details
    Browse the repository at this point in the history

  9. suppress duplicate -- or near duplicate -- type test errors

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    e20fa70 View commit details
    Browse the repository at this point in the history

  10. Wrap cast expressions inside of ValueTypeAscription

    @KiChjang @nikomatsakis
    KiChjang authored and nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    80ad300 View commit details
    Browse the repository at this point in the history

  11. create type ascription for any cast 

    Also, avoid shadowing of the `ty` variable by giving the `cast_ty` and
`var_ty` variables different names.  We want to get the user-provided
type from `cast_ty.hir_id`.
    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    2d98e9e View commit details
    Browse the repository at this point in the history

  12. save the user-provided type immediately upon return from astconv

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    ab79cf9 View commit details
    Browse the repository at this point in the history

  13. pacify the mercilous tidy

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    26fdac6 View commit details
    Browse the repository at this point in the history

  14. lowering casts in constants now creates multiple uses 

    This can trigger more errors than before. Not sure what is the best
fix here.
    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    d5d5e8c View commit details
    Browse the repository at this point in the history

  15. skip user-type annotations if they don't have regions

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    a66ab2b View commit details
    Browse the repository at this point in the history

  16. pacify the mercilous tidy

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    02e5a90 View commit details
    Browse the repository at this point in the history

  17. region_infer/mod.rs: rustfmt

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    061c9a2 View commit details
    Browse the repository at this point in the history

  18. add useful debug log

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    820c265 View commit details
    Browse the repository at this point in the history

  19. add a test that we enforce 'static errors post normalization

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    16b3ea1 View commit details
    Browse the repository at this point in the history

  20. even though we don't need it yet, fix the "fast path" code

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    f5cc7db View commit details
    Browse the repository at this point in the history

  21. normalize the self-type that we extract from impl

    @nikomatsakis
    nikomatsakis committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    9a7bb0e View commit details
    Browse the repository at this point in the history