Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update vergen #56583

Merged
merged 1 commit into from
Dec 8, 2018
Merged

update vergen #56583

merged 1 commit into from
Dec 8, 2018

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Dec 7, 2018

Fixes #56576

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 7, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Dec 7, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Dec 7, 2018

📌 Commit 7b80acea5dc0b845efdcc3acc7f5a7a76551d8c7 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2018
@pietroalbini pietroalbini added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Dec 7, 2018
@pietroalbini
Copy link
Member

Nominating for stable and beta backport, otherwise rustc can't be built from source.

@RalfJung
Copy link
Member Author

RalfJung commented Dec 7, 2018

Notice that miri failing to build does not block a release. It is essentially coincidence when a beta is branched off at a time when the miri toolstate was green, and there will likely be releases where miri does not build. I think that's okay, miri is a low-priority nightly-only tool that shouldn't interfere with releases.

I am not even sure if the miri in the 1.31 will build. The PR just fixes the vergen problem, which is unrelated to whether the miri version matches rustc.

@bors
Copy link
Contributor

bors commented Dec 7, 2018

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout vergen (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self vergen --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
warning: Cannot merge binary files: Cargo.lock (HEAD vs. heads/homu-tmp)
Auto-merging Cargo.lock
CONFLICT (content): Merge conflict in Cargo.lock
Automatic merge failed; fix conflicts and then commit the result.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 7, 2018
@RalfJung
Copy link
Member Author

RalfJung commented Dec 7, 2018

Looking at the build log, backporting to beta makes sense:

{"rustfmt":"test-pass","nomicon":"test-pass","rls":"test-pass","clippy-driver":"test-pass","rust-by-example":"test-pass","book":"test-pass","reference":"test-pass","miri":"test-pass"}

but backporting to stable does not because miri would not build anyway:

{"book":"test-pass","reference":"test-pass","clippy-driver":"test-pass","nomicon":"test-pass","rust-by-example":"test-pass","rustfmt":"test-pass","miri":"build-fail","rls":"test-pass"}

@oli-obk
Copy link
Contributor

oli-obk commented Dec 7, 2018

I think we should rather find a way not to build or include clippy miri in the packaged (stable) releases

@RalfJung
Copy link
Member Author

RalfJung commented Dec 7, 2018

@oli-obk you mean miri?

@RalfJung
Copy link
Member Author

RalfJung commented Dec 7, 2018

Rebased. This PR will be a lot of fun. I am taking bets how many rebases will be required ;)

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Dec 7, 2018

📌 Commit f2a6db7 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 7, 2018
@pietroalbini pietroalbini removed beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Dec 7, 2018
@pietroalbini
Copy link
Member

Uh, woops, misread the original issue, this is not critical.

@bors
Copy link
Contributor

bors commented Dec 8, 2018

⌛ Testing commit f2a6db7 with merge 1ccb5b2...

bors added a commit that referenced this pull request Dec 8, 2018
@bors
Copy link
Contributor

bors commented Dec 8, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing 1ccb5b2 to master...

@RalfJung RalfJung deleted the vergen branch January 9, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants