Update the book to fix some edition-related bugs #56615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carols10cents
added
beta-nominated
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
|
Thanks! @bors: r+ rollup |
|
📌 Commit 9d75198 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Dec 8, 2018
Update the book to fix some edition-related bugs I'd love to have this included in a point release if one happens, but the changes aren't worth doing a point release on their own IMO. I'd definitely like to see this backported to beta. The most urgent changes included here are: - Chapter 19.6, on macros (including the macro changes that just stabilized), [is cut off](rust-lang/book#1668) because of an ill-placed newline in a comment that [pulldown-cmark interprets incorrectly](pulldown-cmark/pulldown-cmark#124). - [The `Cargo.toml` shown in the Guessing Game example in Chapter 2 (and one in Chapter 14) doesn't have `edition="2018"`](rust-lang/book#1671), which can be confusing depending on whether the readers have it in theirs or not, think they should remove it if they have it, and the rest of the chapter assumes it's there and the code doesn't compile if you don't have it. - The redirects implemented as part of only shipping the 2018 edition of the book sometimes lead to [having to click through 2 redirect pages](rust-lang/book#1667) when it could be just one. There are other small corrections included that were made since the last time the book was updated, but those aren't urgent. cc @steveklabnik
|
☀️ Test successful - status-appveyor, status-travis |
|
Thanks @GuillaumeGomez! Should I open another PR for backporting to beta, @Mark-Simulacrum ? And are the labels sufficient to get this picked up if a stable point release happens? |
|
@carols10cents The release team will roll this up into both stable and beta backports (beta for sure, stable if indeed we release a point release). However, this PR does need to be marked |
pnkfelix
added
the
A-docs
|
cc @rust-lang/docs, should this PR be backported to beta and stable (1.31.1)? |
Mark-Simulacrum
added
beta-accepted
pietroalbini
removed
the
stable-nominated
|
Based on the issues mentioned in the PR description, i think this should be backported. I know i've seen people get confused by them already. |
pietroalbini
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Dec 18, 2018
[beta] Rollup backports PRs accepted for backport: * #56781: Update LLVM submodule * #56615: Update the book to fix some edition-related bugs * #56562: Update libc version required by rustc * #56282: Fix #56237: normalize type before deferred sizedness checking. * Release notes for Rust 1.31.1 Approved PRs targeting beta: * #56819: [beta] rustdoc: fix line numbers display for [src] pages * #56893: [beta] Revert "Update CI-clang to 7.0.0 for Linux dists." r? @ghost
bors
added a commit
that referenced
this pull request
Dec 18, 2018
[stable] 1.31.1 point release Rust 1.31.1 is scheduled to be released on Thursday 20th, with the following changes: * #56562: Update libc version required by rustc *(different patch made by me)* * #56615: Update the book to fix some edition-related bugs * rls submodule update to [`b379ef7`](rust-lang/rls@b379ef7), including: * rust-lang/rls#1170: Fix for common infinte loop regression * rust-lang/rls#1171: Can't jump to std defs r? @Mark-Simulacrum cc @rust-lang/core @rust-lang/release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd love to have this included in a point release if one happens, but the changes aren't worth doing a point release on their own IMO. I'd definitely like to see this backported to beta.
The most urgent changes included here are:
Cargo.tomlshown in the Guessing Game example in Chapter 2 (and one in Chapter 14) doesn't haveedition="2018", which can be confusing depending on whether the readers have it in theirs or not, think they should remove it if they have it, and the rest of the chapter assumes it's there and the code doesn't compile if you don't have it.There are other small corrections included that were made since the last time the book was updated, but those aren't urgent.
cc @steveklabnik