Add suggestion for duplicated import. #57973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
davidtwco
commented
Jan 29, 2019
estebank
requested changes
Jan 29, 2019
src/test/ui/issues/issue-45799-bad-extern-crate-rename-suggestion-formatting.stderr
Outdated
Show resolved
Hide resolved
| | | ^^^^^^^^^^^^^^^^^^^^^- | ||
| | |_|____________________| | ||
| | | help: remove unnecessary import | ||
| | `derive_a` reimported here |
There was a problem hiding this comment.
Great behavior, although we probably should make sure we keep the #[macro_use] in the remaining extern statement... (not necessary in this PR)
There was a problem hiding this comment.
I've changed this to prefer keeping imports with attributes.
There was a problem hiding this comment.
It didn't seem to work in this case, but only address if you have time.
davidtwco
force-pushed
the
issue-52891
branch
from
20d0eda
to
1bf26e9
Compare
|
r? @estebank if that's OK. |
estebank
reviewed
Jan 30, 2019
estebank
approved these changes
Jan 30, 2019
davidtwco
force-pushed
the
issue-52891
branch
from
1bf26e9
to
2c83c30
Compare
This commit adds a suggestion when a import is duplicated (ie. the same name is used twice trying to import the same thing) to remove the second import.
davidtwco
force-pushed
the
issue-52891
branch
from
2c83c30
to
1595163
Compare
|
@bors r+ |
|
📌 Commit 1595163 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 1595163 with merge 2e4c395588b3a70b13989656af07b08da2be208f... |
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-bors
|
⌛ Testing commit 1595163 with merge c6669166b92ff816adb807f6b4e87bcbfc37aa40... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
Wut @bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Feb 5, 2019
Add suggestion for duplicated import. Fixes #52891. This PR adds a suggestion when a import is duplicated (ie. the same name is used twice trying to import the same thing) to remove the second import.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52891.
This PR adds a suggestion when a import is duplicated (ie. the same name
is used twice trying to import the same thing) to remove the second
import.