Add suggestions to deprecation lints #58002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
zackmdavis
approved these changes
Jan 31, 2019
| @@ -577,7 +579,18 @@ impl<'a, 'gcx, 'tcx> TyCtxt<'a, 'gcx, 'tcx> { | |||
| format!("{}", message) | |||
| }; | |||
|
|
|||
| self.lint_node(lint, id, span, &msg); | |||
| let mut diag = self.struct_span_lint_node(lint, id, span, &msg); | |||
There was a problem hiding this comment.
if only we had a HirId here, we could use struct_span_lint_hir (#50928)
|
r? @zackmdavis @bors r+ |
|
📌 Commit 4056b57 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Feb 1, 2019
Add suggestions to deprecation lints Clippy used to do this suggestion, but the clippy lints happen after the deprecation lints so we ended up never seeing the structured suggestions.
|
☀️ Test successful - checks-travis, status-appveyor |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 26, 2019
add rustfix-able suggestions to trim_{left,right} deprecations
Fixes rust-lang#53802 (technically already fixed by rust-lang#58002, but that issue is about these methods).
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 27, 2019
add rustfix-able suggestions to trim_{left,right} deprecations
Fixes rust-lang#53802 (technically already fixed by rust-lang#58002, but that issue is about these methods).
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 27, 2019
add rustfix-able suggestions to trim_{left,right} deprecations
Fixes rust-lang#53802 (technically already fixed by rust-lang#58002, but that issue is about these methods).
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 27, 2019
add rustfix-able suggestions to trim_{left,right} deprecations
Fixes rust-lang#53802 (technically already fixed by rust-lang#58002, but that issue is about these methods).
cuviper
added a commit
to cuviper/rust
that referenced
this pull request
Mar 28, 2019
add rustfix-able suggestions to trim_{left,right} deprecations
Fixes rust-lang#53802 (technically already fixed by rust-lang#58002, but that issue is about these methods).
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy used to do this suggestion, but the clippy lints happen after the deprecation lints so we ended up never seeing the structured suggestions.