Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embedded book to test such that checktools works #58213

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

Mark-Simulacrum
Copy link
Member

r? @alexcrichton

FWIW this doesn't attempt to make sure we don't break check tools again -- we intentionally make the bash script not exit when x.py fails so we'd need some special case handling so for now I'm just fixing the bug itself, not its cause.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 6, 2019
@Mark-Simulacrum
Copy link
Member Author

Introduced in #56291

@alexcrichton
Copy link
Member

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Feb 7, 2019

📌 Commit 57c9269 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2019
@bors
Copy link
Contributor

bors commented Feb 7, 2019

⌛ Testing commit 57c9269 with merge 55c099e...

bors added a commit that referenced this pull request Feb 7, 2019
Add embedded book to test such that checktools works

r? @alexcrichton

FWIW this doesn't attempt to make sure we don't break check tools again -- we intentionally make the bash script not exit when x.py fails so we'd need some special case handling so for now I'm just fixing the bug itself, not its cause.
@bors
Copy link
Contributor

bors commented Feb 7, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2019
@Mark-Simulacrum
Copy link
Member Author

@bors retry -- timeout(?)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2019
@bors
Copy link
Contributor

bors commented Feb 7, 2019

⌛ Testing commit 57c9269 with merge 9332e5f14a97adcfa50e0ca6eb34e39073400c7a...

@bors
Copy link
Contributor

bors commented Feb 7, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2019
@rust-highfive
Copy link
Collaborator

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Attempting to download s3://rust-lang-ci-sccache2/docker/67db9fe163c5d62355912bb1150078a4fc631df7a03bb9c8df81d8530147e0e964f1a6556efc4d4219ce41c1394f5d8590d0064c6e9685f299201a0fc5db40a6
[00:02:14] Attempting with retry: curl -f -L -C - -o /tmp/rustci_docker_cache https://s3-us-west-1.amazonaws.com/rust-lang-ci-sccache2/docker/67db9fe163c5d62355912bb1150078a4fc631df7a03bb9c8df81d8530147e0e964f1a6556efc4d4219ce41c1394f5d8590d0064c6e9685f299201a0fc5db40a6
[00:02:14]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
[00:02:14]                                  Dload  Upload   Total   Spent    Left  Speed
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum
Copy link
Member Author

@bors retry -- timeout

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2019
@bors
Copy link
Contributor

bors commented Feb 7, 2019

⌛ Testing commit 57c9269 with merge 72184ddeed6e4f17d5d0aa73e6d835725629c11d...

@bors
Copy link
Contributor

bors commented Feb 8, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 8, 2019
@rust-highfive
Copy link
Collaborator

The job dist-x86_64-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:03:44]       Memory: 8 GB
[00:03:44]       Boot ROM Version: VMW71.00V.7581552.B64.1801142334
[00:03:44]       Apple ROM Info: [MS_VM_CERT/SHA1/27d66596a61c48dd3dc7216fd715126e33f59ae7]Welcome to the Virtual Machine
[00:03:44]       SMC Version (system): 2.8f0
[00:03:44]       Serial Number (system): VMSQ9fSRzBxA
[00:03:44] 
[00:03:44] hw.ncpu: 4
[00:03:44] hw.byteorder: 1234
[00:03:44] hw.memsize: 8589934592
---
[02:48:34] [TIMING] Docs { stage: 2, host: "armv7-apple-ios" } -- 80.022
[02:48:34] Dist docs (armv7s-apple-ios)
[02:49:55] [TIMING] Docs { stage: 2, host: "armv7s-apple-ios" } -- 81.081
[02:49:55] Dist docs (i386-apple-ios)
The job exceeded the maximum time limit for jobs, and has been terminated.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Feb 8, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2019
kennytm added a commit to kennytm/rust that referenced this pull request Feb 8, 2019
…lexcrichton

Add embedded book to test such that checktools works

r? @alexcrichton

FWIW this doesn't attempt to make sure we don't break check tools again -- we intentionally make the bash script not exit when x.py fails so we'd need some special case handling so for now I'm just fixing the bug itself, not its cause.
@bors
Copy link
Contributor

bors commented Feb 8, 2019

⌛ Testing commit 57c9269 with merge 652ae3f...

bors added a commit that referenced this pull request Feb 8, 2019
Add embedded book to test such that checktools works

r? @alexcrichton

FWIW this doesn't attempt to make sure we don't break check tools again -- we intentionally make the bash script not exit when x.py fails so we'd need some special case handling so for now I'm just fixing the bug itself, not its cause.
@bors
Copy link
Contributor

bors commented Feb 8, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 652ae3f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 8, 2019
@bors bors merged commit 57c9269 into rust-lang:master Feb 8, 2019
@Mark-Simulacrum Mark-Simulacrum deleted the fix-checktools branch June 8, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants