Hidden suggestion support

[estebank]

Add way to hide suggestion snippet window from cli output to avoid cluttered spans that don't enhance understanding.

r? @pietroalbini CC @zackmdavis

[estebank]

@zackmdavis This PR is to allow @pietroalbini to add a suggestion to remove a few items out of an use statement without cluttering the output with secondary spans that don't add much:

LL | use foo::{bar, qux};
   |              --^^^ unused import
   |              |
   |              help: remove the import

becomes

LL | use foo::{bar, qux};
   |                ^^^ unused import
   = help: remove the import

[zackmdavis]

Looks promising!

[pietroalbini]

Assign this to another person, I'm not expert enough of this part of the codebase to review this PR.

[estebank]

r? @oli-obk

[oli-obk]

The impl Lgtm but I'm not too happy about merging it without using it

[estebank]

@oli-obk It makes sense to wait for #56645 to be merged and then I can rebase and add uses.

[pietroalbini]

#56645 has been merged.

[estebank]

We'll need to update these tests to run rustfix once the rustfix in master can handle these cases, but checking the json output shows that these are correctly exposed. We don't expose the type of suggestion, so tools will not be able to differentiate between the different styles, but I think that is something we can defer on.

[estebank]

@oli-obk added one use of these methods, leaving the other methods in because otherwise it feels incomplete.

@pietroalbini please verify that the new output is what you had in mind. VSCode will still provide the same messages as before.

[pietroalbini]

@pietroalbini please verify that the new output is what you had in mind. VSCode will still provide the same messages as before.

Yep, thanks!

[oli-obk]

@bors r+

[bors]

📌 Commit 87dd2e1 has been approved by oli-obk