Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature gate async methods #60088

Merged
merged 8 commits into from
Apr 21, 2019
Merged

Feature gate async methods #60088

merged 8 commits into from
Apr 21, 2019

Conversation

varkor
Copy link
Member

@varkor varkor commented Apr 18, 2019

Fixes #60069.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2019
@cramertj
Copy link
Member

cramertj commented Apr 18, 2019 •
edited
Loading

@bors r+
@bors r? @cramertj

@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2019
@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Apr 18, 2019

📌 Commit edce367 has been approved by cramertj

@cramertj
Copy link
Member

@bors r? @cramertj

@cramertj cramertj mentioned this pull request Apr 18, 2019
Closed
@Centril Centril mentioned this pull request Apr 18, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
@Centril
Rollup merge of rust-lang#60088 - varkor:async_await-method-feature-g…
f7ffa06 
…ate, r=cramertj

Feature gate async methods

Fixes rust-lang#60069.
@rust-highfive

This comment has been minimized.

Sign in to view
@varkor
Copy link
Member Author

varkor commented Apr 18, 2019

(Forgot to re---bless after fixing a typo.)

@bors r=cramertj

@bors
Copy link
Contributor

bors commented Apr 18, 2019

📌 Commit 3dbe05f has been approved by cramertj

Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
@Centril
Rollup merge of rust-lang#60088 - varkor:async_await-method-feature-g…
e3264bb 
…ate, r=cramertj

Feature gate async methods

Fixes rust-lang#60069.
@Centril Centril mentioned this pull request Apr 18, 2019
Closed
@varkor
Copy link
Member Author

varkor commented Apr 18, 2019

async fn isn't valid in trait methods at the moment, but I realised the existing feature gate was missing a test, so I've added one just to make certain we don't accidentally stabilise something we don't want to.

@bors r=cramertj

@bors
Copy link
Contributor

bors commented Apr 18, 2019

📌 Commit 7548ca6 has been approved by cramertj

Centril added a commit to Centril/rust that referenced this pull request Apr 18, 2019
@Centril
Rollup merge of rust-lang#60088 - varkor:async_await-method-feature-g…
22d9083 
…ate, r=cramertj

Feature gate async methods

Fixes rust-lang#60069.
@Centril Centril mentioned this pull request Apr 18, 2019
Closed
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril
Copy link
Contributor

Centril commented Apr 18, 2019

@bors r-

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 18, 2019
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
@Centril
Rollup merge of rust-lang#60088 - varkor:async_await-method-feature-g…
d6fd895 
…ate, r=cramertj

Feature gate async methods

Fixes rust-lang#60069.
@Centril Centril mentioned this pull request Apr 19, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Apr 19, 2019
@Centril
Rollup merge of rust-lang#60088 - varkor:async_await-method-feature-g…
8ba6c29 
…ate, r=cramertj

Feature gate async methods

Fixes rust-lang#60069.
@Centril Centril mentioned this pull request Apr 19, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Apr 19, 2019

Failed in #60100 (comment), @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 19, 2019
@lnicola
Copy link
Member

lnicola commented Apr 19, 2019 

[00:55:59] - Some errors occurred: E0223, E0599.
[00:55:59] + Some errors have detailed explanations: E0223, E0599.

Looks like the error message needs to be updated for #60046?

@varkor varkor force-pushed the async_await-method-feature-gate branch from bf0965c to ee49605 Compare April 20, 2019 21:32
@varkor
Copy link
Member Author

varkor commented Apr 20, 2019

@lnicola: thanks!

@bors r=cramertj

@bors
Copy link
Contributor

bors commented Apr 20, 2019

📌 Commit ee49605 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 20, 2019
@bors
Copy link
Contributor

bors commented Apr 20, 2019

⌛ Testing commit ee49605 with merge c3a7194...

bors added a commit that referenced this pull request Apr 20, 2019
@bors
Auto merge of #60088 - varkor:async_await-method-feature-gate, r=cram…
c3a7194 
…ertj

Feature gate async methods

Fixes #60069.
@bors
Copy link
Contributor

bors commented Apr 21, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: cramertj
Pushing c3a7194 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 21, 2019
@bors bors merged commit ee49605 into rust-lang:master Apr 21, 2019
This was referenced Apr 21, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cramertj cramertj

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can define and use async fn without feature gate on nightly
7 participants
@varkor @rust-highfive @cramertj @bors @Centril @lnicola @petrochenkov