Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix meta-variable binding errors in macros #62068

Merged
merged 1 commit into from
Jun 23, 2019
Merged

Conversation

ia0
Copy link
Contributor

@ia0 ia0 commented Jun 22, 2019

The errors are either:

  • The meta-variable used in the right-hand side is not bound (or defined) in the
    left-hand side.
  • The meta-variable used in the right-hand side does not repeat with the same
    kleene operator as its binder in the left-hand side. Either it does not repeat
    enough, or it uses a different operator somewhere.

This change should have no semantic impact.

Found by #62008

The errors are either:
- The meta-variable used in the right-hand side is not bound (or defined) in the
  left-hand side.
- The meta-variable used in the right-hand side does not repeat with the same
  kleene operator as its binder in the left-hand side. Either it does not repeat
  enough, or it uses a different operator somewhere.

This change should have no semantic impact.
@rust-highfive
Copy link
Collaborator

r? @TimNN

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2019
@petrochenkov
Copy link
Contributor

Thanks!
r? @petrochenkov @bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 22, 2019

📌 Commit b8106b5 has been approved by petrochenkov

@rust-highfive rust-highfive assigned petrochenkov and unassigned TimNN Jun 22, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2019
Centril added a commit to Centril/rust that referenced this pull request Jun 22, 2019
Fix meta-variable binding errors in macros

The errors are either:
- The meta-variable used in the right-hand side is not bound (or defined) in the
  left-hand side.
- The meta-variable used in the right-hand side does not repeat with the same
  kleene operator as its binder in the left-hand side. Either it does not repeat
  enough, or it uses a different operator somewhere.

This change should have no semantic impact.

Found by rust-lang#62008
bors added a commit that referenced this pull request Jun 23, 2019
Rollup of 5 pull requests

Successful merges:

 - #62047 (Trigger `unused_attribute` lint on `#[cfg_attr($pred,)]`)
 - #62049 (Fix one missing `dyn`.)
 - #62051 (Lint empty `#[derive()]` as unused attribute.)
 - #62057 (Deny explicit_outlives_requirements in the compiler)
 - #62068 (Fix meta-variable binding errors in macros)

Failed merges:

r? @ghost
@bors bors merged commit b8106b5 into rust-lang:master Jun 23, 2019
@ia0 ia0 deleted the fix_meta_var branch June 23, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants