Remove derives `Encodable`/`Decodable` and unstabilize attribute `#[bench]` #62507

petrochenkov · 2019-07-08T21:36:13Z

Encodable and Decodable were deprecated before 1.0 and emitted an unsuppressable warning all this time.
#[bench] is a part of the custom test framework feature and cannot be used meaningfully on stable, only as cfg(false).

Crater results can be found in #62507 (comment) and below.

This PR also reroutes the tracking issue for feature(test) from #27812 (compiler internals) to #50297 (custom test frameworks).

Closes #62048

petrochenkov · 2019-07-08T21:36:29Z

@bors try

bors · 2019-07-08T21:36:40Z

⌛ Trying commit 935c72a with merge 18481b6...

@ghost

[WIP] Feature gate `(Rustc){En,De}codable` and `bench` for crater run cc #62048 r? @ghost

bors · 2019-07-09T00:21:30Z

☀️ Try build successful - checks-azure, checks-travis
Build commit: 18481b6

petrochenkov · 2019-07-09T00:30:09Z

@craterbot run mode=check-only

craterbot · 2019-07-09T00:30:12Z

👌 Experiment pr-62507 created and queued.
🤖 Automatically detected try build 18481b6
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-07-13T11:43:09Z

🚧 Experiment pr-62507 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-07-13T11:43:10Z

🚨 Experiment pr-62507 has encountered an error: docker is not running
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

pietroalbini · 2019-07-13T11:44:16Z

@craterbot retry

craterbot · 2019-07-13T11:44:17Z

🛠️ Experiment pr-62507 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-07-15T06:29:23Z

🚧 Experiment pr-62507 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-07-18T22:50:24Z

🚨 Experiment pr-62507 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

kennytm · 2019-07-19T07:35:36Z

The crater failure seems legit.

petrochenkov · 2019-07-19T09:50:37Z

The previous time (#62008 (comment)) this helped:
@craterbot retry

cc @pietroalbini

craterbot · 2019-07-19T09:50:38Z

🛠️ Experiment pr-62507 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

petrochenkov · 2019-07-19T09:52:30Z

Argh, there's only one crater instance right now, so it won't run for a few days anyway.

kennytm · 2019-07-19T17:26:52Z

The error message should be clearer anyway. "Some threads returned an error" is totally pointless.

craterbot · 2019-07-22T13:42:14Z

🚧 Experiment pr-62507 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2019-07-22T16:14:10Z

🎉 Experiment pr-62507 is completed!
📊 455 regressed and 0 fixed (66894 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

petrochenkov · 2019-07-22T16:51:36Z

RustcDecodable - 418 projects
RustcEncodable - 211 projects
bench - 5 projects
Decodable - 0 projects
Encodable - 0 projects

Ok, it's clear that we

can remove Encodable/Decodable and
cannot remove RustcDecodable/RustcEncodable (but perhaps can deprecate if something like allow(deprecated) is too coarse-grained, should take a path #62398 is implemented).

I'll check how #[bench] is used.

petrochenkov · 2019-07-22T17:12:29Z

#[bench]:

./reg/punkt/1.0.5 - #![cfg_attr(test, feature(test))], other unconditional features, nightly crate
./reg/route-recognizer/0.1.12 - #![cfg_attr(test, feature(test))], no other unconditional features
./reg/triadic-census/0.2.0 - #![cfg_attr(test, feature(test))], no other unconditional features
./reg/beehave/0.0.4 - no features (not sure how this works), part of examples rather than primary code, other unconditional features, nightly crate
./gh/ryan-scott-dev/beehave - duplicate of the previous one

I.e. 2 real stable regressions.
Seems more or less ok to unstabilize, given the unclear plans for custom testing frameworks.

petrochenkov · 2019-07-22T17:23:13Z

I'll implement the deprecation/removal once #62086 lands.

tests: Enable features to fix unstabilized `#[bench]` Needed for rust-lang/rust#62507. (Even if unstabilization of `bench` is reverted later due to fallout, this change should be ok.)

bors · 2019-08-01T04:58:04Z

⌛ Testing commit ef7ef05 with merge 658aa4ab8cb04a108c47e7689c771232ca4e5df1...

Centril · 2019-08-01T04:58:45Z

@bors retry yielding to r0llup.

rust-highfive · 2019-08-01T05:00:24Z

Your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-08-01T04:58:55.7045073Z ##[command]git config gc.auto 0
2019-08-01T04:58:55.7048818Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-01T04:58:55.7051100Z ##[command]git config --get-all http.proxy
2019-08-01T04:58:55.7053400Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin
2019-08-01T04:58:57.0204159Z fatal: remote error: upload-pack: not our ref 658aa4ab8cb04a108c47e7689c771232ca4e5df1
2019-08-01T04:58:57.0299972Z fatal: the remote end hung up unexpectedly
2019-08-01T04:58:57.1388790Z ##[warning]Git fetch failed with exit code 128, back off 7.228 seconds before retry.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

petrochenkov · 2019-08-01T09:37:13Z

@bors retry

bors · 2019-08-01T11:07:34Z

⌛ Testing commit ef7ef05 with merge f23a5f2...

Remove derives `Encodable`/`Decodable` and unstabilize attribute `#[bench]` `Encodable` and `Decodable` were deprecated before 1.0 and emitted an unsuppressable warning all this time. `#[bench]` is a part of the custom test framework feature and cannot be used meaningfully on stable, only as `cfg(false)`. Crater results can be found in #62507 (comment) and below. This PR also reroutes the tracking issue for `feature(test)` from #27812 (compiler internals) to #50297 (custom test frameworks). Closes #62048

bors · 2019-08-01T14:42:54Z

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing f23a5f2 to master...

rust-highfive · 2019-08-01T14:44:12Z

📣 Toolstate changed by #62507!

Tested on commit f23a5f2.
Direct link to PR: #62507

💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra).
💔 rustfmt on windows: test-pass → build-fail (cc @topecongiro, @rust-lang/infra).

@Xanewok

Tested on commit rust-lang/rust@f23a5f2. Direct link to PR: <rust-lang/rust#62507> 💔 rls on windows: test-pass → build-fail (cc @Xanewok, @rust-lang/infra). 💔 rustfmt on windows: test-pass → build-fail (cc @topecongiro, @rust-lang/infra).

Nemo157 · 2019-08-02T14:22:23Z

Breaking route-recognizer with this change is quite annoying, it is depended on by quite a few projects, but doesn't seem to have any active maintenance team. There have been recent attempts to get access to support it better, but as far as I know it's still pretty much abandoned but in use at this point.

rust-lang/rust#62507

@alexcrichton

Give built-in macros stable addresses in the standard library Continuation of rust-lang#62086. Derive macros corresponding to traits from libcore are now available through the same paths as those traits: - `Clone` - `{core,std}::clone::Clone` - `PartialEq` - `{core,std}::cmp::PartialEq` - `Eq` - `{core,std}::cmp::Eq` - `PartialOrd` - `{core,std}::cmp::PartialOrd` - `Ord` - `{core,std}::cmp::Ord` - `Default` - `{core,std}::default::Default` - `Debug` - `{core,std}::fmt::Debug` - `Hash` - `{core,std}::hash::Hash` - `Copy` - `{core,std}::marker::Copy` Fn-like built-in macros are now available through libcore and libstd's root module, by analogy with non-builtin macros defined by libcore and libstd: ```rust {core,std}::{ __rust_unstable_column, asm, assert, cfg, column, compile_error, concat, concat_idents, env, file, format_args, format_args_nl, global_asm, include, include_bytes, include_str, line, log_syntax, module_path, option_env, stringify, trace_macros, } ``` Derive macros without a corresponding trait in libcore or libstd are still available only through prelude (also see rust-lang#62507). Attribute macros also keep being available only through prelude, mostly because they don't have an existing practice to follow. An advice from the library team on their eventual placement would be appreciated. ```rust RustcDecodable, RustcEncodable, bench, global_allocator, test, test_case, ``` r? @alexcrichton

@alexcrichton

Give built-in macros stable addresses in the standard library Continuation of rust-lang#62086. Derive macros corresponding to traits from libcore are now available through the same paths as those traits: - `Clone` - `{core,std}::clone::Clone` - `PartialEq` - `{core,std}::cmp::PartialEq` - `Eq` - `{core,std}::cmp::Eq` - `PartialOrd` - `{core,std}::cmp::PartialOrd` - `Ord` - `{core,std}::cmp::Ord` - `Default` - `{core,std}::default::Default` - `Debug` - `{core,std}::fmt::Debug` - `Hash` - `{core,std}::hash::Hash` - `Copy` - `{core,std}::marker::Copy` Fn-like built-in macros are now available through libcore and libstd's root module, by analogy with non-builtin macros defined by libcore and libstd: ```rust {core,std}::{ __rust_unstable_column, asm, assert, cfg, column, compile_error, concat, concat_idents, env, file, format_args, format_args_nl, global_asm, include, include_bytes, include_str, line, log_syntax, module_path, option_env, stringify, trace_macros, } ``` Derive macros without a corresponding trait in libcore or libstd are still available only through prelude (also see rust-lang#62507). Attribute macros also keep being available only through prelude, mostly because they don't have an existing practice to follow. An advice from the library team on their eventual placement would be appreciated. ```rust RustcDecodable, RustcEncodable, bench, global_allocator, test, test_case, ``` r? @alexcrichton

petrochenkov added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jul 8, 2019

bors added a commit that referenced this pull request Jul 8, 2019

Auto merge of #62507 - petrochenkov:macunstab, r=<try>

18481b6

[WIP] Feature gate `(Rustc){En,De}codable` and `bench` for crater run cc #62048 r? @ghost

petrochenkov mentioned this pull request Jul 8, 2019

Built-in derive macros Encodable, Decodable, RustcEncodable and RustcDecodable are stable #62048

Closed

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jul 22, 2019

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2019

petrochenkov added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2019

bors mentioned this pull request Aug 1, 2019

Rollup of 7 pull requests #63182

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 1, 2019

bors merged commit ef7ef05 into rust-lang:master Aug 1, 2019

bors mentioned this pull request Aug 1, 2019

Centralize panic macro documentation #61511

Closed

rust-highfive mentioned this pull request Aug 1, 2019

rls no longer builds after rust-lang/rust#62507 #63195

Closed

ehuss mentioned this pull request Aug 1, 2019

Undocumented Attributes rust-lang/reference#532

Closed

6 tasks

This was referenced Aug 2, 2019

unable to build on nightly (2019-08-01) iron/iron#613

Closed

unable to build on nightly-2019-08-02 iron/router#148

Closed

vorot93 added a commit to vorot93/route-recognizer.rs that referenced this pull request Aug 5, 2019

Enable feature to fix unstabilized #[bench]

c36c2cc

rust-lang/rust#62507

vorot93 mentioned this pull request Aug 5, 2019

Enable feature to fix unstabilized #[bench] http-rs/route-recognizer#26

Closed

miller-time mentioned this pull request Aug 5, 2019

fix nightly build http-rs/route-recognizer#25

Merged

ehuss mentioned this pull request Aug 22, 2019

[1.38] #[bench] accepted on stable but not beta #63798

Closed

petrochenkov mentioned this pull request Aug 24, 2019

Crater runs for Rust 1.38.0 #63628

Closed

petrochenkov mentioned this pull request Jan 6, 2022

Destabilize RustcEncodable and RustcDecodable #92594

Closed

jhpratt mentioned this pull request Sep 20, 2023

Soft-destabilize RustcEncodable & RustcDecodable, remove from prelude in next edition rust-lang/libs-team#272

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove derives `Encodable`/`Decodable` and unstabilize attribute `#[bench]` #62507

Remove derives `Encodable`/`Decodable` and unstabilize attribute `#[bench]` #62507

petrochenkov commented Jul 8, 2019 •

edited

Loading

petrochenkov commented Jul 8, 2019

bors commented Jul 8, 2019

bors commented Jul 9, 2019

petrochenkov commented Jul 9, 2019

craterbot commented Jul 9, 2019

craterbot commented Jul 13, 2019

craterbot commented Jul 13, 2019

pietroalbini commented Jul 13, 2019

craterbot commented Jul 13, 2019

craterbot commented Jul 15, 2019

craterbot commented Jul 18, 2019

kennytm commented Jul 19, 2019

petrochenkov commented Jul 19, 2019

craterbot commented Jul 19, 2019

petrochenkov commented Jul 19, 2019

kennytm commented Jul 19, 2019

craterbot commented Jul 22, 2019

craterbot commented Jul 22, 2019

petrochenkov commented Jul 22, 2019

petrochenkov commented Jul 22, 2019

petrochenkov commented Jul 22, 2019

bors commented Aug 1, 2019

Centril commented Aug 1, 2019

rust-highfive commented Aug 1, 2019

petrochenkov commented Aug 1, 2019

bors commented Aug 1, 2019

bors commented Aug 1, 2019

rust-highfive commented Aug 1, 2019

Nemo157 commented Aug 2, 2019

Remove derives Encodable/Decodable and unstabilize attribute #[bench] #62507

Remove derives Encodable/Decodable and unstabilize attribute #[bench] #62507

Conversation

petrochenkov commented Jul 8, 2019 • edited Loading

petrochenkov commented Jul 8, 2019

bors commented Jul 8, 2019

bors commented Jul 9, 2019

petrochenkov commented Jul 9, 2019

craterbot commented Jul 9, 2019

craterbot commented Jul 13, 2019

craterbot commented Jul 13, 2019

pietroalbini commented Jul 13, 2019

craterbot commented Jul 13, 2019

craterbot commented Jul 15, 2019

craterbot commented Jul 18, 2019

kennytm commented Jul 19, 2019

petrochenkov commented Jul 19, 2019

craterbot commented Jul 19, 2019

petrochenkov commented Jul 19, 2019

kennytm commented Jul 19, 2019

craterbot commented Jul 22, 2019

craterbot commented Jul 22, 2019

petrochenkov commented Jul 22, 2019

petrochenkov commented Jul 22, 2019

petrochenkov commented Jul 22, 2019

bors commented Aug 1, 2019

Centril commented Aug 1, 2019

rust-highfive commented Aug 1, 2019

petrochenkov commented Aug 1, 2019

bors commented Aug 1, 2019

bors commented Aug 1, 2019

rust-highfive commented Aug 1, 2019

Nemo157 commented Aug 2, 2019

Remove derives `Encodable`/`Decodable` and unstabilize attribute `#[bench]` #62507

Remove derives `Encodable`/`Decodable` and unstabilize attribute `#[bench]` #62507

petrochenkov commented Jul 8, 2019 •

edited

Loading