Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup save-analysis JsonDumper #62979

Merged
merged 2 commits into from
Jul 27, 2019

Conversation

Mark-Simulacrum
Copy link
Member

No description provided.

The Dumper no longer has anything to do specifically with JSON, it
merely represents processing into an `Analysis` output.
@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2019
@Xanewok
Copy link
Member

Xanewok commented Jul 26, 2019

Looks good, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 26, 2019

📌 Commit 68c0ba2 has been approved by Xanewok

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
… r=Xanewok

Cleanup save-analysis JsonDumper
Centril added a commit to Centril/rust that referenced this pull request Jul 26, 2019
… r=Xanewok

Cleanup save-analysis JsonDumper
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 27, 2019
… r=Xanewok

Cleanup save-analysis JsonDumper
Centril added a commit to Centril/rust that referenced this pull request Jul 27, 2019
… r=Xanewok

Cleanup save-analysis JsonDumper
bors added a commit that referenced this pull request Jul 27, 2019
Rollup of 6 pull requests

Successful merges:

 - #62423 (Fix cycle error with existential types)
 - #62979 (Cleanup save-analysis JsonDumper)
 - #62982 (Don't access a static just for its size and alignment)
 - #63013 (add `repr(transparent)` to `IoSliceMut` where missing)
 - #63014 (Stop bare trait lint applying to macro call sites)
 - #63036 (Add lib section to rustc_lexer's Cargo.toml)

Failed merges:

r? @ghost
@bors bors merged commit 68c0ba2 into rust-lang:master Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants