Impl Debug for Chars

[max-sixty]

Closes #62947, making Debug more consistent with the struct's output and purpose

Let me know any feedback!

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[max-sixty]

@hellow554 done

[ollie27]

How about using DebugList with f.debug_list().entries(self.clone()).finish()? For example it would output ['ศ', 'ไ', 'ท', 'ย', '中', '华', 'V', 'i', 'ệ', 't', ' ', 'N', 'a', 'm'] which would match other Debug impls.

[max-sixty]

@ollie27 great, I didn't know about that. Changed

[alexcrichton]

@bors: r+

Thanks @max-sixty!

[bors]

📌 Commit b27f9af17a529c3487df0ae979c783bcd7d8aee3 has been approved by alexcrichton

[bors]

⌛ Testing commit b27f9af17a529c3487df0ae979c783bcd7d8aee3 with merge d71338920d477e0f8ebdcebd6428dd0d26daed64...

[rust-highfive]

Your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-07-29T14:18:57.6623740Z ==============================================================================
2019-07-29T14:18:57.8581860Z Generating script.
2019-07-29T14:18:57.8632620Z ========================== Starting Command Output ===========================
2019-07-29T14:18:57.8688660Z [command]/bin/bash --noprofile --norc /Users/vsts/agent/2.154.3/work/_temp/884a37ae-fa12-45f4-acc8-eaf55bf1ec92.sh
2019-07-29T14:25:09.0448170Z error: RPC failed; curl 18 transfer closed with outstanding read data remaining
2019-07-29T14:25:09.0454620Z fatal: the remote end hung up unexpectedly
2019-07-29T14:25:09.0539710Z Error: Fetching /usr/local/Homebrew/Library/Taps/homebrew/homebrew-cask failed!
2019-07-29T14:25:14.3017690Z   https://github.com/Homebrew/brew#donations
2019-07-29T14:25:42.1321900Z Updated 2 taps (caskroom/versions and homebrew/core).
2019-07-29T14:25:42.1322900Z ==> New Formulae
2019-07-29T14:25:42.1323450Z asyncplusplus
---
2019-07-29T14:25:42.1458600Z ==> Deleted Formulae
2019-07-29T14:25:42.1458750Z libggz
2019-07-29T14:25:42.1458830Z libguess
2019-07-29T14:25:42.1458990Z lysp
2019-07-29T14:25:42.1791490Z ##[error]Bash exited with code '1'.
2019-07-29T14:25:42.2065650Z ##[section]Starting: Upload CPU usage statistics
2019-07-29T14:25:42.2070580Z ==============================================================================
2019-07-29T14:25:42.2070700Z Task         : Bash
2019-07-29T14:25:42.2070770Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-29T14:25:42.3926220Z Script contents:
2019-07-29T14:25:42.3927070Z aws s3 cp --acl public-read cpu-usage.csv s3://$DEPLOY_BUCKET/rustc-builds/$BUILD_SOURCEVERSION/cpu-$SYSTEM_JOBNAME.csv
2019-07-29T14:25:42.3952080Z ========================== Starting Command Output ===========================
2019-07-29T14:25:42.3978740Z [command]/bin/bash --noprofile --norc /Users/vsts/agent/2.154.3/work/_temp/bc555231-107f-453b-8479-d3b06170a06a.sh
2019-07-29T14:25:42.4105520Z /Users/vsts/agent/2.154.3/work/_temp/bc555231-107f-453b-8479-d3b06170a06a.sh: line 1: aws: command not found
2019-07-29T14:25:42.4190270Z ##[error]Bash exited with code '127'.
2019-07-29T14:25:42.4274930Z ##[section]Starting: Checkout
2019-07-29T14:25:42.4278010Z ==============================================================================
2019-07-29T14:25:42.4278200Z Task         : Get sources
2019-07-29T14:25:42.4278380Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[bors]

💔 Test failed - checks-azure

[alexcrichton]

@bors: retry

[max-sixty]

Thanks @lzutao, changed

[max-sixty]

I pushed a set of rebased commits.

(Do the dictums conflicts a) "don't change old commits: new commits for new changes" and b) "rebase, don't merge" ? Maybe I'm misunderstanding them)

[alexcrichton]

@bors: r+

Nah this is fine, thanks!

[bors]

📌 Commit 3325ff6 has been approved by alexcrichton

[max-sixty]

Cheers @alexcrichton !