Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsyntax: Remove extern mod foo { ... } from the language. #6375

Closed
wants to merge 1 commit into from
Closed

libsyntax: Remove extern mod foo { ... } from the language. #6375

wants to merge 1 commit into from

Conversation

pcwalton
Copy link
Contributor

@pcwalton pcwalton commented May 9, 2013

@catamorphism
Copy link
Contributor

Ok except for the documentation, as per my line comments -- I'll r+ after that's fixed.

@pcwalton pcwalton closed this May 23, 2013
@pcwalton pcwalton deleted the de-extern-mod branch May 23, 2013 05:05
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 2, 2021
@bors
Auto merge of rust-lang#6375 - camsteffen:reassign-default-private, r…
3661848 
…=flip1995

Reassign default private

changelog: fix field_reassign_with_default false positive

* Fix rust-lang#6344
* Fix assumption that `field: Default::default()` is the same as `..Default::default()`
* Cleanup some redundant logic
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 4, 2021
@bors
Auto merge of rust-lang#6537 - flip1995:beta, r=ebroto
4bd77a1 
[beta] Backport of rust-lang#6375 - field_reassign_with_default fix

With the pinned nightly we can test backports to our beta branch now 🎉

cc rust-lang#6515

changelog: beta 1.50: Backport of private fields fix in [`field_reassign_with_default`] lints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcwalton @catamorphism @bors