Misc CI improvements #66090
Merged
Misc CI improvements #66090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit 49babcc91b2250d1a128680c3eb0a7328ce5b1ae has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup=never p=1 This is blocking other CI improvements, and it will probably rebuild most of the Docker images causing an initial timeout on Linux builders. |
|
⌛ Testing commit 49babcc91b2250d1a128680c3eb0a7328ce5b1ae with merge c1ffa72751c62c1101900525824f4fd81dee1daa... |
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #66143) made this pull request unmergeable. Please resolve the merge conflicts. |
pietroalbini
force-pushed
the
ci-improvements
branch
from
49babcc
to
b3de43b
Compare
|
@bors r=alexcrichton |
|
📌 Commit b3de43b28099495fe8360775391ce4cd83bef730 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit b3de43b28099495fe8360775391ce4cd83bef730 with merge 17da013335b6a133e0805c7af883798505ffa916... |
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
Turns out we can't use the CDN for the first few downloads of @bors r=alexcrichton |
|
📌 Commit 70602e4e75fdb6b7ca9c08052a0e20ea0df02097 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 70602e4e75fdb6b7ca9c08052a0e20ea0df02097 with merge 0cc3cc4b612962a80e7c792a757d97674df7c24d... |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 12, 2019
Misc CI improvements This PR contains some misc improvements to our CI configuration: * The environment variables for MinGW builders were greatly simplified, with just `CUSTOM_MINGW=1` to tell the install scripts to install the vendored copy. All the others (`MINGW_URL`, `MINGW_DIR`, `MINGW_ARCHIVE` and `MSYS_BITS`) are detected either from the builder name or the environment. * Collecting CPU stats and running the build were moved into scripts. * Toolstate scripts validation was previously a separate step, ran just when `IMAGE=mingw-check`. This moves the validation code inside the actual image. * Vendored copies are now fetched from https://ci-mirrors.rust-lang.org instead of directly from the bucket. r? @alexcrichton
|
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-author
|
Ping from triage Thank you. |
|
@bors retry Checked locally, the failure was spurious. |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 85132b2 with merge 1a2bfe3627e584ca9a06166273948448a569c71c... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry rollup p=0 Great, all the caches are now populated, and the dist x86_64 builders timed out as expected. As all the other builders passed this is safe to rollup. |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 19, 2019
…xcrichton Misc CI improvements This PR contains some misc improvements to our CI configuration: * The environment variables for MinGW builders were greatly simplified, with just `CUSTOM_MINGW=1` to tell the install scripts to install the vendored copy. All the others (`MINGW_URL`, `MINGW_DIR`, `MINGW_ARCHIVE` and `MSYS_BITS`) are detected either from the builder name or the environment. * Collecting CPU stats and running the build were moved into scripts. * Toolstate scripts validation was previously a separate step, ran just when `IMAGE=mingw-check`. This moves the validation code inside the actual image. * Vendored copies are now fetched from https://ci-mirrors.rust-lang.org instead of directly from the bucket. r? @alexcrichton
bors
added a commit
that referenced
this pull request
Nov 19, 2019
Rollup of 13 pull requests Successful merges: - #66090 (Misc CI improvements) - #66239 (Suggest calling async closure when needed) - #66430 ([doc] Fix the source code highlighting on source comments) - #66431 (Fix 'type annotations needed' error with opaque types) - #66461 (Add explanation message for E0641) - #66468 (Cleanup Miri SIMD intrinsics) - #66478 (rustc_plugin: Remove the compatibility shim) - #66493 (Add JohnTitor to rustc-guide toolstate notification list) - #66511 (std::error::Chain: remove Copy) - #66512 (Add unix::process::CommandExt::arg0) - #66520 (Disable gdb pretty printer global section on wasm targets) - #66529 (resolve: Give derive helpers highest priority during resolution) - #66536 (Move the definition of `QueryResult` into `plumbing.rs`.) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 19, 2019
…xcrichton Misc CI improvements This PR contains some misc improvements to our CI configuration: * The environment variables for MinGW builders were greatly simplified, with just `CUSTOM_MINGW=1` to tell the install scripts to install the vendored copy. All the others (`MINGW_URL`, `MINGW_DIR`, `MINGW_ARCHIVE` and `MSYS_BITS`) are detected either from the builder name or the environment. * Collecting CPU stats and running the build were moved into scripts. * Toolstate scripts validation was previously a separate step, ran just when `IMAGE=mingw-check`. This moves the validation code inside the actual image. * Vendored copies are now fetched from https://ci-mirrors.rust-lang.org instead of directly from the bucket. r? @alexcrichton
bors
added a commit
that referenced
this pull request
Nov 19, 2019
Rollup of 11 pull requests Successful merges: - #66090 (Misc CI improvements) - #66155 (Add long error explanation for E0594) - #66239 (Suggest calling async closure when needed) - #66430 ([doc] Fix the source code highlighting on source comments) - #66431 (Fix 'type annotations needed' error with opaque types) - #66461 (Add explanation message for E0641) - #66493 (Add JohnTitor to rustc-guide toolstate notification list) - #66511 (std::error::Chain: remove Copy) - #66529 (resolve: Give derive helpers highest priority during resolution) - #66536 (Move the definition of `QueryResult` into `plumbing.rs`.) - #66538 (Remove compiler_builtins_lib feature from libstd) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some misc improvements to our CI configuration:
CUSTOM_MINGW=1to tell the install scripts to install the vendored copy. All the others (MINGW_URL,MINGW_DIR,MINGW_ARCHIVEandMSYS_BITS) are detected either from the builder name or the environment.IMAGE=mingw-check. This moves the validation code inside the actual image.r? @alexcrichton