Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying LLVM args in target specifications #68059

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Allow specifying LLVM args in target specifications #68059

merged 1 commit into from
Jan 10, 2020

Conversation

jethrogb
Copy link
Contributor

@jethrogb jethrogb commented Jan 9, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 9, 2020
@jethrogb jethrogb mentioned this pull request Jan 9, 2020
Closed
@cramertj
Copy link
Member

cramertj commented Jan 9, 2020

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jan 9, 2020

📌 Commit 010b66d has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2020
Centril added a commit to Centril/rust that referenced this pull request Jan 10, 2020
@Centril
Rollup merge of rust-lang#68059 - jethrogb:jb/target-llvm-args, r=ale…
0d959ad 
…xcrichton

Allow specifying LLVM args in target specifications
@Centril Centril mentioned this pull request Jan 10, 2020
Closed
@Centril
Copy link
Contributor

Centril commented Jan 10, 2020

Failed in #68077, probably in combination with something else (rustfmt complains).

@Centril
Copy link
Contributor

Centril commented Jan 10, 2020

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 10, 2020
@jethrogb
Copy link
Contributor Author

Re-formatted

@jethrogb
Copy link
Contributor Author

@rustbot modify labels S-waiting-on-review

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2020

Error: Parsing label command in comment failed: ...ify labels|error: must have : or to as label starter at >| S-waiting...

Please let @rust-lang/release know if you're having trouble with this bot.

@jethrogb
Copy link
Contributor Author

@rustbot modify labels: S-waiting-on-review

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2020
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jan 10, 2020

📌 Commit afced94 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 10, 2020
@JohnTitor
Rollup merge of rust-lang#68059 - jethrogb:jb/target-llvm-args, r=ale…
1af7524 
…xcrichton

Allow specifying LLVM args in target specifications
@JohnTitor JohnTitor mentioned this pull request Jan 10, 2020
Merged
bors added a commit that referenced this pull request Jan 10, 2020
@bors
Auto merge of #68101 - JohnTitor:rollup-mvmjukr, r=JohnTitor
1756313 
Rollup of 8 pull requests

Successful merges:

 - #66045 (Add method Result::into_ok)
 - #67258 (Introduce `X..`, `..X`, and `..=X` range patterns)
 - #68014 (Unify output of "variant not found" errors)
 - #68019 (Build compiletest with in-tree libtest)
 - #68039 (remove explicit strip-hidden pass from compiler doc generation)
 - #68050 (Canonicalize rustc_error imports)
 - #68059 (Allow specifying LLVM args in target specifications)
 - #68075 (rustbuild: Cleanup book generation)

Failed merges:

 - #68089 (Unstabilize `Vec::remove_item`)

r? @ghost
@bors bors merged commit afced94 into rust-lang:master Jan 10, 2020
@jethrogb jethrogb mentioned this pull request Jan 18, 2020
Merged
Centril added a commit to Centril/rust that referenced this pull request Jan 21, 2020
@Centril
Rollup merge of rust-lang#68328 - jethrogb:jb/target-llvm-args, r=ale…
3fa8cc3 
…xcrichton

Actually pass target LLVM args to LLVM

Missed in rust-lang#68059

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jethrogb @rust-highfive @cramertj @alexcrichton @bors @Centril @rustbot